From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A299C18DF4 for ; Wed, 19 Feb 2020 18:50:36 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1AEC524670 for ; Wed, 19 Feb 2020 18:50:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="WwTkRQiP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1AEC524670 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 6200F1697; Wed, 19 Feb 2020 19:49:44 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 6200F1697 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1582138234; bh=8hW+IVM4hWtGHflR/ldW2Eih3y9DxPkXsx5/3+xQSAU=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=WwTkRQiPx/qxOifumXGA70sSe803TmWBM7kzEuPsQJkQyurN4QHXGPq5fxyyCwKTU 4Tk9W24I4PTB4Yk3p/91hpUgu1n7DXaoRkg4ixYPzaEboIikYTokh1YNeKYEq/M8x/ R9PsYYCYULeh5i8lAfO47hqo2nfHXfxPbpBOqaJU= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id CC1D0F8025F; Wed, 19 Feb 2020 19:49:43 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id BC266F80273; Wed, 19 Feb 2020 19:49:42 +0100 (CET) Received: from muru.com (muru.com [72.249.23.125]) by alsa1.perex.cz (Postfix) with ESMTP id 44522F80114 for ; Wed, 19 Feb 2020 19:49:21 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 44522F80114 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 9CA2B80F3; Wed, 19 Feb 2020 18:50:03 +0000 (UTC) Date: Wed, 19 Feb 2020 10:49:16 -0800 From: Tony Lindgren To: Mark Brown Subject: Re: [PATCH] ASoC: cpcap: Implement set_tdm_slot for voice call support Message-ID: <20200219184916.GB37466@atomide.com> References: <20200212144620.GJ64767@atomide.com> <9a060430-5a3e-61e1-3d2c-f89819d9436f@ti.com> <20200217232325.GD35972@atomide.com> <8fc1dded-6d28-f5cd-f2f9-3a6810571119@ti.com> <20200218153211.GI35972@atomide.com> <20200218170628.r47xc3yydg6xx2yh@earth.universe> <20200218174258.GK4232@sirena.org.uk> <20200219173902.GA37466@atomide.com> <20200219174600.GH4488@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200219174600.GH4488@sirena.org.uk> Cc: alsa-devel@alsa-project.org, Liam Girdwood , linux-kernel@vger.kernel.org, Merlijn Wajer , Takashi Iwai , Peter Ujfalusi , Pavel Machek , linux-omap@vger.kernel.org, "Arthur D ." , Sebastian Reichel , Jarkko Nikula X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" * Mark Brown [200219 17:46]: > On Wed, Feb 19, 2020 at 09:39:02AM -0800, Tony Lindgren wrote: > > * Mark Brown [200218 17:43]: > > > > you to address for system enablement. OTOH if you manage to get one of > > > the generic cards working well that'd be excellent! > > > Well to me it seems that we just already have all the data needed with > > the graph binding and snd-soc-audio-graph-card + codec2codec support. > > > I don't think we have cases where the cpcap codec is not the master, > > so as long as the cpcap codec knows what's going on then there > > may not be a need for machine driver. > > > I guess the the bluetooth to modem path is the one to check to see > > what provides the clocks.. > > Usually in telephony cases it's the modem that's the clock master FWIW. Well at least the samplerate needs to be configured in the cpcap codec driver for voice calls, and we're setting CPCAP_BIT_CDC_CLK_EN bit for voice call which is the "Voice DAI Clock". It's also set when just playing audio using the voice channel is used. And we also have a similar bit for CPCAP_BIT_ST_CLK_EN for "HiFi DAI Clock" for the hifi channel. So these would seem to hit that it is really the cpcap that's the clock master for voice calls in this case. But I guess the test to do there would be to just clear the bit for CPCAP_BIT_CDC_CLK_EN during a voice call and see if it still works. Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BBE5C34056 for ; Wed, 19 Feb 2020 18:49:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0CD6324671 for ; Wed, 19 Feb 2020 18:49:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726638AbgBSStV (ORCPT ); Wed, 19 Feb 2020 13:49:21 -0500 Received: from muru.com ([72.249.23.125]:56096 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726634AbgBSStV (ORCPT ); Wed, 19 Feb 2020 13:49:21 -0500 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 9CA2B80F3; Wed, 19 Feb 2020 18:50:03 +0000 (UTC) Date: Wed, 19 Feb 2020 10:49:16 -0800 From: Tony Lindgren To: Mark Brown Cc: Sebastian Reichel , Peter Ujfalusi , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, "Arthur D ." , Merlijn Wajer , Pavel Machek , Jarkko Nikula Subject: Re: [PATCH] ASoC: cpcap: Implement set_tdm_slot for voice call support Message-ID: <20200219184916.GB37466@atomide.com> References: <20200212144620.GJ64767@atomide.com> <9a060430-5a3e-61e1-3d2c-f89819d9436f@ti.com> <20200217232325.GD35972@atomide.com> <8fc1dded-6d28-f5cd-f2f9-3a6810571119@ti.com> <20200218153211.GI35972@atomide.com> <20200218170628.r47xc3yydg6xx2yh@earth.universe> <20200218174258.GK4232@sirena.org.uk> <20200219173902.GA37466@atomide.com> <20200219174600.GH4488@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200219174600.GH4488@sirena.org.uk> Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org * Mark Brown [200219 17:46]: > On Wed, Feb 19, 2020 at 09:39:02AM -0800, Tony Lindgren wrote: > > * Mark Brown [200218 17:43]: > > > > you to address for system enablement. OTOH if you manage to get one of > > > the generic cards working well that'd be excellent! > > > Well to me it seems that we just already have all the data needed with > > the graph binding and snd-soc-audio-graph-card + codec2codec support. > > > I don't think we have cases where the cpcap codec is not the master, > > so as long as the cpcap codec knows what's going on then there > > may not be a need for machine driver. > > > I guess the the bluetooth to modem path is the one to check to see > > what provides the clocks.. > > Usually in telephony cases it's the modem that's the clock master FWIW. Well at least the samplerate needs to be configured in the cpcap codec driver for voice calls, and we're setting CPCAP_BIT_CDC_CLK_EN bit for voice call which is the "Voice DAI Clock". It's also set when just playing audio using the voice channel is used. And we also have a similar bit for CPCAP_BIT_ST_CLK_EN for "HiFi DAI Clock" for the hifi channel. So these would seem to hit that it is really the cpcap that's the clock master for voice calls in this case. But I guess the test to do there would be to just clear the bit for CPCAP_BIT_CDC_CLK_EN during a voice call and see if it still works. Regards, Tony