All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Veerabhadrarao Badiganti <vbadigan@codeaurora.org>
Cc: ulf.hansson@linaro.org, asutoshd@codeaurora.org,
	stummala@codeaurora.org, sayalil@codeaurora.org,
	cang@codeaurora.org, rampraka@codeaurora.org,
	dianders@google.com, linux-mmc@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	Mark Rutland <mark.rutland@arm.com>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>
Subject: Re: [PATCH V2] dt-bindings: mmc: sdhci-msm: Add CQE reg map
Date: Wed, 19 Feb 2020 14:08:27 -0600	[thread overview]
Message-ID: <20200219200827.GA17094@bogus> (raw)
In-Reply-To: <1581680753-9067-1-git-send-email-vbadigan@codeaurora.org>

On Fri, Feb 14, 2020 at 05:15:52PM +0530, Veerabhadrarao Badiganti wrote:
> CQE feature has been enabled on sdhci-msm. Add CQE reg map
> that needs to be supplied for supporting CQE feature.
> 
> Signed-off-by: Veerabhadrarao Badiganti <vbadigan@codeaurora.org>
> ---
> 
> Changes since V1:
> 	- Updated description for more clarity & Fixed typos.
> ---
>  Documentation/devicetree/bindings/mmc/sdhci-msm.txt | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.txt b/Documentation/devicetree/bindings/mmc/sdhci-msm.txt
> index 7ee639b..ad0ee83 100644
> --- a/Documentation/devicetree/bindings/mmc/sdhci-msm.txt
> +++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.txt
> @@ -26,7 +26,13 @@ Required properties:
>  
>  - reg: Base address and length of the register in the following order:
>  	- Host controller register map (required)
> -	- SD Core register map (required for msm-v4 and below)
> +	- SD Core register map (required for controllers earlier than msm-v5)
> +	- CQE register map (Optional, CQE support is present on SDHC instance meant
> +	                    for eMMC and version v4.2 and above)
> +- reg-names: When CQE register map is supplied, below reg-names are required
> +	- "hc_mem" for Host controller register map
> +	- "core_mem" for SD core register map
> +	- "cqhci_mem" for CQE register map

'_mem' is redundant, so drop.

>  - interrupts: Should contain an interrupt-specifiers for the interrupts:
>  	- Host controller interrupt (required)
>  - pinctrl-names: Should contain only one value - "default".
> -- 
> Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc., is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
> 

  reply	other threads:[~2020-02-19 20:08 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-11 15:29 [PATCH V1] dt-bindings: mmc: sdhci-msm: Add CQE reg map Veerabhadrarao Badiganti
2020-02-11 16:42 ` Doug Anderson
2020-02-12 12:00   ` Veerabhadrarao Badiganti
2020-02-12 23:21     ` Doug Anderson
2020-02-14 11:45 ` [PATCH V2] " Veerabhadrarao Badiganti
2020-02-19 20:08   ` Rob Herring [this message]
2020-02-24 11:44 ` Veerabhadrarao Badiganti
2020-02-24 11:57 ` [PATCH V3] " Veerabhadrarao Badiganti
2020-02-27 20:54   ` Doug Anderson
2020-02-28 15:10   ` Rob Herring
2020-03-04 15:34   ` Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200219200827.GA17094@bogus \
    --to=robh@kernel.org \
    --cc=asutoshd@codeaurora.org \
    --cc=cang@codeaurora.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@google.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=rampraka@codeaurora.org \
    --cc=sayalil@codeaurora.org \
    --cc=stummala@codeaurora.org \
    --cc=ulf.hansson@linaro.org \
    --cc=vbadigan@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.