From: Taylor Blau <me@ttaylorr.com>
To: Derrick Stolee <stolee@gmail.com>
Cc: Git List <git@vger.kernel.org>
Subject: Re: Git Test Coverage Report (Feb. 18, 2020)
Date: Wed, 19 Feb 2020 12:44:30 -0800 [thread overview]
Message-ID: <20200219204430.GB5101@syl.local> (raw)
In-Reply-To: <2c97befe-9be8-9946-b643-91656fa3dcd8@gmail.com>
Hi Stolee,
Thanks as always for collecting these. I always finds these emails very
helpful.
On Tue, Feb 18, 2020 at 07:46:03AM -0500, Derrick Stolee wrote:
> Taylor Blau 5d5916fd builtin/commit-graph.c: support '--split[=<strategy>]'
> commit-graph.c
> 5d5916fd 1751) break;
This 'break' line only changed indentation, so I don't think that this
is new 'uncovered' code in my series, only that it got a little bit
harder to trigger.
It is interesting that this is uncovered, but I don't think that there's
a huge sense of urgency to add tests to cover it.
> Taylor Blau a599e2c9 builtin/commit-graph.c: introduce '--input=<source>'
> builtin/commit-graph.c
> a599e2c9 75) *to = 0;
> a599e2c9 76) return 0;
These seem more interesting to cover, but only marginally so.
> a599e2c9 86) *to |= COMMIT_GRAPH_INPUT_APPEND;
This one I think we could ignore, though, since the same behavior is
triggered by simply '--append' instead of '--input=append'. We decided
in [1] to
Thanks,
Taylor
[1]: 846706e9-efe2-448d-67a3-a96638e9bcbc@gmail.com
next prev parent reply other threads:[~2020-02-19 20:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-18 12:46 Git Test Coverage Report (Feb. 18, 2020) Derrick Stolee
2020-02-18 12:55 ` Derrick Stolee
2020-02-19 20:44 ` Taylor Blau [this message]
2020-02-20 13:52 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200219204430.GB5101@syl.local \
--to=me@ttaylorr.com \
--cc=git@vger.kernel.org \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.