From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA51AC34022 for ; Wed, 19 Feb 2020 21:15:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8B64624670 for ; Wed, 19 Feb 2020 21:15:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727291AbgBSVPS (ORCPT ); Wed, 19 Feb 2020 16:15:18 -0500 Received: from muru.com ([72.249.23.125]:56186 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726645AbgBSVPS (ORCPT ); Wed, 19 Feb 2020 16:15:18 -0500 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 09A4980F3; Wed, 19 Feb 2020 21:16:00 +0000 (UTC) Date: Wed, 19 Feb 2020 13:15:13 -0800 From: Tony Lindgren To: Pavel Machek Cc: Lee Jones , kernel list , linux-arm-kernel , linux-omap@vger.kernel.org, sre@kernel.org, nekit1000@gmail.com, mpartap@gmx.net, merlijn@wizzup.org, martin_rysavy@centrum.cz, agx@sigxcpu.org, daniel.thompson@linaro.org, jingoohan1@gmail.com, dri-devel@lists.freedesktop.org, tomi.valkeinen@ti.com, jjhiblot@ti.com Subject: Re: [PATCH] backlight: add led-backlight driver Message-ID: <20200219211513.GE37466@atomide.com> References: <20200219191412.GA15905@amd> <20200219194540.GD37466@atomide.com> <20200219205322.GA1227@duo.ucw.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200219205322.GA1227@duo.ucw.cz> Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org * Pavel Machek [200219 20:54]: > Hi! > > > > This patch adds a led-backlight driver (led_bl), which is similar to > > > pwm_bl except the driver uses a LED class driver to adjust the > > > brightness in the HW. Multiple LEDs can be used for a single backlight. > > > > > > Signed-off-by: Tomi Valkeinen > > > Signed-off-by: Jean-Jacques Hiblot > > > Acked-by: Pavel Machek > > > Reviewed-by: Daniel Thompson > > > Acked-by: Lee Jones > > > Acked-by: Tony Lindgren > > > Tested-by: Tony Lindgren > > > Signed-off-by: Pavel Machek > > > --- > > > drivers/video/backlight/Kconfig | 7 ++ > > > drivers/video/backlight/Makefile | 1 + > > > drivers/video/backlight/led_bl.c | 260 +++++++++++++++++++++++++++++++++++++++ > > > 3 files changed, 268 insertions(+) > > > create mode 100644 drivers/video/backlight/led_bl.c > > > > Here's the version of the driver I have. AFAICT > > > default-brightness-level handling is ok, so does not need to be > > > changed. > > > > > > Lee, it would be easiest for me if you could apply it to your tree and > > > push, but given enough time I can push it to Linus, too. > > > > Oh you're using quoted-printable for patches.. Got it applied now, > > and it still works. Below is also the related dts change that > > I tested with. > > > > Feel free to pick the dts change too, naturally that should > > not be applied before the driver. > > > > If you guys instead want me to pick these both into my fixes > > branch, just let me know and I'll do the explaining why these > > are needed as fixes. Basically we no longer have a way to enable > > the LCD backlight for droid4 manually starting with v5.6-rc1 > > unlike earlier. > > If you are willing to do that, it looks like good solution from my > point of view. OK. I'll apply them but won't push out yet in case Lee is already applying the driver change.. Pavel, care to ack the dts patch? Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8196C3524E for ; Wed, 19 Feb 2020 21:15:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 96B09208C4 for ; Wed, 19 Feb 2020 21:15:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rJ2jb5ke" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 96B09208C4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=35n2cSeJZLFoJx06gFkQAEMPEeruw7z2TWFWDztJsVI=; b=rJ2jb5keEe9YNM 0QayBEsNMQK+VBAjXtHpgSEYsgPQw2Cq/bziIc9n86N67i4Ar+4oj/r3QE2yKVFaMkP0nYXwNC/Zx UwKAb/uIdU9HNRrF7+ctlM31FKJLuowoKdNeaxdZOPmwYfs608JETwVTeQLUQpX7Ur2EmDcSiWnkf HbIfFORTNoIMOZXsQn7iCp1bCdqob1ZciEZNmf2h5WK5F1QNP2noXdqorNdQjEMEaJh95fF98KT3y h/XpGl5I3cZpN5+BwiPWb/qoydrTWLDDxNGGibDKGucdnUT6m3ZQ6qcH/lRznGpeFDIrT1AZpXlzu 8bs2G9sBRCPne++oYmxg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j4Wgj-0005qa-ES; Wed, 19 Feb 2020 21:15:21 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j4Wgg-0005q0-SR for linux-arm-kernel@lists.infradead.org; Wed, 19 Feb 2020 21:15:20 +0000 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 09A4980F3; Wed, 19 Feb 2020 21:16:00 +0000 (UTC) Date: Wed, 19 Feb 2020 13:15:13 -0800 From: Tony Lindgren To: Pavel Machek Subject: Re: [PATCH] backlight: add led-backlight driver Message-ID: <20200219211513.GE37466@atomide.com> References: <20200219191412.GA15905@amd> <20200219194540.GD37466@atomide.com> <20200219205322.GA1227@duo.ucw.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200219205322.GA1227@duo.ucw.cz> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200219_131518_961786_66E566B8 X-CRM114-Status: GOOD ( 22.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: daniel.thompson@linaro.org, mpartap@gmx.net, jingoohan1@gmail.com, merlijn@wizzup.org, martin_rysavy@centrum.cz, kernel list , dri-devel@lists.freedesktop.org, sre@kernel.org, nekit1000@gmail.com, tomi.valkeinen@ti.com, jjhiblot@ti.com, linux-omap@vger.kernel.org, Lee Jones , agx@sigxcpu.org, linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org * Pavel Machek [200219 20:54]: > Hi! > > > > This patch adds a led-backlight driver (led_bl), which is similar to > > > pwm_bl except the driver uses a LED class driver to adjust the > > > brightness in the HW. Multiple LEDs can be used for a single backlight. > > > > > > Signed-off-by: Tomi Valkeinen > > > Signed-off-by: Jean-Jacques Hiblot > > > Acked-by: Pavel Machek > > > Reviewed-by: Daniel Thompson > > > Acked-by: Lee Jones > > > Acked-by: Tony Lindgren > > > Tested-by: Tony Lindgren > > > Signed-off-by: Pavel Machek > > > --- > > > drivers/video/backlight/Kconfig | 7 ++ > > > drivers/video/backlight/Makefile | 1 + > > > drivers/video/backlight/led_bl.c | 260 +++++++++++++++++++++++++++++++++++++++ > > > 3 files changed, 268 insertions(+) > > > create mode 100644 drivers/video/backlight/led_bl.c > > > > Here's the version of the driver I have. AFAICT > > > default-brightness-level handling is ok, so does not need to be > > > changed. > > > > > > Lee, it would be easiest for me if you could apply it to your tree and > > > push, but given enough time I can push it to Linus, too. > > > > Oh you're using quoted-printable for patches.. Got it applied now, > > and it still works. Below is also the related dts change that > > I tested with. > > > > Feel free to pick the dts change too, naturally that should > > not be applied before the driver. > > > > If you guys instead want me to pick these both into my fixes > > branch, just let me know and I'll do the explaining why these > > are needed as fixes. Basically we no longer have a way to enable > > the LCD backlight for droid4 manually starting with v5.6-rc1 > > unlike earlier. > > If you are willing to do that, it looks like good solution from my > point of view. OK. I'll apply them but won't push out yet in case Lee is already applying the driver change.. Pavel, care to ack the dts patch? Regards, Tony _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8F95C11D05 for ; Thu, 20 Feb 2020 08:45:47 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 98DB0207FD for ; Thu, 20 Feb 2020 08:45:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 98DB0207FD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 234186ECF5; Thu, 20 Feb 2020 08:45:39 +0000 (UTC) Received: from muru.com (muru.com [72.249.23.125]) by gabe.freedesktop.org (Postfix) with ESMTP id A38256ECB6 for ; Wed, 19 Feb 2020 21:15:18 +0000 (UTC) Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 09A4980F3; Wed, 19 Feb 2020 21:16:00 +0000 (UTC) Date: Wed, 19 Feb 2020 13:15:13 -0800 From: Tony Lindgren To: Pavel Machek Subject: Re: [PATCH] backlight: add led-backlight driver Message-ID: <20200219211513.GE37466@atomide.com> References: <20200219191412.GA15905@amd> <20200219194540.GD37466@atomide.com> <20200219205322.GA1227@duo.ucw.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200219205322.GA1227@duo.ucw.cz> X-Mailman-Approved-At: Thu, 20 Feb 2020 08:45:37 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: daniel.thompson@linaro.org, mpartap@gmx.net, jingoohan1@gmail.com, merlijn@wizzup.org, martin_rysavy@centrum.cz, kernel list , dri-devel@lists.freedesktop.org, sre@kernel.org, nekit1000@gmail.com, tomi.valkeinen@ti.com, jjhiblot@ti.com, linux-omap@vger.kernel.org, Lee Jones , agx@sigxcpu.org, linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" * Pavel Machek [200219 20:54]: > Hi! > > > > This patch adds a led-backlight driver (led_bl), which is similar to > > > pwm_bl except the driver uses a LED class driver to adjust the > > > brightness in the HW. Multiple LEDs can be used for a single backlight. > > > > > > Signed-off-by: Tomi Valkeinen > > > Signed-off-by: Jean-Jacques Hiblot > > > Acked-by: Pavel Machek > > > Reviewed-by: Daniel Thompson > > > Acked-by: Lee Jones > > > Acked-by: Tony Lindgren > > > Tested-by: Tony Lindgren > > > Signed-off-by: Pavel Machek > > > --- > > > drivers/video/backlight/Kconfig | 7 ++ > > > drivers/video/backlight/Makefile | 1 + > > > drivers/video/backlight/led_bl.c | 260 +++++++++++++++++++++++++++++++++++++++ > > > 3 files changed, 268 insertions(+) > > > create mode 100644 drivers/video/backlight/led_bl.c > > > > Here's the version of the driver I have. AFAICT > > > default-brightness-level handling is ok, so does not need to be > > > changed. > > > > > > Lee, it would be easiest for me if you could apply it to your tree and > > > push, but given enough time I can push it to Linus, too. > > > > Oh you're using quoted-printable for patches.. Got it applied now, > > and it still works. Below is also the related dts change that > > I tested with. > > > > Feel free to pick the dts change too, naturally that should > > not be applied before the driver. > > > > If you guys instead want me to pick these both into my fixes > > branch, just let me know and I'll do the explaining why these > > are needed as fixes. Basically we no longer have a way to enable > > the LCD backlight for droid4 manually starting with v5.6-rc1 > > unlike earlier. > > If you are willing to do that, it looks like good solution from my > point of view. OK. I'll apply them but won't push out yet in case Lee is already applying the driver change.. Pavel, care to ack the dts patch? Regards, Tony _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel