From: Rob Herring <robh@kernel.org>
To: Alexey Minnekhanov <alexey.min@gmail.com>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
linux-arm-msm@vger.kernel.org,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org
Subject: Re: [PATCH 3/5] dt-bindings: arm: qcom: Add sdm630 and sdm660 SoCs
Date: Wed, 19 Feb 2020 16:20:18 -0600 [thread overview]
Message-ID: <20200219222018.GA6988@bogus> (raw)
In-Reply-To: <20200212170916.7494-4-alexey.min@gmail.com>
On Wed, Feb 12, 2020 at 08:09:14PM +0300, Alexey Minnekhanov wrote:
> Add a SoC strings for the Qualcomm SDM630 and SDM660 SoCs.
> Also document the new xiaomi,lavender compatible used in
> a device tree binding.
>
> Signed-off-by: Alexey Minnekhanov <alexey.min@gmail.com>
> ---
> Documentation/devicetree/bindings/arm/qcom.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index 529d924931f1..c5af92acd427 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -36,6 +36,8 @@ description: |
> msm8994
> msm8996
> sc7180
> + sdm630
> + sdm660
> sdm845
>
> The 'board' element must be one of the following strings:
> @@ -125,6 +127,11 @@ properties:
> - samsung,a5u-eur
> - const: qcom,msm8916
>
> + - items:
> + - enum:
> + - xiaomi,lavender
> + - const: qcom,sdm660
I think you want to keep this sorted by the compatible string and not be
in the middle of msm89xx.
> +
> - items:
> - const: qcom,msm8996-mtp
>
> --
> 2.20.1
>
next prev parent reply other threads:[~2020-02-19 22:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-12 17:09 [PATCH 0/5] Add initial support for SDM660/630 SoCs Alexey Minnekhanov
2020-02-12 17:09 ` [PATCH 1/5] dt-bindings: Add vendor prefix for Xiaomi Alexey Minnekhanov
2020-02-19 22:20 ` Rob Herring
2020-02-12 17:09 ` [PATCH 2/5] dt-bindings: arm: Add kryo260 compatible Alexey Minnekhanov
2020-02-19 22:21 ` Rob Herring
2020-02-12 17:09 ` [PATCH 3/5] dt-bindings: arm: qcom: Add sdm630 and sdm660 SoCs Alexey Minnekhanov
2020-02-19 22:20 ` Rob Herring [this message]
2020-02-12 17:09 ` [PATCH 4/5] arm64: dts: qcom: Add SDM660 SoC support Alexey Minnekhanov
2020-02-20 7:06 ` Bjorn Andersson
2020-02-12 17:09 ` [PATCH 5/5] arm64: dts: qcom: Add Xiaomi Redmi Note 7 (lavender) Alexey Minnekhanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200219222018.GA6988@bogus \
--to=robh@kernel.org \
--cc=agross@kernel.org \
--cc=alexey.min@gmail.com \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=mark.rutland@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.