All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Julius Werner <jwerner@chromium.org>
Cc: Rob Herring <robh@kernel.org>, Evan Benn <evanbenn@chromium.org>,
	LKML <linux-kernel@vger.kernel.org>,
	devicetree@vger.kernel.org,
	"David S. Miller" <davem@davemloft.net>,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
	Wim Van Sebroeck <wim@linux-watchdog.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Mark Rutland <mark.rutland@arm.com>,
	linux-watchdog@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: watchdog: Add arm,smc-wdt watchdog arm,smc-wdt compatible
Date: Wed, 19 Feb 2020 15:20:05 -0800	[thread overview]
Message-ID: <20200219232005.GA9737@roeck-us.net> (raw)
In-Reply-To: <CAODwPW8JspiUtyU4CC95w9rbNRyUF-Aeb9TuPm1PzmP6u=y1EA@mail.gmail.com>

On Wed, Feb 19, 2020 at 03:04:54PM -0800, Julius Werner wrote:
> > You are not the first 'watchdog in firmware accessed via an SMC call'.
> > Is there some more detail about what implementation this is? Part of
> > TF-A? Defined by some spec (I can dream)?
> 
> This is just some random implementation written by me because we
> needed one. I would like it to be the new generic implementation, but
> it sounds like people here prefer the naming to be MediaTek specific
> (at least for now). The other SMC watchdog we're aware of is
> imx_sc_wdt but unfortunately that seems to hardcode platform-specific

There is one more pending, for Meson SMC.

https://patchwork.kernel.org/project/linux-watchdog/list/?series=227733

Unfortunately it uses Meson firmware API functions, though it has pretty
much the same functionality since those ultimately end up calling
arm_smccc_smc().

Guenter

> details in the interface (at least in the pretimeout SMC) so we can't
> just expand that. With this driver I tried to directly wrap the kernel
> watchdog interface so it should be platform-agnostic and possible to
> expand this driver to other platforms later if desired. The SMC
> function ID would still always have to be platform-specific,
> unfortunately (but we could pass it in through the device tree), since
> the Arm SMC spec doesn't really leave any room for OS-generic SMCs
> like this.

  reply	other threads:[~2020-02-19 23:20 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-14  6:26 [PATCH 0/2] Add a watchdog driver that uses ARM Secure Monitor Calls Evan Benn
2020-02-14  6:26 ` Evan Benn
2020-02-14  6:26 ` [PATCH 1/2] dt-bindings: watchdog: Add arm,smc-wdt watchdog arm,smc-wdt compatible Evan Benn
2020-02-19 22:30   ` Rob Herring
2020-02-19 23:04     ` Julius Werner
2020-02-19 23:20       ` Guenter Roeck [this message]
2020-02-20  6:41         ` Evan Benn
2020-02-20 15:43           ` Guenter Roeck
2020-02-21 15:36           ` Xingyu Chen
2020-02-21 19:41             ` Julius Werner
2020-02-21 20:46               ` Guenter Roeck
2020-02-22  4:01               ` Xingyu Chen
2020-02-24  1:10                 ` Evan Benn
2020-02-25  1:23                 ` Julius Werner
2020-02-25  7:44                   ` Xingyu Chen
2020-02-25  7:44                     ` Xingyu Chen
2020-03-10  1:00                     ` Evan Benn
2020-03-10  1:00                       ` Evan Benn
     [not found]                       ` <ad28aa47-0490-937f-898f-0e4695ef6ec6@amlogic.com>
2020-03-11 19:24                         ` Julius Werner
2020-03-11 19:24                           ` Julius Werner
2020-03-13 16:13                           ` Xingyu Chen
2020-03-13 16:13                             ` Xingyu Chen
2020-02-14  6:26 ` [PATCH 2/2] watchdog: Add new arm_smc_wdt watchdog driver Evan Benn
2020-02-14  6:26   ` Evan Benn
2020-02-14  9:35   ` Enric Balletbo Serra
2020-02-14  9:35     ` Enric Balletbo Serra
2020-02-14 14:10   ` Guenter Roeck
2020-02-14 14:10     ` Guenter Roeck
2020-02-14 21:32     ` Julius Werner
2020-02-14 21:32       ` Julius Werner
2020-02-15  1:39       ` Evan Benn
2020-02-15  1:39         ` Evan Benn
2020-02-20  6:50     ` Evan Benn
2020-02-20  6:50       ` Evan Benn
2020-02-20 15:52       ` Guenter Roeck
2020-02-20 15:52         ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200219232005.GA9737@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=evanbenn@chromium.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jwerner@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mchehab+samsung@kernel.org \
    --cc=robh@kernel.org \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.