From: "Denys Dmytriyenko" <denys@ti.com>
To: "Andrew F. Davis" <afd@ti.com>
Cc: <meta-ti@lists.yoctoproject.org>
Subject: Re: [meta-ti][zeus/master][PATCH] ti-sgx-ddk-um: Add runtime dependency on the SGX kernel module
Date: Wed, 19 Feb 2020 18:58:33 -0500 [thread overview]
Message-ID: <20200219235832.GY720@beryl> (raw)
In-Reply-To: <ed392732-a4bb-fd54-6c0e-3c2358edba49@ti.com>
On Tue, Feb 18, 2020 at 01:08:46PM -0500, Andrew F. Davis wrote:
> On 2/18/20 12:52 PM, Denys Dmytriyenko wrote:
> > I was sitting on a similar patch in a private testing branch:
> > https://lists.yoctoproject.org/g/meta-ti/message/12418
>
> Why RRECOMMENDS? It should be a real dependency right?
Andrew,
Historically kernel modules used RRECOMMENDS.
Plus, it's easier to break RRECOMMENDS dependency than RDEPENDS. And we had
instances in the past, when we needed to be able to build against UM libs,
even when KM support is not there. Of course, it may not be an issue in the
future, when we split up UM libs package into individual libs and/or move to
Mesa based builds...
--
Denys
> > On Tue, Feb 18, 2020 at 11:06:21AM -0500, Andrew F. Davis wrote:
> >> The UM doesn't work too well without the KM side, add this dependency.
> >>
> >> Signed-off-by: Andrew F. Davis <afd@ti.com>
> >> ---
> >> recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb b/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb
> >> index 129d5cee..d4bc0232 100644
> >> --- a/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb
> >> +++ b/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb
> >> @@ -28,7 +28,7 @@ inherit update-rc.d
> >> PROVIDES += "virtual/egl virtual/libgles1 virtual/libgles2 virtual/libgbm"
> >>
> >> DEPENDS += "libdrm udev wayland wayland-protocols libffi expat"
> >> -RDEPENDS_${PN} += "libdrm libdrm-omap udev wayland wayland-protocols libffi expat"
> >> +RDEPENDS_${PN} += "libdrm libdrm-omap udev wayland wayland-protocols libffi expat ti-sgx-ddk-km"
> >>
> >> RPROVIDES_${PN} = "libegl libgles1 libgles2 libgbm"
> >> RPROVIDES_${PN}-dev = "libegl-dev libgles1-dev libgles2-dev libgbm-dev"
> >> --
> >> 2.17.1
> >>
next prev parent reply other threads:[~2020-02-19 23:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-18 16:06 [meta-ti][zeus/master][PATCH] ti-sgx-ddk-um: Add runtime dependency on the SGX kernel module Andrew F. Davis
2020-02-18 17:52 ` Denys Dmytriyenko
2020-02-18 18:08 ` Andrew F. Davis
2020-02-19 23:58 ` Denys Dmytriyenko [this message]
2020-02-20 0:06 ` Andrew F. Davis
2020-02-20 0:15 ` Denys Dmytriyenko
2020-02-20 0:38 ` Andrew F. Davis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200219235832.GY720@beryl \
--to=denys@ti.com \
--cc=afd@ti.com \
--cc=meta-ti@lists.yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.