From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1j4fhA-0002ht-Cx for mharc-grub-devel@gnu.org; Thu, 20 Feb 2020 01:52:24 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:59639) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j4fh7-0002eY-G7 for grub-devel@gnu.org; Thu, 20 Feb 2020 01:52:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j4fh2-0003zV-LW for grub-devel@gnu.org; Thu, 20 Feb 2020 01:52:21 -0500 Received: from mail-pf1-x432.google.com ([2607:f8b0:4864:20::432]:35319) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j4fh2-0003z9-G3 for grub-devel@gnu.org; Thu, 20 Feb 2020 01:52:16 -0500 Received: by mail-pf1-x432.google.com with SMTP id i19so1437331pfa.2 for ; Wed, 19 Feb 2020 22:52:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=YqLi3BkIRsD0HGBCiqRrQEcLwfsm3jeIeweyozPYSwo=; b=hGsLbe/SjRAdVx3jwX4b7V0/Xr4G4KBSVadzFsNyLbSr6ABvfEBW4u3ECt1Oy73OwI /+PAsh2vQvv14ojfkwG/L8VZLRz/UtbHmxNMtaJKGrbHZluO6bVEXPzMpZp/4suxj0mC 7UGdEBDDEc4KRJIB5zqI7yMHWTC9gSKzmJ2iIs0MZv9VIRwXDSaz8MWscP7aq6FOtReI /UljgYdjKKvRYHZd/iC1lbyMreTAtGZuQVIh6tOUT6Ssl9z2WFHYgbsfVMdF5QP8vFyZ 1m+eLy1BvcYcNqd6TV6GLf6QIK3kwo28sc0aL4fxIH0NpvlLd0tRbwJm+jP3Ya5pJbel 20mA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=YqLi3BkIRsD0HGBCiqRrQEcLwfsm3jeIeweyozPYSwo=; b=IlDXPLJYJH3ryT4hX7kOscfvilfKJGHlmVfdxRuLge31GDGgcf6VrChc9QFq4AM/TQ r8uIm9c0sFb7hFO+dvzls1UhK6q70ZtmmhHY5jFYabH4KNliZ0ryCye2b1IY+8C8thO6 f8CztDHELaF+r9cgQarkeBGs7sCP+39NZXPHKEIHsw/LA+R8ML3jAPHy+V1O0vwRZaJs N4vxdZR8/ZaXi4/Q+Ho1fN5IX16t4U1+C7hod/9VGZRV/Hk7nQPl2AFpFsMMEG0SrHbq 2Ypvzqs4WcWuRulhE+tTD7/zUjKbUrudzKY5pv0d6kFHYeEt1q5OdsTBsALQYwL7hyN4 HdVw== X-Gm-Message-State: APjAAAWyNj3Z9D30qZ0ZirIsouRX3CydXPVVsAt+SFPlKbQWHqomHwBC JGV7r3imAh74roGgjT0SLdrpUEkP X-Google-Smtp-Source: APXvYqwj5sIZrZjXEMrr32mhjEDwWplSJs0GxJ83RTXetvDUN3s3VvNMCk7nwP26xp0eqZyos5yfBw== X-Received: by 2002:a62:ce48:: with SMTP id y69mr6909108pfg.8.1582181535260; Wed, 19 Feb 2020 22:52:15 -0800 (PST) Received: from localhost ([108.161.26.224]) by smtp.gmail.com with ESMTPSA id b186sm1424890pgc.46.2020.02.19.22.52.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Feb 2020 22:52:14 -0800 (PST) From: Matt Turner To: The development of GNU GRUB Cc: Mike Gilbert Subject: [PATCH 2/2] build: Disable PIE in TARGET_CCASFLAGS if needed Date: Wed, 19 Feb 2020 22:51:42 -0800 Message-Id: <20200220065142.869129-2-mattst88@gmail.com> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200220065142.869129-1-mattst88@gmail.com> References: <20200220065142.869129-1-mattst88@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::432 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Feb 2020 06:52:22 -0000 From: Mike Gilbert PIE should be disabled in assembly sources as well, or else grub will fail to boot. Bug: https://bugs.gentoo.org/667852 --- configure.ac | 1 + 1 file changed, 1 insertion(+) diff --git a/configure.ac b/configure.ac index b5e31c787..e2c783652 100644 --- a/configure.ac +++ b/configure.ac @@ -1263,6 +1263,7 @@ grub_CHECK_LINK_PIE # `-fPIE' or '-fpie' and '-pie' in the default specs. if [ x"$pie_possible" = xyes ]; then TARGET_CFLAGS="$TARGET_CFLAGS -fno-PIE -fno-pie" + TARGET_CCASFLAGS="$TARGET_CCASFLAGS -fno-PIE -fno-pie" fi if [ x"$link_nopie_needed" = xyes ] || [ x"$pie_possible" = xyes ]; then -- 2.24.1