From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH V2 01/10] tst_device: Add tst_ismount() helper
Date: Thu, 20 Feb 2020 08:52:52 +0100 [thread overview]
Message-ID: <20200220075252.GA2860622@x230> (raw)
In-Reply-To: <20200220071923.vyr7lpftidkgbi6g@vireshk-i7>
Hi,
...
> > Sorry, I think the return value should be '1' if it has been mounted
> > already.
> > e.g
> > These codes will make people confused about whether it's
> > mounted successfully or not.
> > if (tst_ismount(MNTPOINT))
> > tst_brk(TBROK | TERRNO, "device not mounted");
> I kept the return 0 on success thing here as well, but maybe yeah, it
> should return 1 on success here.
Most of the functions returns 1 or -1 on failure. But here it's this approach
really confusing, because the name and purpose. So I'd also be for 0 on failure and 1
on success.
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Kind regards,
Petr
next prev parent reply other threads:[~2020-02-20 7:52 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-19 9:27 [LTP] [PATCH V2 00/10] Add new LTP tests related to fsmount family of syscalls Viresh Kumar
2020-02-19 9:27 ` [LTP] [PATCH V2 01/10] tst_device: Add tst_ismount() helper Viresh Kumar
2020-02-20 5:10 ` Li Wang
2020-02-20 5:20 ` Viresh Kumar
2020-02-20 7:06 ` Li Wang
2020-02-20 7:19 ` Viresh Kumar
2020-02-20 7:52 ` Petr Vorel [this message]
2020-02-19 9:27 ` [LTP] [PATCH V2 02/10] lapi/fsmount.h: Add fsopen_supported_by_kernel() Viresh Kumar
2020-02-20 8:01 ` Petr Vorel
2020-02-19 9:27 ` [LTP] [PATCH V2 03/10] lapi/fsmount.h: Include "lapi/fcntl.h" Viresh Kumar
2020-02-19 9:28 ` [LTP] [PATCH V2 04/10] syscalls/fsopen: New tests Viresh Kumar
2020-02-20 5:23 ` Li Wang
2020-02-20 8:51 ` Petr Vorel
2020-02-20 17:04 ` Petr Vorel
2020-02-24 3:18 ` Viresh Kumar
2020-02-24 3:35 ` Yang Xu
2020-02-24 6:27 ` Petr Vorel
2020-02-24 13:08 ` Cyril Hrubis
2020-02-24 15:30 ` Petr Vorel
2020-02-24 15:32 ` Cyril Hrubis
2020-02-24 15:46 ` Petr Vorel
2020-02-19 9:28 ` [LTP] [PATCH V2 05/10] syscalls/fsconfig: " Viresh Kumar
2020-02-20 5:41 ` Li Wang
2020-02-20 5:50 ` Viresh Kumar
2020-02-20 10:09 ` Li Wang
2020-02-21 16:44 ` Petr Vorel
2020-02-19 9:28 ` [LTP] [PATCH V2 06/10] syscalls/fsmount: Improve fsmount01 test Viresh Kumar
2020-02-20 6:34 ` Li Wang
2020-02-20 17:34 ` Petr Vorel
2020-02-19 9:28 ` [LTP] [PATCH V2 07/10] syscalls/fsmount: Add failure tests Viresh Kumar
2020-02-19 9:28 ` [LTP] [PATCH V2 08/10] syscalls/move_mount: New tests Viresh Kumar
2020-02-19 9:28 ` [LTP] [PATCH V2 09/10] syscalls/fspick: " Viresh Kumar
2020-02-20 7:57 ` Li Wang
2020-02-19 9:28 ` [LTP] [PATCH V2 10/10] syscalls/open_tree: " Viresh Kumar
2020-02-20 7:25 ` Li Wang
2020-02-20 7:35 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200220075252.GA2860622@x230 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.