Re: [PATCH v5] tools/perf/metricgroup: Fix printing event names of metric group with multiple events incase of overlapping events

[Jiri Olsa <jolsa@redhat.com>]

On Thu, Feb 20, 2020 at 10:31:04AM +0530, Kajol Jain wrote:

SNIP

> +				i++;
> +				if (i == idnum)
> +					break;
>  			}
>  		}
>  	}
> @@ -144,7 +142,10 @@ static struct evsel *find_evsel_group(struct evlist *perf_evlist,
>  			    !strcmp(ev->name, metric_events[i]->name)) {
>  				ev->metric_leader = metric_events[i];
>  			}
> +			j++;
>  		}
> +		ev = metric_events[i];
> +		evlist_used[ev->idx] = true;
>  	}
>  
>  	return metric_events[0];
> @@ -160,6 +161,14 @@ static int metricgroup__setup_events(struct list_head *groups,
>  	int ret = 0;
>  	struct egroup *eg;
>  	struct evsel *evsel;
> +	bool *evlist_used;
> +
> +	evlist_used = (bool *)calloc(perf_evlist->core.nr_entries,
> +				     sizeof(bool));

no need for the (bool *) cast

other than that

Acked-by: Jiri Olsa <jolsa@redhat.com>

thanks,
jirka