From: Jesse Brandeburg <jesse.brandeburg@intel.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
<x86@kernel.org>, <linux-kernel@vger.kernel.org>,
<linux@rasmusvillemoes.dk>, <andriy.shevchenko@intel.com>,
<dan.j.williams@intel.com>
Subject: Re: [PATCH v2 2/2] lib: make a test module with set/clear bit
Date: Thu, 20 Feb 2020 11:03:47 -0800 [thread overview]
Message-ID: <20200220110347.00005557@intel.com> (raw)
In-Reply-To: <20200220181033.GW14897@hirez.programming.kicks-ass.net>
On Thu, 20 Feb 2020 19:10:33 +0100 Peter wrote:
> On Thu, Feb 20, 2020 at 09:37:22AM -0800, Jesse Brandeburg wrote:
> > Test some bit clears/sets to make sure assembly doesn't change.
> > Instruct Kbuild to build this file with extra warning level -Wextra,
> > to catch new issues, and also doesn't hurt to build with C=1.
> >
> > This was used to test changes to arch/x86/include/asm/bitops.h.
> >
> > Recommended usage:
> > make defconfig
> > scripts/config -m CONFIG_TEST_BITOPS
> > make modules_prepare
> > make C=1 W=1 lib/test_bitops.ko
> > objdump -S -d lib/test_bitops.ko
>
> I only applied this second patch:
>
> # sparse --version
> 0.6.0 (Debian: 0.6.0-3+b1)
Thanks for the review! The module was created to verify assembly didn't
change before/after, but it's not a reproducer. Let me fix that (I had
skipped that step as I originally didn't plan to upstream the
test-patch).
next prev parent reply other threads:[~2020-02-20 19:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 17:37 [PATCH v2 1/2] x86: fix bitops.h warning with a moved cast Jesse Brandeburg
2020-02-20 17:37 ` [PATCH v2 2/2] lib: make a test module with set/clear bit Jesse Brandeburg
2020-02-20 18:10 ` Peter Zijlstra
2020-02-20 19:03 ` Jesse Brandeburg [this message]
2020-02-20 18:12 ` [PATCH v2 1/2] x86: fix bitops.h warning with a moved cast Peter Zijlstra
2020-02-20 22:32 ` Jesse Brandeburg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200220110347.00005557@intel.com \
--to=jesse.brandeburg@intel.com \
--cc=andriy.shevchenko@intel.com \
--cc=bp@alien8.de \
--cc=dan.j.williams@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.