From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a19:cb43:0:0:0:0:0 with SMTP id b64csp543005lfg; Thu, 20 Feb 2020 05:06:07 -0800 (PST) X-Google-Smtp-Source: APXvYqz+ItXTniJPAIOwREBF5/rpZpr9OFxlobTdwBQvDXw33sE6rn3cm9Y1RnEa7aljze7mLKrx X-Received: by 2002:a05:6808:8ee:: with SMTP id d14mr1787105oic.138.1582203967440; Thu, 20 Feb 2020 05:06:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582203967; cv=none; d=google.com; s=arc-20160816; b=YWWWafRH7qWTpMhqJgNZNkBaw3UmPzXHE5xO++sOi4q5MxF6zxzVp2izdnip5TBHAf ToLLedg7Vb8/F0D27xWKeRicps8uNoxFp+WIOnX9/mYc7kToZZQVNtxvFCOE0cNGLKmb AvAQFOgx/5+5tfSD6K/OCAN190vV3inv3EF/nKJgnC3I8xPjDEwbiL6XOmdgHDWqXzdK mR1V62I9jSd8UPSGxfIdKXDmjXx+/k0W6f43aZ7xOvpxbW1vyLx+AH7bjt7qhFHNb4iA OmNi9R3vZjaAud1RZQf6vYDNROwriEOKFM3PUv3hDBnfGIn2GwM9GXX3255BrRPyhhnh 1iVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=gu1OfO+Xr177r6zD7C+F/TxHFq6mosreIYv9UCpXME0=; b=em0dLN9xa3myJrAdjHG+r1BkwjizFfGM1ZNf+SKq2NNnyjso6+Kl9nzMJnO5DDzLya KZQ15EqSDyd0uZdwiQDUmzGgsoibnOt1i0y9EKvSlnJ+NMJ9gjvq+TLNKd5KfNmSe9/P /Z9557s61JpX4g0r/fpzrwv3qZTGMN8eNVqZR1d3nzIAZMNK61RU6aag5QM5v5Ckfv6a f3NJFZhuf2C3ZuaGpqDfKvNk0NMnQD0Eka+CpdgNVl+9bYpSGP38Nb3F5Mj1olCkOBi8 TjqjNfQEkKgouKR/2USHpiih/J/24yOhfvM0jGjuJtLXe4uDBZn1uz1Wl02LwjoutesH Z32Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=MUCDutVh; spf=pass (google.com: best guess record for domain of kvm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=kvm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b2si1957201ots.284.2020.02.20.05.06.07; Thu, 20 Feb 2020 05:06:07 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of kvm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=MUCDutVh; spf=pass (google.com: best guess record for domain of kvm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=kvm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728102AbgBTNGC (ORCPT + 5 others); Thu, 20 Feb 2020 08:06:02 -0500 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:24721 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728091AbgBTNGC (ORCPT ); Thu, 20 Feb 2020 08:06:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582203960; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=gu1OfO+Xr177r6zD7C+F/TxHFq6mosreIYv9UCpXME0=; b=MUCDutVhDBbvX3ov+Fy1NTGQKNeK9o2RCCGMZwVhiQZnKU4Uy/2f+jQYVj8gng8mP/n+xj uGQBe1IlenUeVZppYdS5QW5juQnXTs6UhS0n+Xm1Bb1qAvwbFYSVD1pCv59YkyF0zf99GX +xK23nJuP5wx7gJCbcervH+B538rAU4= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-141-4YOFUXg1NmK0mY8QyJCT9A-1; Thu, 20 Feb 2020 08:05:54 -0500 X-MC-Unique: 4YOFUXg1NmK0mY8QyJCT9A-1 Received: by mail-wm1-f69.google.com with SMTP id g138so576653wmg.8 for ; Thu, 20 Feb 2020 05:05:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=gu1OfO+Xr177r6zD7C+F/TxHFq6mosreIYv9UCpXME0=; b=BhEp4ycat83vSIjyap75qQusN6HSbqeLXFCzj1zhvIyUJyHz6C63KrDLKON5aB0OIh R0xvrbev8VQhMJ6o1jOYE0N7bVwno1WRLzJaW136hUKysbwq0fBmnDwtHbv1FToDjihk 7ijo4uAxzDHk+ksgVnG1KQk9sA78nHbYQH3o+dk2+GEnJ+K39JdPi2xpXR8GHvpRH2c1 UYz9kEB8f9YgJWwWe2MMTrb3ymU4/uuLUTamnQ3oLD6kEiegyp2roDjwUhG0cXOmbb3Q vUNAJLD9o50N4RRQrkbAbyMwLBaLhZwSK9M/pSroHt/m2tJbR09tAyqpARcfMNjHJXiy ctaQ== X-Gm-Message-State: APjAAAWq05mwhFG/vh+f73bHsDrIpkyN3tAM03eFWYeC3rWM5RAQMf9k L3Chow91Ogr0H4GlZKh296U8p10MOjBsdLsmQccjyoykmZQohRictYBCsvrx4bfD4jPqcDxOE35 AltI7qxFmr1kn X-Received: by 2002:a1c:f713:: with SMTP id v19mr4357657wmh.113.1582203953757; Thu, 20 Feb 2020 05:05:53 -0800 (PST) X-Received: by 2002:a1c:f713:: with SMTP id v19mr4357638wmh.113.1582203953503; Thu, 20 Feb 2020 05:05:53 -0800 (PST) Received: from localhost.localdomain (78.red-88-21-202.staticip.rima-tde.net. [88.21.202.78]) by smtp.gmail.com with ESMTPSA id b67sm4594690wmc.38.2020.02.20.05.05.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Feb 2020 05:05:52 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Peter Maydell , qemu-devel@nongnu.org Cc: "Edgar E. Iglesias" , Anthony Perard , Fam Zheng , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , kvm@vger.kernel.org, Laurent Vivier , Thomas Huth , Stefan Weil , Eric Auger , Halil Pasic , Marcel Apfelbaum , qemu-s390x@nongnu.org, Aleksandar Rikalo , David Gibson , Michael Walle , qemu-ppc@nongnu.org, Gerd Hoffmann , Cornelia Huck , qemu-arm@nongnu.org, Alistair Francis , qemu-block@nongnu.org, =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Jason Wang , xen-devel@lists.xenproject.org, Christian Borntraeger , Dmitry Fleytman , Matthew Rosato , Eduardo Habkost , Richard Henderson , "Michael S. Tsirkin" , David Hildenbrand , Paolo Bonzini , Stefano Stabellini , Igor Mitsyanko , Paul Durrant , Richard Henderson , John Snow Subject: [PATCH v3 00/20] global exec/memory/dma APIs cleanup Date: Thu, 20 Feb 2020 14:05:28 +0100 Message-Id: <20200220130548.29974-1-philmd@redhat.com> X-Mailer: git-send-email 2.21.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org X-TUID: iOds6O2o0PWX This series is inspired from Peter Maydel cleanup patch: https://www.mail-archive.com/qemu-devel@nongnu.org/msg680625.html - Convert 'is_write' argument to boolean - Use void pointer for blob buffer - Remove unnecessary casts (Stefan Weil) - Replace [API]_rw() by [API]_read/write() when is_write is constant Supersedes: <20200218112457.22712-1-peter.maydell@linaro.org> Peter Maydell (1): Avoid address_space_rw() with a constant is_write argument Philippe Mathieu-Daudé (19): scripts/git.orderfile: Display Cocci scripts before code modifications hw: Remove unnecessary cast when calling dma_memory_read() exec: Let qemu_ram_*() functions take a const pointer argument exec: Rename ram_ptr variable exec: Let flatview API take void pointer arguments exec: Let the address_space API use void pointer arguments hw/net: Avoid casting non-const pointer, use address_space_write() Remove unnecessary cast when using the address_space API exec: Let the cpu_[physical]_memory API use void pointer arguments Remove unnecessary cast when using the cpu_[physical]_memory API hw/ide/internal: Remove unused DMARestartFunc typedef hw/ide: Let the DMAIntFunc prototype use a boolean 'is_write' argument hw/virtio: Let virtqueue_map_iovec() use a boolean 'is_write' argument hw/virtio: Let vhost_memory_map() use a boolean 'is_write' argument exec: Let address_space_unmap() use a boolean 'is_write' argument Let address_space_rw() calls pass a boolean 'is_write' argument exec: Let cpu_[physical]_memory API use a boolean 'is_write' argument Let cpu_[physical]_memory() calls pass a boolean 'is_write' argument Avoid cpu_physical_memory_rw() with a constant is_write argument scripts/coccinelle/exec_rw_const.cocci | 103 +++++++++++++++++++++++++ include/exec/cpu-all.h | 2 +- include/exec/cpu-common.h | 18 ++--- include/exec/memory.h | 16 ++-- include/hw/ide/internal.h | 3 +- include/sysemu/xen-mapcache.h | 4 +- target/i386/hvf/vmx.h | 7 +- accel/kvm/kvm-all.c | 6 +- dma-helpers.c | 4 +- exec.c | 75 +++++++++--------- hw/arm/boot.c | 6 +- hw/arm/smmu-common.c | 3 +- hw/arm/smmuv3.c | 10 +-- hw/display/exynos4210_fimd.c | 3 +- hw/display/milkymist-tmu2.c | 8 +- hw/display/omap_dss.c | 2 +- hw/display/omap_lcdc.c | 10 +-- hw/display/ramfb.c | 2 +- hw/dma/etraxfs_dma.c | 25 +++--- hw/dma/rc4030.c | 10 +-- hw/dma/xlnx-zdma.c | 11 +-- hw/i386/xen/xen-mapcache.c | 2 +- hw/ide/ahci.c | 2 +- hw/ide/core.c | 2 +- hw/ide/macio.c | 2 +- hw/ide/pci.c | 2 +- hw/misc/pc-testdev.c | 2 +- hw/net/cadence_gem.c | 21 +++-- hw/net/dp8393x.c | 70 +++++++++-------- hw/net/i82596.c | 25 +++--- hw/net/lasi_i82596.c | 5 +- hw/nvram/spapr_nvram.c | 4 +- hw/ppc/pnv_lpc.c | 8 +- hw/ppc/ppc440_uc.c | 6 +- hw/ppc/spapr_hcall.c | 4 +- hw/s390x/css.c | 12 +-- hw/s390x/ipl.c | 2 +- hw/s390x/s390-pci-bus.c | 2 +- hw/s390x/virtio-ccw.c | 2 +- hw/scsi/vmw_pvscsi.c | 8 +- hw/sd/sdhci.c | 15 ++-- hw/virtio/vhost.c | 8 +- hw/virtio/virtio.c | 7 +- hw/xen/xen_pt_graphics.c | 2 +- qtest.c | 52 ++++++------- target/i386/hax-all.c | 6 +- target/i386/hvf/x86_mmu.c | 12 +-- target/i386/whpx-all.c | 2 +- target/s390x/excp_helper.c | 2 +- target/s390x/helper.c | 6 +- target/s390x/mmu_helper.c | 2 +- scripts/git.orderfile | 3 + 52 files changed, 360 insertions(+), 266 deletions(-) create mode 100644 scripts/coccinelle/exec_rw_const.cocci -- 2.21.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FB8FC11D04 for ; Thu, 20 Feb 2020 13:06:25 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 74E7F208C4 for ; Thu, 20 Feb 2020 13:06:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="A04WDmT7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 74E7F208C4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1j4lWm-000107-2Z; Thu, 20 Feb 2020 13:06:04 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1j4lWk-000102-Sx for xen-devel@lists.xenproject.org; Thu, 20 Feb 2020 13:06:02 +0000 X-Inumbo-ID: be4a00f8-53e1-11ea-8526-12813bfff9fa Received: from us-smtp-delivery-1.mimecast.com (unknown [205.139.110.61]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTP id be4a00f8-53e1-11ea-8526-12813bfff9fa; Thu, 20 Feb 2020 13:06:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582203961; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=gs0Sx5MSe2ZHpufIPviwETvw5yj3kxXeAW695lKR/TM=; b=A04WDmT7du6YAyESCnsSFaoBhgshBttIxV2o/ek3kFqyvmXf+qEKtR1Q3hX9baegTuUXCn dt4tkthCmcD6+X5rv5+5mAS0ljOOGhn10GW1R6Y4pOx5DsPMyAEpbAcTde439f4FNMzqtD dq6ShylSvvrF6GdZ9wSGN4vilJ5liyQ= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-106-ccuY-e0gN7eZjnQ56ReGtQ-1; Thu, 20 Feb 2020 08:05:55 -0500 X-MC-Unique: ccuY-e0gN7eZjnQ56ReGtQ-1 Received: by mail-wr1-f72.google.com with SMTP id 90so1711273wrq.6 for ; Thu, 20 Feb 2020 05:05:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=gu1OfO+Xr177r6zD7C+F/TxHFq6mosreIYv9UCpXME0=; b=QfSyygPn0Po8IiPrMaq8tr3ygbQxWO13/A1PH/648ARcROaudVPoAjv6m+tG14Adqq fJaO+uzv6U/TQqQ3cVBUdxndSBJa7uDlSfFU4yvUquBppqI11dKkHXhxhNnbNBVJOp0+ gCqn8gUjpeeJP7V74P2B73CPnPD5eUTLkIA1Kt4JQW0QoCPr6ZENG59913oN+caNot+b vrCAzScHPXjSlfmXao9hijrnA85wPg45d1UE/syGgOsR+QfIsgbzlIGfXffJe4e8vIvA C2afKeYCNDKLsTLdrDfd21zbFE2XFJxkRHuCWAVPCfOq9arlujHT+Op9SA7xeK4hX2hp qikw== X-Gm-Message-State: APjAAAUpShrOBkRu+D9T00xz78GAtMZxSam+TRZZDHq0As+CIZ/YVtqo eaOqQM0Q5WnFOnqmgdHM/73UnL9nuNUCjaSEV5wtHGV4wcE52BBv7JbV6vxqDj0QtEUS9FOXc/L CUpR6DYSkJoRz3ItCoIzlJd9RNPs= X-Received: by 2002:a1c:f713:: with SMTP id v19mr4357663wmh.113.1582203953758; Thu, 20 Feb 2020 05:05:53 -0800 (PST) X-Google-Smtp-Source: APXvYqzh9hNepHCOwe2XDVm3wY3ajt8F8GOM+lVXRr3SymvEGFarpB4eXHypTAiBAMMl7y3VSmAESQ== X-Received: by 2002:a1c:f713:: with SMTP id v19mr4357638wmh.113.1582203953503; Thu, 20 Feb 2020 05:05:53 -0800 (PST) Received: from localhost.localdomain (78.red-88-21-202.staticip.rima-tde.net. [88.21.202.78]) by smtp.gmail.com with ESMTPSA id b67sm4594690wmc.38.2020.02.20.05.05.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Feb 2020 05:05:52 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Peter Maydell , qemu-devel@nongnu.org Date: Thu, 20 Feb 2020 14:05:28 +0100 Message-Id: <20200220130548.29974-1-philmd@redhat.com> X-Mailer: git-send-email 2.21.1 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Subject: [Xen-devel] [PATCH v3 00/20] global exec/memory/dma APIs cleanup X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Dmitry Fleytman , kvm@vger.kernel.org, "Michael S. Tsirkin" , Jason Wang , Gerd Hoffmann , "Edgar E. Iglesias" , Stefano Stabellini , Matthew Rosato , qemu-block@nongnu.org, David Hildenbrand , Halil Pasic , Christian Borntraeger , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Marcel Apfelbaum , Anthony Perard , xen-devel@lists.xenproject.org, Aleksandar Rikalo , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Laurent Vivier , Thomas Huth , Eduardo Habkost , Stefan Weil , Alistair Francis , Richard Henderson , Paul Durrant , Eric Auger , qemu-s390x@nongnu.org, qemu-arm@nongnu.org, =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , John Snow , David Gibson , Igor Mitsyanko , Cornelia Huck , Michael Walle , qemu-ppc@nongnu.org, Paolo Bonzini Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" VGhpcyBzZXJpZXMgaXMgaW5zcGlyZWQgZnJvbSBQZXRlciBNYXlkZWwgY2xlYW51cCBwYXRjaDoK aHR0cHM6Ly93d3cubWFpbC1hcmNoaXZlLmNvbS9xZW11LWRldmVsQG5vbmdudS5vcmcvbXNnNjgw NjI1Lmh0bWwKCi0gQ29udmVydCAnaXNfd3JpdGUnIGFyZ3VtZW50IHRvIGJvb2xlYW4KLSBVc2Ug dm9pZCBwb2ludGVyIGZvciBibG9iIGJ1ZmZlcgotIFJlbW92ZSB1bm5lY2Vzc2FyeSBjYXN0cyAo U3RlZmFuIFdlaWwpCi0gUmVwbGFjZSBbQVBJXV9ydygpIGJ5IFtBUEldX3JlYWQvd3JpdGUoKSB3 aGVuIGlzX3dyaXRlIGlzIGNvbnN0YW50CgpTdXBlcnNlZGVzOiA8MjAyMDAyMTgxMTI0NTcuMjI3 MTItMS1wZXRlci5tYXlkZWxsQGxpbmFyby5vcmc+CgpQZXRlciBNYXlkZWxsICgxKToKICBBdm9p ZCBhZGRyZXNzX3NwYWNlX3J3KCkgd2l0aCBhIGNvbnN0YW50IGlzX3dyaXRlIGFyZ3VtZW50CgpQ aGlsaXBwZSBNYXRoaWV1LURhdWTDqSAoMTkpOgogIHNjcmlwdHMvZ2l0Lm9yZGVyZmlsZTogRGlz cGxheSBDb2NjaSBzY3JpcHRzIGJlZm9yZSBjb2RlIG1vZGlmaWNhdGlvbnMKICBodzogUmVtb3Zl IHVubmVjZXNzYXJ5IGNhc3Qgd2hlbiBjYWxsaW5nIGRtYV9tZW1vcnlfcmVhZCgpCiAgZXhlYzog TGV0IHFlbXVfcmFtXyooKSBmdW5jdGlvbnMgdGFrZSBhIGNvbnN0IHBvaW50ZXIgYXJndW1lbnQK ICBleGVjOiBSZW5hbWUgcmFtX3B0ciB2YXJpYWJsZQogIGV4ZWM6IExldCBmbGF0dmlldyBBUEkg dGFrZSB2b2lkIHBvaW50ZXIgYXJndW1lbnRzCiAgZXhlYzogTGV0IHRoZSBhZGRyZXNzX3NwYWNl IEFQSSB1c2Ugdm9pZCBwb2ludGVyIGFyZ3VtZW50cwogIGh3L25ldDogQXZvaWQgY2FzdGluZyBu b24tY29uc3QgcG9pbnRlciwgdXNlIGFkZHJlc3Nfc3BhY2Vfd3JpdGUoKQogIFJlbW92ZSB1bm5l Y2Vzc2FyeSBjYXN0IHdoZW4gdXNpbmcgdGhlIGFkZHJlc3Nfc3BhY2UgQVBJCiAgZXhlYzogTGV0 IHRoZSBjcHVfW3BoeXNpY2FsXV9tZW1vcnkgQVBJIHVzZSB2b2lkIHBvaW50ZXIgYXJndW1lbnRz CiAgUmVtb3ZlIHVubmVjZXNzYXJ5IGNhc3Qgd2hlbiB1c2luZyB0aGUgY3B1X1twaHlzaWNhbF1f bWVtb3J5IEFQSQogIGh3L2lkZS9pbnRlcm5hbDogUmVtb3ZlIHVudXNlZCBETUFSZXN0YXJ0RnVu YyB0eXBlZGVmCiAgaHcvaWRlOiBMZXQgdGhlIERNQUludEZ1bmMgcHJvdG90eXBlIHVzZSBhIGJv b2xlYW4gJ2lzX3dyaXRlJyBhcmd1bWVudAogIGh3L3ZpcnRpbzogTGV0IHZpcnRxdWV1ZV9tYXBf aW92ZWMoKSB1c2UgYSBib29sZWFuICdpc193cml0ZScgYXJndW1lbnQKICBody92aXJ0aW86IExl dCB2aG9zdF9tZW1vcnlfbWFwKCkgdXNlIGEgYm9vbGVhbiAnaXNfd3JpdGUnIGFyZ3VtZW50CiAg ZXhlYzogTGV0IGFkZHJlc3Nfc3BhY2VfdW5tYXAoKSB1c2UgYSBib29sZWFuICdpc193cml0ZScg YXJndW1lbnQKICBMZXQgYWRkcmVzc19zcGFjZV9ydygpIGNhbGxzIHBhc3MgYSBib29sZWFuICdp c193cml0ZScgYXJndW1lbnQKICBleGVjOiBMZXQgY3B1X1twaHlzaWNhbF1fbWVtb3J5IEFQSSB1 c2UgYSBib29sZWFuICdpc193cml0ZScgYXJndW1lbnQKICBMZXQgY3B1X1twaHlzaWNhbF1fbWVt b3J5KCkgY2FsbHMgcGFzcyBhIGJvb2xlYW4gJ2lzX3dyaXRlJyBhcmd1bWVudAogIEF2b2lkIGNw dV9waHlzaWNhbF9tZW1vcnlfcncoKSB3aXRoIGEgY29uc3RhbnQgaXNfd3JpdGUgYXJndW1lbnQK CiBzY3JpcHRzL2NvY2NpbmVsbGUvZXhlY19yd19jb25zdC5jb2NjaSB8IDEwMyArKysrKysrKysr KysrKysrKysrKysrKysrCiBpbmNsdWRlL2V4ZWMvY3B1LWFsbC5oICAgICAgICAgICAgICAgICB8 ICAgMiArLQogaW5jbHVkZS9leGVjL2NwdS1jb21tb24uaCAgICAgICAgICAgICAgfCAgMTggKyst LS0KIGluY2x1ZGUvZXhlYy9tZW1vcnkuaCAgICAgICAgICAgICAgICAgIHwgIDE2ICsrLS0KIGlu Y2x1ZGUvaHcvaWRlL2ludGVybmFsLmggICAgICAgICAgICAgIHwgICAzICstCiBpbmNsdWRlL3N5 c2VtdS94ZW4tbWFwY2FjaGUuaCAgICAgICAgICB8ICAgNCArLQogdGFyZ2V0L2kzODYvaHZmL3Zt eC5oICAgICAgICAgICAgICAgICAgfCAgIDcgKy0KIGFjY2VsL2t2bS9rdm0tYWxsLmMgICAgICAg ICAgICAgICAgICAgIHwgICA2ICstCiBkbWEtaGVscGVycy5jICAgICAgICAgICAgICAgICAgICAg ICAgICB8ICAgNCArLQogZXhlYy5jICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAg NzUgKysrKysrKysrLS0tLS0tLS0tCiBody9hcm0vYm9vdC5jICAgICAgICAgICAgICAgICAgICAg ICAgICB8ICAgNiArLQogaHcvYXJtL3NtbXUtY29tbW9uLmMgICAgICAgICAgICAgICAgICAgfCAg IDMgKy0KIGh3L2FybS9zbW11djMuYyAgICAgICAgICAgICAgICAgICAgICAgIHwgIDEwICstLQog aHcvZGlzcGxheS9leHlub3M0MjEwX2ZpbWQuYyAgICAgICAgICAgfCAgIDMgKy0KIGh3L2Rpc3Bs YXkvbWlsa3ltaXN0LXRtdTIuYyAgICAgICAgICAgIHwgICA4ICstCiBody9kaXNwbGF5L29tYXBf ZHNzLmMgICAgICAgICAgICAgICAgICB8ICAgMiArLQogaHcvZGlzcGxheS9vbWFwX2xjZGMuYyAg ICAgICAgICAgICAgICAgfCAgMTAgKy0tCiBody9kaXNwbGF5L3JhbWZiLmMgICAgICAgICAgICAg ICAgICAgICB8ICAgMiArLQogaHcvZG1hL2V0cmF4ZnNfZG1hLmMgICAgICAgICAgICAgICAgICAg fCAgMjUgKysrLS0tCiBody9kbWEvcmM0MDMwLmMgICAgICAgICAgICAgICAgICAgICAgICB8ICAx MCArLS0KIGh3L2RtYS94bG54LXpkbWEuYyAgICAgICAgICAgICAgICAgICAgIHwgIDExICstLQog aHcvaTM4Ni94ZW4veGVuLW1hcGNhY2hlLmMgICAgICAgICAgICAgfCAgIDIgKy0KIGh3L2lkZS9h aGNpLmMgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAyICstCiBody9pZGUvY29yZS5jICAg ICAgICAgICAgICAgICAgICAgICAgICB8ICAgMiArLQogaHcvaWRlL21hY2lvLmMgICAgICAgICAg ICAgICAgICAgICAgICAgfCAgIDIgKy0KIGh3L2lkZS9wY2kuYyAgICAgICAgICAgICAgICAgICAg ICAgICAgIHwgICAyICstCiBody9taXNjL3BjLXRlc3RkZXYuYyAgICAgICAgICAgICAgICAgICB8 ICAgMiArLQogaHcvbmV0L2NhZGVuY2VfZ2VtLmMgICAgICAgICAgICAgICAgICAgfCAgMjEgKysr LS0KIGh3L25ldC9kcDgzOTN4LmMgICAgICAgICAgICAgICAgICAgICAgIHwgIDcwICsrKysrKysr Ky0tLS0tLS0tCiBody9uZXQvaTgyNTk2LmMgICAgICAgICAgICAgICAgICAgICAgICB8ICAyNSAr KystLS0KIGh3L25ldC9sYXNpX2k4MjU5Ni5jICAgICAgICAgICAgICAgICAgIHwgICA1ICstCiBo dy9udnJhbS9zcGFwcl9udnJhbS5jICAgICAgICAgICAgICAgICB8ICAgNCArLQogaHcvcHBjL3Bu dl9scGMuYyAgICAgICAgICAgICAgICAgICAgICAgfCAgIDggKy0KIGh3L3BwYy9wcGM0NDBfdWMu YyAgICAgICAgICAgICAgICAgICAgIHwgICA2ICstCiBody9wcGMvc3BhcHJfaGNhbGwuYyAgICAg ICAgICAgICAgICAgICB8ICAgNCArLQogaHcvczM5MHgvY3NzLmMgICAgICAgICAgICAgICAgICAg ICAgICAgfCAgMTIgKy0tCiBody9zMzkweC9pcGwuYyAgICAgICAgICAgICAgICAgICAgICAgICB8 ICAgMiArLQogaHcvczM5MHgvczM5MC1wY2ktYnVzLmMgICAgICAgICAgICAgICAgfCAgIDIgKy0K IGh3L3MzOTB4L3ZpcnRpby1jY3cuYyAgICAgICAgICAgICAgICAgIHwgICAyICstCiBody9zY3Np L3Ztd19wdnNjc2kuYyAgICAgICAgICAgICAgICAgICB8ICAgOCArLQogaHcvc2Qvc2RoY2kuYyAg ICAgICAgICAgICAgICAgICAgICAgICAgfCAgMTUgKystLQogaHcvdmlydGlvL3Zob3N0LmMgICAg ICAgICAgICAgICAgICAgICAgfCAgIDggKy0KIGh3L3ZpcnRpby92aXJ0aW8uYyAgICAgICAgICAg ICAgICAgICAgIHwgICA3ICstCiBody94ZW4veGVuX3B0X2dyYXBoaWNzLmMgICAgICAgICAgICAg ICB8ICAgMiArLQogcXRlc3QuYyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgNTIg KysrKysrLS0tLS0tLQogdGFyZ2V0L2kzODYvaGF4LWFsbC5jICAgICAgICAgICAgICAgICAgfCAg IDYgKy0KIHRhcmdldC9pMzg2L2h2Zi94ODZfbW11LmMgICAgICAgICAgICAgIHwgIDEyICstLQog dGFyZ2V0L2kzODYvd2hweC1hbGwuYyAgICAgICAgICAgICAgICAgfCAgIDIgKy0KIHRhcmdldC9z MzkweC9leGNwX2hlbHBlci5jICAgICAgICAgICAgIHwgICAyICstCiB0YXJnZXQvczM5MHgvaGVs cGVyLmMgICAgICAgICAgICAgICAgICB8ICAgNiArLQogdGFyZ2V0L3MzOTB4L21tdV9oZWxwZXIu YyAgICAgICAgICAgICAgfCAgIDIgKy0KIHNjcmlwdHMvZ2l0Lm9yZGVyZmlsZSAgICAgICAgICAg ICAgICAgIHwgICAzICsKIDUyIGZpbGVzIGNoYW5nZWQsIDM2MCBpbnNlcnRpb25zKCspLCAyNjYg ZGVsZXRpb25zKC0pCiBjcmVhdGUgbW9kZSAxMDA2NDQgc2NyaXB0cy9jb2NjaW5lbGxlL2V4ZWNf cndfY29uc3QuY29jY2kKCi0tIAoyLjIxLjEKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0 cy54ZW5wcm9qZWN0Lm9yZwpodHRwczovL2xpc3RzLnhlbnByb2plY3Qub3JnL21haWxtYW4vbGlz dGluZm8veGVuLWRldmVs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE647C11D04 for ; Thu, 20 Feb 2020 13:08:26 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9A641208C4 for ; Thu, 20 Feb 2020 13:08:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="A04WDmT7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9A641208C4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:41542 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j4lZ3-0007y3-Rb for qemu-devel@archiver.kernel.org; Thu, 20 Feb 2020 08:08:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:55501) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j4lWm-00047N-8i for qemu-devel@nongnu.org; Thu, 20 Feb 2020 08:06:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j4lWk-0004i1-KT for qemu-devel@nongnu.org; Thu, 20 Feb 2020 08:06:04 -0500 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:56892 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j4lWk-0004hU-Al for qemu-devel@nongnu.org; Thu, 20 Feb 2020 08:06:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582203961; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=gs0Sx5MSe2ZHpufIPviwETvw5yj3kxXeAW695lKR/TM=; b=A04WDmT7du6YAyESCnsSFaoBhgshBttIxV2o/ek3kFqyvmXf+qEKtR1Q3hX9baegTuUXCn dt4tkthCmcD6+X5rv5+5mAS0ljOOGhn10GW1R6Y4pOx5DsPMyAEpbAcTde439f4FNMzqtD dq6ShylSvvrF6GdZ9wSGN4vilJ5liyQ= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-471-lyz8ybnkPcyOrlJyzs-VuA-1; Thu, 20 Feb 2020 08:05:55 -0500 Received: by mail-wr1-f70.google.com with SMTP id s13so1703373wru.7 for ; Thu, 20 Feb 2020 05:05:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=gu1OfO+Xr177r6zD7C+F/TxHFq6mosreIYv9UCpXME0=; b=M9SqMEUjkS/9N4K0GZ4f65VMn1tB/IjbA+l+Q6pL4P965bQb5yG4L8ck4MxJQKApR7 IxNxEkifvv8ukHyqzznGR/DB0PDp0cnjbLx17jDMJqEOyenGbbc9AdeccH646h5mwi9P HQZUSE0KMm0U90j3vV0lMsB7+3YhZd4aOgNplSsb11T71YQu/npO2ihY+V9OiyvgfXnW lorvdDysD9NhAwfb6v4zihAA3vBdEu9pUEGDCDoBNSwho0YBbNd+tB11Tw7ueExGUAgw 1ffdiOeOfz+goBK6XFOqdsYh3LpII/ZbFpX7so+CKs/bUsy9SkyVVmM8QjKGNd54fNrw lYcA== X-Gm-Message-State: APjAAAX2P0D6cTUrmPDGgktf+vZvapYX21wXgxkS+inol0OWpyiAkCVg ml+AGt96iJnE6rZdl1q0ezNZW8pUlRI98MdSfXo8qhr7NWev7wWOx+8XA2Ulbk7s3Lmbvy8QwnJ gkjUMXXkQMPgNHmM= X-Received: by 2002:a1c:f713:: with SMTP id v19mr4357699wmh.113.1582203953845; Thu, 20 Feb 2020 05:05:53 -0800 (PST) X-Google-Smtp-Source: APXvYqzh9hNepHCOwe2XDVm3wY3ajt8F8GOM+lVXRr3SymvEGFarpB4eXHypTAiBAMMl7y3VSmAESQ== X-Received: by 2002:a1c:f713:: with SMTP id v19mr4357638wmh.113.1582203953503; Thu, 20 Feb 2020 05:05:53 -0800 (PST) Received: from localhost.localdomain (78.red-88-21-202.staticip.rima-tde.net. [88.21.202.78]) by smtp.gmail.com with ESMTPSA id b67sm4594690wmc.38.2020.02.20.05.05.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Feb 2020 05:05:52 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Peter Maydell , qemu-devel@nongnu.org Subject: [PATCH v3 00/20] global exec/memory/dma APIs cleanup Date: Thu, 20 Feb 2020 14:05:28 +0100 Message-Id: <20200220130548.29974-1-philmd@redhat.com> X-Mailer: git-send-email 2.21.1 MIME-Version: 1.0 X-MC-Unique: lyz8ybnkPcyOrlJyzs-VuA-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8; text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.81 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Dmitry Fleytman , kvm@vger.kernel.org, "Michael S. Tsirkin" , Jason Wang , Gerd Hoffmann , "Edgar E. Iglesias" , Stefano Stabellini , Matthew Rosato , qemu-block@nongnu.org, David Hildenbrand , Halil Pasic , Christian Borntraeger , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Anthony Perard , xen-devel@lists.xenproject.org, Aleksandar Rikalo , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Laurent Vivier , Thomas Huth , Eduardo Habkost , Stefan Weil , Alistair Francis , Richard Henderson , Paul Durrant , Eric Auger , qemu-s390x@nongnu.org, qemu-arm@nongnu.org, =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , John Snow , David Gibson , Igor Mitsyanko , Cornelia Huck , Michael Walle , qemu-ppc@nongnu.org, Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This series is inspired from Peter Maydel cleanup patch: https://www.mail-archive.com/qemu-devel@nongnu.org/msg680625.html - Convert 'is_write' argument to boolean - Use void pointer for blob buffer - Remove unnecessary casts (Stefan Weil) - Replace [API]_rw() by [API]_read/write() when is_write is constant Supersedes: <20200218112457.22712-1-peter.maydell@linaro.org> Peter Maydell (1): Avoid address_space_rw() with a constant is_write argument Philippe Mathieu-Daud=C3=A9 (19): scripts/git.orderfile: Display Cocci scripts before code modifications hw: Remove unnecessary cast when calling dma_memory_read() exec: Let qemu_ram_*() functions take a const pointer argument exec: Rename ram_ptr variable exec: Let flatview API take void pointer arguments exec: Let the address_space API use void pointer arguments hw/net: Avoid casting non-const pointer, use address_space_write() Remove unnecessary cast when using the address_space API exec: Let the cpu_[physical]_memory API use void pointer arguments Remove unnecessary cast when using the cpu_[physical]_memory API hw/ide/internal: Remove unused DMARestartFunc typedef hw/ide: Let the DMAIntFunc prototype use a boolean 'is_write' argument hw/virtio: Let virtqueue_map_iovec() use a boolean 'is_write' argument hw/virtio: Let vhost_memory_map() use a boolean 'is_write' argument exec: Let address_space_unmap() use a boolean 'is_write' argument Let address_space_rw() calls pass a boolean 'is_write' argument exec: Let cpu_[physical]_memory API use a boolean 'is_write' argument Let cpu_[physical]_memory() calls pass a boolean 'is_write' argument Avoid cpu_physical_memory_rw() with a constant is_write argument scripts/coccinelle/exec_rw_const.cocci | 103 +++++++++++++++++++++++++ include/exec/cpu-all.h | 2 +- include/exec/cpu-common.h | 18 ++--- include/exec/memory.h | 16 ++-- include/hw/ide/internal.h | 3 +- include/sysemu/xen-mapcache.h | 4 +- target/i386/hvf/vmx.h | 7 +- accel/kvm/kvm-all.c | 6 +- dma-helpers.c | 4 +- exec.c | 75 +++++++++--------- hw/arm/boot.c | 6 +- hw/arm/smmu-common.c | 3 +- hw/arm/smmuv3.c | 10 +-- hw/display/exynos4210_fimd.c | 3 +- hw/display/milkymist-tmu2.c | 8 +- hw/display/omap_dss.c | 2 +- hw/display/omap_lcdc.c | 10 +-- hw/display/ramfb.c | 2 +- hw/dma/etraxfs_dma.c | 25 +++--- hw/dma/rc4030.c | 10 +-- hw/dma/xlnx-zdma.c | 11 +-- hw/i386/xen/xen-mapcache.c | 2 +- hw/ide/ahci.c | 2 +- hw/ide/core.c | 2 +- hw/ide/macio.c | 2 +- hw/ide/pci.c | 2 +- hw/misc/pc-testdev.c | 2 +- hw/net/cadence_gem.c | 21 +++-- hw/net/dp8393x.c | 70 +++++++++-------- hw/net/i82596.c | 25 +++--- hw/net/lasi_i82596.c | 5 +- hw/nvram/spapr_nvram.c | 4 +- hw/ppc/pnv_lpc.c | 8 +- hw/ppc/ppc440_uc.c | 6 +- hw/ppc/spapr_hcall.c | 4 +- hw/s390x/css.c | 12 +-- hw/s390x/ipl.c | 2 +- hw/s390x/s390-pci-bus.c | 2 +- hw/s390x/virtio-ccw.c | 2 +- hw/scsi/vmw_pvscsi.c | 8 +- hw/sd/sdhci.c | 15 ++-- hw/virtio/vhost.c | 8 +- hw/virtio/virtio.c | 7 +- hw/xen/xen_pt_graphics.c | 2 +- qtest.c | 52 ++++++------- target/i386/hax-all.c | 6 +- target/i386/hvf/x86_mmu.c | 12 +-- target/i386/whpx-all.c | 2 +- target/s390x/excp_helper.c | 2 +- target/s390x/helper.c | 6 +- target/s390x/mmu_helper.c | 2 +- scripts/git.orderfile | 3 + 52 files changed, 360 insertions(+), 266 deletions(-) create mode 100644 scripts/coccinelle/exec_rw_const.cocci --=20 2.21.1