From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a19:cb43:0:0:0:0:0 with SMTP id b64csp543965lfg; Thu, 20 Feb 2020 05:06:56 -0800 (PST) X-Google-Smtp-Source: APXvYqxs7T9y5HgYB3kAb2GTzEkoVbRaeSw6xeUnLZ7kdL4Gwgq16grzPHW+Sv6ofVi2MBn5gylk X-Received: by 2002:aca:4f8e:: with SMTP id d136mr1830170oib.61.1582204016427; Thu, 20 Feb 2020 05:06:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582204016; cv=none; d=google.com; s=arc-20160816; b=mj6GO+YI0M46UGMq8XK2hsQDHvSbGNjqtR2dTJqHD0YYs4gkDDF1Pt0kcqfpurhyuG FAYZC2esIUcSRmNXqvsdXTUsVNl5ps/iPGN93lT+V8kbgTL8eB8dGloWSsUP82FsOyJh 6OJRBx8rya2cGOWywHFHJDueIE/2cYX6nCXD9GIMmO5btZgd2QIqPvk/w3QgJN++x4mm bdfsXz0climRjIGntqQtrpaVl3ikVWiwiKE2QoRB/MJL2u95G3Qislm6U+1U4YgxBG7e Vv+BIrNjT3Lw7YTCUFPRLVvl+n7lGrIgCIKASiEXjQNZWH8/jYcQ2lm6eRgmanx2w5gj f4hg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=U6IlttQWg5GixafQJKz3fjDa/v6plglwkRJYH67W75E=; b=SWovuPujzbAmsKY2ASh979Mgxse7xxH7aYKEc3m942VSmqqSaiFVcGS19wurXm0uHs 0YzAmjCVRoCz8TrRQKVI9K7qxldT4dGe9Bcgcc3JbumqTKBWQkt65dNFESsgsR96IeKM BJUidK9K65dzsHyPzGk8NktJNO0i+n5J5ItBNj+Xxy02GwwpwjSDZJm0tGpqvYUrmRoP cL7dnzjjplztZoLlejJN2NdRXIqji/MrTtEwBQErJM2Hu4HkZKfQDC3vV6haERuDav+P NaM/yp9Lyo32v3ee6pkAdeW8Jimd5brZ2mCbA9XnRIBz8ltK96JDDCbshyXzuPU2TzAF DwUA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=DTEZOrRB; spf=pass (google.com: best guess record for domain of kvm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=kvm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b2si1957201ots.284.2020.02.20.05.06.56; Thu, 20 Feb 2020 05:06:56 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of kvm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=DTEZOrRB; spf=pass (google.com: best guess record for domain of kvm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=kvm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728219AbgBTNGz (ORCPT + 5 others); Thu, 20 Feb 2020 08:06:55 -0500 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:36393 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728214AbgBTNGz (ORCPT ); Thu, 20 Feb 2020 08:06:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582204013; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=U6IlttQWg5GixafQJKz3fjDa/v6plglwkRJYH67W75E=; b=DTEZOrRBrMpSxM5rvwKDb7ENfDgZJyRYkUrciLoyMgW1TABiR6DbMEIL7Of2aICC1+b8TF MRdqcw7PO3gW4apjpT69pA70w64Re4VWH/NPjg/mN6W3jlCA6pa8HG8HSn8nCBc3utLzZX gdtUgox8zO7B2HL6He0PjBwAZfahNtA= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-196-WbnwfNiSPeOcvi4GOdiR_A-1; Thu, 20 Feb 2020 08:06:51 -0500 X-MC-Unique: WbnwfNiSPeOcvi4GOdiR_A-1 Received: by mail-wr1-f71.google.com with SMTP id 90so1712288wrq.6 for ; Thu, 20 Feb 2020 05:06:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=U6IlttQWg5GixafQJKz3fjDa/v6plglwkRJYH67W75E=; b=fR8zBBi/awUuF+JZuBvUizEeu2YYummwd3RQaU88qsBEtxWDZ2QR4X2Z48acGzNmPG 0ffutIYZLWUt60K6CjHrngw66iHJ/GDlPw4SZd2657/Eg3SaWwEumCzRh2OmV76nntso 6E8zhKb93C7OYLggossljDV0ZX0sh63TlMFaPqcpog67tCqJWAW+VbR9nqCX+VAOJe5s 9b8zsjTneSbB4DUDN2KiOJtdS+PyXY5EYKxoMgwu8k0AGQsBOZPc//jn6unoyY0U8Lxc 9jkzTL1gvcmZkQgVKiZboxvowf8XffIbVSg8goAdzy4p/73iymhVP+iCjELiwAkJN2BV iHcg== X-Gm-Message-State: APjAAAVSNXIzlpGZecL6wFImf0/kWrLKidLwaP+pQzqrVE/RBZ+KtQ7m y1tChaFxjs7Qqc1rcHWTrX/qfXwEQl7l5ha7AADr2cmMIt0TiJYlZsBNUyMAx5ajL3nKX+CSBsx lEIvn5RjHAr/L X-Received: by 2002:adf:cd92:: with SMTP id q18mr41684755wrj.261.1582204010378; Thu, 20 Feb 2020 05:06:50 -0800 (PST) X-Received: by 2002:adf:cd92:: with SMTP id q18mr41684732wrj.261.1582204010138; Thu, 20 Feb 2020 05:06:50 -0800 (PST) Received: from localhost.localdomain (78.red-88-21-202.staticip.rima-tde.net. [88.21.202.78]) by smtp.gmail.com with ESMTPSA id b67sm4594690wmc.38.2020.02.20.05.06.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Feb 2020 05:06:49 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Peter Maydell , qemu-devel@nongnu.org Cc: "Edgar E. Iglesias" , Anthony Perard , Fam Zheng , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , kvm@vger.kernel.org, Laurent Vivier , Thomas Huth , Stefan Weil , Eric Auger , Halil Pasic , Marcel Apfelbaum , qemu-s390x@nongnu.org, Aleksandar Rikalo , David Gibson , Michael Walle , qemu-ppc@nongnu.org, Gerd Hoffmann , Cornelia Huck , qemu-arm@nongnu.org, Alistair Francis , qemu-block@nongnu.org, =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Jason Wang , xen-devel@lists.xenproject.org, Christian Borntraeger , Dmitry Fleytman , Matthew Rosato , Eduardo Habkost , Richard Henderson , "Michael S. Tsirkin" , David Hildenbrand , Paolo Bonzini , Stefano Stabellini , Igor Mitsyanko , Paul Durrant , Richard Henderson , John Snow Subject: [PATCH v3 15/20] exec: Let address_space_unmap() use a boolean 'is_write' argument Date: Thu, 20 Feb 2020 14:05:43 +0100 Message-Id: <20200220130548.29974-16-philmd@redhat.com> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200220130548.29974-1-philmd@redhat.com> References: <20200220130548.29974-1-philmd@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org X-TUID: zmFsrIPf/tVt The 'is_write' argument is either 0 or 1. Convert it to a boolean type. Signed-off-by: Philippe Mathieu-Daudé --- include/exec/memory.h | 2 +- exec.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include/exec/memory.h b/include/exec/memory.h index afee185eae..1614d9a02c 100644 --- a/include/exec/memory.h +++ b/include/exec/memory.h @@ -2329,7 +2329,7 @@ void *address_space_map(AddressSpace *as, hwaddr addr, * @is_write: indicates the transfer direction */ void address_space_unmap(AddressSpace *as, void *buffer, hwaddr len, - int is_write, hwaddr access_len); + bool is_write, hwaddr access_len); /* Internal functions, part of the implementation of address_space_read. */ diff --git a/exec.c b/exec.c index 01437be691..16974d4f4b 100644 --- a/exec.c +++ b/exec.c @@ -3598,11 +3598,11 @@ void *address_space_map(AddressSpace *as, } /* Unmaps a memory region previously mapped by address_space_map(). - * Will also mark the memory as dirty if is_write == 1. access_len gives + * Will also mark the memory as dirty if is_write is true. access_len gives * the amount of memory that was actually read or written by the caller. */ void address_space_unmap(AddressSpace *as, void *buffer, hwaddr len, - int is_write, hwaddr access_len) + bool is_write, hwaddr access_len) { if (buffer != bounce.buffer) { MemoryRegion *mr; -- 2.21.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A549C11D04 for ; Thu, 20 Feb 2020 13:07:05 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6D412206ED for ; Thu, 20 Feb 2020 13:07:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="bXzFcuji" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6D412206ED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1j4lXb-0001fC-Hb; Thu, 20 Feb 2020 13:06:55 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1j4lXZ-0001dP-OD for xen-devel@lists.xenproject.org; Thu, 20 Feb 2020 13:06:53 +0000 X-Inumbo-ID: dd4431a4-53e1-11ea-bc8e-bc764e2007e4 Received: from us-smtp-delivery-1.mimecast.com (unknown [205.139.110.120]) by us1-rack-iad1.inumbo.com (Halon) with ESMTP id dd4431a4-53e1-11ea-bc8e-bc764e2007e4; Thu, 20 Feb 2020 13:06:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582204013; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mnDlGhkDMc438YGrbvBovs3YxQJGj712XxeOh8S513U=; b=bXzFcujiUy8WThLAzWiyrVojuXhqpd51Xvn+J2tRCvL8TH2DdyGhwQTqowbuj7edFVT/ZR /Bn/AkdrraGHTAklTb6bcWdmzsgNzFNf5l3ipQS+X1slezfWLZ3PwKNwCu3YQqjLETpVVL 3KsXvf0D2XG1BQk6yW+fB9PaaxwQXrQ= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-196-Rxc6w5fSMvut1bNFgp6jUA-1; Thu, 20 Feb 2020 08:06:51 -0500 Received: by mail-wm1-f71.google.com with SMTP id k21so580983wmi.2 for ; Thu, 20 Feb 2020 05:06:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=U6IlttQWg5GixafQJKz3fjDa/v6plglwkRJYH67W75E=; b=mK574cIiCtALZXrqxPehpZ5I8zbdiVaYgOn5StLDxF9cjEbr6g6ont6kzLFruggOl+ so/Oskpr3SRGHYWjp1hTx8hRN7FROscGo08osvRcTQRjAE3ejns0uu8QXW9R1mmVdhNs EajMQhuaJPPTdGK/9Jpae7LJzIuVDstOI/5npYU8z7V95iQeKjKr8OiJRUbbYtJnpwDr qUOz2i83iQJsWFJJ15JuyJvyQza2cxKo/rXiYbwUs52apUDHINs6YXComOtgVxKf6EtJ 9x6n/XF7tuR/PxVyvWTVoDulEo6fVJ0QoxsnM9+kfQBC2+Brfsos9BM3jmLdI0K6YUep rJ1w== X-Gm-Message-State: APjAAAX38YWYm2h0DKUJ/rHVeuTaNOJenieOo4Gyf39w5pWbZ9o4Bxfb JgcQou2Of0TU1svUmrYevWaNnekScO4MwZ7mdUf9rX2OnZ0OLMV+h0Tgb6wHKowag472Oyj9l3/ nBMr069EQnAINhKt9hBONulBOXI8= X-Received: by 2002:adf:cd92:: with SMTP id q18mr41684785wrj.261.1582204010381; Thu, 20 Feb 2020 05:06:50 -0800 (PST) X-Google-Smtp-Source: APXvYqyVav3x+evHlrydubRXhyXAQPy/0YGFnLq+pw2hyskD3NJLge6kmK8LKicTlkzB4cX/rXzZiw== X-Received: by 2002:adf:cd92:: with SMTP id q18mr41684732wrj.261.1582204010138; Thu, 20 Feb 2020 05:06:50 -0800 (PST) Received: from localhost.localdomain (78.red-88-21-202.staticip.rima-tde.net. [88.21.202.78]) by smtp.gmail.com with ESMTPSA id b67sm4594690wmc.38.2020.02.20.05.06.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Feb 2020 05:06:49 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Peter Maydell , qemu-devel@nongnu.org Date: Thu, 20 Feb 2020 14:05:43 +0100 Message-Id: <20200220130548.29974-16-philmd@redhat.com> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200220130548.29974-1-philmd@redhat.com> References: <20200220130548.29974-1-philmd@redhat.com> MIME-Version: 1.0 X-MC-Unique: Rxc6w5fSMvut1bNFgp6jUA-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Subject: [Xen-devel] [PATCH v3 15/20] exec: Let address_space_unmap() use a boolean 'is_write' argument X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Dmitry Fleytman , kvm@vger.kernel.org, "Michael S. Tsirkin" , Jason Wang , Gerd Hoffmann , "Edgar E. Iglesias" , Stefano Stabellini , Matthew Rosato , qemu-block@nongnu.org, David Hildenbrand , Halil Pasic , Christian Borntraeger , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Marcel Apfelbaum , Anthony Perard , xen-devel@lists.xenproject.org, Aleksandar Rikalo , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Laurent Vivier , Thomas Huth , Eduardo Habkost , Stefan Weil , Alistair Francis , Richard Henderson , Paul Durrant , Eric Auger , qemu-s390x@nongnu.org, qemu-arm@nongnu.org, =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , John Snow , David Gibson , Igor Mitsyanko , Cornelia Huck , Michael Walle , qemu-ppc@nongnu.org, Paolo Bonzini Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" VGhlICdpc193cml0ZScgYXJndW1lbnQgaXMgZWl0aGVyIDAgb3IgMS4KQ29udmVydCBpdCB0byBh IGJvb2xlYW4gdHlwZS4KClNpZ25lZC1vZmYtYnk6IFBoaWxpcHBlIE1hdGhpZXUtRGF1ZMOpIDxw aGlsbWRAcmVkaGF0LmNvbT4KLS0tCiBpbmNsdWRlL2V4ZWMvbWVtb3J5LmggfCAyICstCiBleGVj LmMgICAgICAgICAgICAgICAgfCA0ICsrLS0KIDIgZmlsZXMgY2hhbmdlZCwgMyBpbnNlcnRpb25z KCspLCAzIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2luY2x1ZGUvZXhlYy9tZW1vcnkuaCBi L2luY2x1ZGUvZXhlYy9tZW1vcnkuaAppbmRleCBhZmVlMTg1ZWFlLi4xNjE0ZDlhMDJjIDEwMDY0 NAotLS0gYS9pbmNsdWRlL2V4ZWMvbWVtb3J5LmgKKysrIGIvaW5jbHVkZS9leGVjL21lbW9yeS5o CkBAIC0yMzI5LDcgKzIzMjksNyBAQCB2b2lkICphZGRyZXNzX3NwYWNlX21hcChBZGRyZXNzU3Bh Y2UgKmFzLCBod2FkZHIgYWRkciwKICAqIEBpc193cml0ZTogaW5kaWNhdGVzIHRoZSB0cmFuc2Zl ciBkaXJlY3Rpb24KICAqLwogdm9pZCBhZGRyZXNzX3NwYWNlX3VubWFwKEFkZHJlc3NTcGFjZSAq YXMsIHZvaWQgKmJ1ZmZlciwgaHdhZGRyIGxlbiwKLSAgICAgICAgICAgICAgICAgICAgICAgICBp bnQgaXNfd3JpdGUsIGh3YWRkciBhY2Nlc3NfbGVuKTsKKyAgICAgICAgICAgICAgICAgICAgICAg ICBib29sIGlzX3dyaXRlLCBod2FkZHIgYWNjZXNzX2xlbik7CiAKIAogLyogSW50ZXJuYWwgZnVu Y3Rpb25zLCBwYXJ0IG9mIHRoZSBpbXBsZW1lbnRhdGlvbiBvZiBhZGRyZXNzX3NwYWNlX3JlYWQu ICAqLwpkaWZmIC0tZ2l0IGEvZXhlYy5jIGIvZXhlYy5jCmluZGV4IDAxNDM3YmU2OTEuLjE2OTc0 ZDRmNGIgMTAwNjQ0Ci0tLSBhL2V4ZWMuYworKysgYi9leGVjLmMKQEAgLTM1OTgsMTEgKzM1OTgs MTEgQEAgdm9pZCAqYWRkcmVzc19zcGFjZV9tYXAoQWRkcmVzc1NwYWNlICphcywKIH0KIAogLyog VW5tYXBzIGEgbWVtb3J5IHJlZ2lvbiBwcmV2aW91c2x5IG1hcHBlZCBieSBhZGRyZXNzX3NwYWNl X21hcCgpLgotICogV2lsbCBhbHNvIG1hcmsgdGhlIG1lbW9yeSBhcyBkaXJ0eSBpZiBpc193cml0 ZSA9PSAxLiAgYWNjZXNzX2xlbiBnaXZlcworICogV2lsbCBhbHNvIG1hcmsgdGhlIG1lbW9yeSBh cyBkaXJ0eSBpZiBpc193cml0ZSBpcyB0cnVlLiAgYWNjZXNzX2xlbiBnaXZlcwogICogdGhlIGFt b3VudCBvZiBtZW1vcnkgdGhhdCB3YXMgYWN0dWFsbHkgcmVhZCBvciB3cml0dGVuIGJ5IHRoZSBj YWxsZXIuCiAgKi8KIHZvaWQgYWRkcmVzc19zcGFjZV91bm1hcChBZGRyZXNzU3BhY2UgKmFzLCB2 b2lkICpidWZmZXIsIGh3YWRkciBsZW4sCi0gICAgICAgICAgICAgICAgICAgICAgICAgaW50IGlz X3dyaXRlLCBod2FkZHIgYWNjZXNzX2xlbikKKyAgICAgICAgICAgICAgICAgICAgICAgICBib29s IGlzX3dyaXRlLCBod2FkZHIgYWNjZXNzX2xlbikKIHsKICAgICBpZiAoYnVmZmVyICE9IGJvdW5j ZS5idWZmZXIpIHsKICAgICAgICAgTWVtb3J5UmVnaW9uICptcjsKLS0gCjIuMjEuMQoKCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWls aW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnCmh0dHBzOi8vbGlzdHMueGVu cHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby94ZW4tZGV2ZWw= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16B5EC11D04 for ; Thu, 20 Feb 2020 13:16:22 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D5C1720722 for ; Thu, 20 Feb 2020 13:16:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="bXzFcuji" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D5C1720722 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:41868 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j4lgi-0006ov-2J for qemu-devel@archiver.kernel.org; Thu, 20 Feb 2020 08:16:21 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:56388) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j4lXd-00067M-UO for qemu-devel@nongnu.org; Thu, 20 Feb 2020 08:06:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j4lXc-0005em-1f for qemu-devel@nongnu.org; Thu, 20 Feb 2020 08:06:57 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:32140 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j4lXa-0005bv-6x for qemu-devel@nongnu.org; Thu, 20 Feb 2020 08:06:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582204013; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mnDlGhkDMc438YGrbvBovs3YxQJGj712XxeOh8S513U=; b=bXzFcujiUy8WThLAzWiyrVojuXhqpd51Xvn+J2tRCvL8TH2DdyGhwQTqowbuj7edFVT/ZR /Bn/AkdrraGHTAklTb6bcWdmzsgNzFNf5l3ipQS+X1slezfWLZ3PwKNwCu3YQqjLETpVVL 3KsXvf0D2XG1BQk6yW+fB9PaaxwQXrQ= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-414-cMDgiJUsPiORV_ejrrfMPQ-1; Thu, 20 Feb 2020 08:06:51 -0500 Received: by mail-wr1-f69.google.com with SMTP id 50so1721328wrc.2 for ; Thu, 20 Feb 2020 05:06:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=U6IlttQWg5GixafQJKz3fjDa/v6plglwkRJYH67W75E=; b=TrlOYIYqb3piVS48NoxVhY1+nLdo37HAtkhy0GOLS/kO56o1UfyfCvehM8EGXUPAtc uEU1nA/6gFvOtsLSIQ0T3jRKufOU2Fa6E+r4Ok+51TKafo5E8gjEWDat8mjiiDnUaT/M EQAHv8sooaI7AgTsBur1kCNyO9H4yWkG+KBeQm9UVs/O41P11jTVG+ioFvoFb3niYwqa R9cPZwh6kq2EJqCPbA38OdNGBj24r/jO3rBJSp7SbUYHvZbC1YhgY+MH7U50mnONulq2 QFX0lIHmYo6zel4I4K3H+k4KHhXM1ItbAVqaAKhRBr5AKYaFx4sMCP8ppRn8+fkkMAZx 9rtQ== X-Gm-Message-State: APjAAAVoN2PsbKGXF8/Jg5mWB/knTbqkqO4TAHULQIfo2LulepMK8y/T ViH9sYdGHvzmUSeuqz8zuIDikP+bagcBq+b+xNVlRUMd6YHIO2my06YGKwo8TuGxj81Ta4Oqlm9 vAaRh7Wov+xVM4bY= X-Received: by 2002:adf:cd92:: with SMTP id q18mr41684788wrj.261.1582204010381; Thu, 20 Feb 2020 05:06:50 -0800 (PST) X-Google-Smtp-Source: APXvYqyVav3x+evHlrydubRXhyXAQPy/0YGFnLq+pw2hyskD3NJLge6kmK8LKicTlkzB4cX/rXzZiw== X-Received: by 2002:adf:cd92:: with SMTP id q18mr41684732wrj.261.1582204010138; Thu, 20 Feb 2020 05:06:50 -0800 (PST) Received: from localhost.localdomain (78.red-88-21-202.staticip.rima-tde.net. [88.21.202.78]) by smtp.gmail.com with ESMTPSA id b67sm4594690wmc.38.2020.02.20.05.06.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Feb 2020 05:06:49 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Peter Maydell , qemu-devel@nongnu.org Subject: [PATCH v3 15/20] exec: Let address_space_unmap() use a boolean 'is_write' argument Date: Thu, 20 Feb 2020 14:05:43 +0100 Message-Id: <20200220130548.29974-16-philmd@redhat.com> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200220130548.29974-1-philmd@redhat.com> References: <20200220130548.29974-1-philmd@redhat.com> MIME-Version: 1.0 X-MC-Unique: cMDgiJUsPiORV_ejrrfMPQ-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8; text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Dmitry Fleytman , kvm@vger.kernel.org, "Michael S. Tsirkin" , Jason Wang , Gerd Hoffmann , "Edgar E. Iglesias" , Stefano Stabellini , Matthew Rosato , qemu-block@nongnu.org, David Hildenbrand , Halil Pasic , Christian Borntraeger , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Anthony Perard , xen-devel@lists.xenproject.org, Aleksandar Rikalo , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Laurent Vivier , Thomas Huth , Eduardo Habkost , Stefan Weil , Alistair Francis , Richard Henderson , Paul Durrant , Eric Auger , qemu-s390x@nongnu.org, qemu-arm@nongnu.org, =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , John Snow , David Gibson , Igor Mitsyanko , Cornelia Huck , Michael Walle , qemu-ppc@nongnu.org, Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" The 'is_write' argument is either 0 or 1. Convert it to a boolean type. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- include/exec/memory.h | 2 +- exec.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include/exec/memory.h b/include/exec/memory.h index afee185eae..1614d9a02c 100644 --- a/include/exec/memory.h +++ b/include/exec/memory.h @@ -2329,7 +2329,7 @@ void *address_space_map(AddressSpace *as, hwaddr addr= , * @is_write: indicates the transfer direction */ void address_space_unmap(AddressSpace *as, void *buffer, hwaddr len, - int is_write, hwaddr access_len); + bool is_write, hwaddr access_len); =20 =20 /* Internal functions, part of the implementation of address_space_read. = */ diff --git a/exec.c b/exec.c index 01437be691..16974d4f4b 100644 --- a/exec.c +++ b/exec.c @@ -3598,11 +3598,11 @@ void *address_space_map(AddressSpace *as, } =20 /* Unmaps a memory region previously mapped by address_space_map(). - * Will also mark the memory as dirty if is_write =3D=3D 1. access_len gi= ves + * Will also mark the memory as dirty if is_write is true. access_len giv= es * the amount of memory that was actually read or written by the caller. */ void address_space_unmap(AddressSpace *as, void *buffer, hwaddr len, - int is_write, hwaddr access_len) + bool is_write, hwaddr access_len) { if (buffer !=3D bounce.buffer) { MemoryRegion *mr; --=20 2.21.1