From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a19:cb43:0:0:0:0:0 with SMTP id b64csp544131lfg; Thu, 20 Feb 2020 05:07:06 -0800 (PST) X-Google-Smtp-Source: APXvYqyKzC7UBIK9ZV7I0yHsA6kYOk8UB14w1qpeYvneNgv3DegjdNBruE8YkPGdvXHriDpoMW/Q X-Received: by 2002:a9d:6e8e:: with SMTP id a14mr22182736otr.109.1582204026557; Thu, 20 Feb 2020 05:07:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582204026; cv=none; d=google.com; s=arc-20160816; b=bBpcoNjs3sdeJlEd/FIZKYqJLuFbsWBh0nhWFuEsubegKT2F9T/IcAPi+scCZzPp/9 94mIjySuHeAjeJ7qlYJTVy0npPt7vmOIoPlWgYLadzZBpxudz8jCpJBfxHG+j4sQyqSa 0AK6ZGfQot172lwM+h4EW7fS6zub/XCJBy4d4wW+wM/3lYj0J6tSxyvPFvv12oGPD88G anlb83H6E65lTRBN6MwVaj68OwS11aEL8Bckq9q1tpzTqAbhU7kYqYwSMeMT05TFvZc8 jvMyywQuBIrzajoiShR8FdGBSe0ac38SDl9CxzNboglGCHCW2No0Zp+UjLdFyheOP358 Z+NA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=3GOpiWMITxx9TtgKrEdUBt5MYBhcyKxmOeh0GtNqL3Q=; b=L72k29wSU5BUL1ep9d3st4U1KlePOOEvXFKcPAwC+qi5/MiurHVlupfS7hDZNMAjbl MkrUX5ayzCRmFHpQZ32dfOj7SFLE9Y/XUzSXsigXdLSAphz/8BJeZhbg7si7TgVPZ9un ajQuMP9at9OF4nrxLZ14gucVM7XzDHw647XmExmwdBWWelH/pGM/yQzZ7mLowkKxjoi2 1oukXWuPGpACGW4AbHzUQSuM8UpV1VutXEPZZgoBTzJmEtrWlJRjtK72i/tftHjrQltT +3xe5gAm1OwVffptqQH/LTvHI0NvKKj2yEtzdMKRB9YHnJJ4T3hQVIDyULC190fW8UxR q8xg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=SHvFbKWJ; spf=pass (google.com: best guess record for domain of kvm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=kvm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b2si1957201ots.284.2020.02.20.05.07.06; Thu, 20 Feb 2020 05:07:06 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of kvm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=SHvFbKWJ; spf=pass (google.com: best guess record for domain of kvm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=kvm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728229AbgBTNHF (ORCPT + 5 others); Thu, 20 Feb 2020 08:07:05 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:27224 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728130AbgBTNHF (ORCPT ); Thu, 20 Feb 2020 08:07:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582204024; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3GOpiWMITxx9TtgKrEdUBt5MYBhcyKxmOeh0GtNqL3Q=; b=SHvFbKWJkc2EO4i/EDTJtWjzC5yIN52VQV4GOJ+kyD52H1Z3KDPXklx2vV9l7i02pptMk/ CWJHqS7KuXlbaO7dD/x5S2SlM/LCaG1Ll61RobTuIXNJNxo1gWHSw0giWoWr4ylBsymY3d YqLgZGutsMHpaDUr1DVrhEScH69p6yw= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-150-sCR8Z1z9NB2f9tAH9TLmeA-1; Thu, 20 Feb 2020 08:07:03 -0500 X-MC-Unique: sCR8Z1z9NB2f9tAH9TLmeA-1 Received: by mail-wm1-f71.google.com with SMTP id b205so807387wmh.2 for ; Thu, 20 Feb 2020 05:07:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=3GOpiWMITxx9TtgKrEdUBt5MYBhcyKxmOeh0GtNqL3Q=; b=pzIwXNM9Ptt46DTKVM5x/LO3k05/ZsL1wO1q2QoKcp8VcG+035FJlvs5m1gRT6R98J 5gdyEkuMA+EED+K+QHhlkiS7iVeqAVVBuIa6+SEf4hnJbExvpdiLWNWY97hHdtxFpbWh 6sb+DTnI4090LO0dZLB7ZolDMV9JYJIGLRJhe7vn2IwwBtteX3tnxcl1u8WZqrEHqZsl dQWn4iW1S+UKuadHD1qCRv+JoB34pmRtinSYRzyY7Dt/FR0ZADeiU4VQDMKDAEI2rXr+ fVmL7DzrdeD2niXun43E7je85bvv/0/Vm1TJyUipMggnw+O866g2qNeaQSUoapd/OFA7 c/Yw== X-Gm-Message-State: APjAAAX41s3QB5fpnCv4ur0TGjp+XKfBB/pQq3c0gqRtQCZB7R4ruNAK mMk16GwLA3lngcC2RcEX+oHUYhYcX5F6zqbxBd/2gO9fi6X6jSAPHXoKmi2maiLt8adsqHj9B1U z6xRqrjfm4T4l X-Received: by 2002:a1c:a78b:: with SMTP id q133mr4438704wme.28.1582204021862; Thu, 20 Feb 2020 05:07:01 -0800 (PST) X-Received: by 2002:a1c:a78b:: with SMTP id q133mr4438660wme.28.1582204021604; Thu, 20 Feb 2020 05:07:01 -0800 (PST) Received: from localhost.localdomain (78.red-88-21-202.staticip.rima-tde.net. [88.21.202.78]) by smtp.gmail.com with ESMTPSA id b67sm4594690wmc.38.2020.02.20.05.06.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Feb 2020 05:07:01 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Peter Maydell , qemu-devel@nongnu.org Cc: "Edgar E. Iglesias" , Anthony Perard , Fam Zheng , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , kvm@vger.kernel.org, Laurent Vivier , Thomas Huth , Stefan Weil , Eric Auger , Halil Pasic , Marcel Apfelbaum , qemu-s390x@nongnu.org, Aleksandar Rikalo , David Gibson , Michael Walle , qemu-ppc@nongnu.org, Gerd Hoffmann , Cornelia Huck , qemu-arm@nongnu.org, Alistair Francis , qemu-block@nongnu.org, =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Jason Wang , xen-devel@lists.xenproject.org, Christian Borntraeger , Dmitry Fleytman , Matthew Rosato , Eduardo Habkost , Richard Henderson , "Michael S. Tsirkin" , David Hildenbrand , Paolo Bonzini , Stefano Stabellini , Igor Mitsyanko , Paul Durrant , Richard Henderson , John Snow Subject: [PATCH v3 18/20] exec: Let cpu_[physical]_memory API use a boolean 'is_write' argument Date: Thu, 20 Feb 2020 14:05:46 +0100 Message-Id: <20200220130548.29974-19-philmd@redhat.com> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200220130548.29974-1-philmd@redhat.com> References: <20200220130548.29974-1-philmd@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org X-TUID: GW5htH1tH72h The 'is_write' argument is either 0 or 1. Convert it to a boolean type. Signed-off-by: Philippe Mathieu-Daudé --- include/exec/cpu-all.h | 2 +- include/exec/cpu-common.h | 6 +++--- exec.c | 10 +++++----- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/include/exec/cpu-all.h b/include/exec/cpu-all.h index 49e96caa3f..49384bb66a 100644 --- a/include/exec/cpu-all.h +++ b/include/exec/cpu-all.h @@ -388,7 +388,7 @@ void dump_opcount_info(void); #endif /* !CONFIG_USER_ONLY */ int cpu_memory_rw_debug(CPUState *cpu, target_ulong addr, - void *ptr, target_ulong len, int is_write); + void *ptr, target_ulong len, bool is_write); int cpu_exec(CPUState *cpu); diff --git a/include/exec/cpu-common.h b/include/exec/cpu-common.h index 165f8fb621..6bfe201779 100644 --- a/include/exec/cpu-common.h +++ b/include/exec/cpu-common.h @@ -70,7 +70,7 @@ size_t qemu_ram_pagesize(RAMBlock *block); size_t qemu_ram_pagesize_largest(void); void cpu_physical_memory_rw(hwaddr addr, void *buf, - hwaddr len, int is_write); + hwaddr len, bool is_write); static inline void cpu_physical_memory_read(hwaddr addr, void *buf, hwaddr len) { @@ -83,9 +83,9 @@ static inline void cpu_physical_memory_write(hwaddr addr, } void *cpu_physical_memory_map(hwaddr addr, hwaddr *plen, - int is_write); + bool is_write); void cpu_physical_memory_unmap(void *buffer, hwaddr len, - int is_write, hwaddr access_len); + bool is_write, hwaddr access_len); void cpu_register_map_client(QEMUBH *bh); void cpu_unregister_map_client(QEMUBH *bh); diff --git a/exec.c b/exec.c index b79919a4f7..6c39b43155 100644 --- a/exec.c +++ b/exec.c @@ -3019,7 +3019,7 @@ MemoryRegion *get_system_io(void) /* physical memory access (slow version, mainly for debug) */ #if defined(CONFIG_USER_ONLY) int cpu_memory_rw_debug(CPUState *cpu, target_ulong addr, - void *ptr, target_ulong len, int is_write) + void *ptr, target_ulong len, bool is_write) { int flags; target_ulong l, page; @@ -3313,7 +3313,7 @@ MemTxResult address_space_rw(AddressSpace *as, hwaddr addr, MemTxAttrs attrs, } void cpu_physical_memory_rw(hwaddr addr, void *buf, - hwaddr len, int is_write) + hwaddr len, bool is_write) { address_space_rw(&address_space_memory, addr, MEMTXATTRS_UNSPECIFIED, buf, len, is_write); @@ -3632,14 +3632,14 @@ void address_space_unmap(AddressSpace *as, void *buffer, hwaddr len, void *cpu_physical_memory_map(hwaddr addr, hwaddr *plen, - int is_write) + bool is_write) { return address_space_map(&address_space_memory, addr, plen, is_write, MEMTXATTRS_UNSPECIFIED); } void cpu_physical_memory_unmap(void *buffer, hwaddr len, - int is_write, hwaddr access_len) + bool is_write, hwaddr access_len) { return address_space_unmap(&address_space_memory, buffer, len, is_write, access_len); } @@ -3790,7 +3790,7 @@ address_space_write_cached_slow(MemoryRegionCache *cache, hwaddr addr, /* virtual memory access for debug (includes writing to ROM) */ int cpu_memory_rw_debug(CPUState *cpu, target_ulong addr, - void *ptr, target_ulong len, int is_write) + void *ptr, target_ulong len, bool is_write) { hwaddr phys_addr; target_ulong l, page; -- 2.21.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C549C11D04 for ; Thu, 20 Feb 2020 13:07:27 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4BE08206ED for ; Thu, 20 Feb 2020 13:07:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="AuITvZ+N" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4BE08206ED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1j4lXx-000201-Pc; Thu, 20 Feb 2020 13:07:17 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1j4lXw-0001yq-63 for xen-devel@lists.xenproject.org; Thu, 20 Feb 2020 13:07:16 +0000 X-Inumbo-ID: e423bf78-53e1-11ea-8526-12813bfff9fa Received: from us-smtp-1.mimecast.com (unknown [205.139.110.61]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTP id e423bf78-53e1-11ea-8526-12813bfff9fa; Thu, 20 Feb 2020 13:07:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582204024; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MwD83MRmvk9U4szTuvQnf8dMN/lBsu/ps/CgrjG/jog=; b=AuITvZ+Nps5lmurVgIAuEObN9X8ceztUdaRkZpru/lLXOBxm1f9lGBGEHWQVJid4YwYt6f Op+Gw4w8tMqRFEI5kik/IQFOO5NdP0WZ1MvYP5WtTL4M/HreQd3vPkuoZumUZOFXss083r eVxbF5mMKvt4hVaL4ejwM3mG/z+v1V0= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-368-3gVD0Ri_Pwq1CUcNrF41AQ-1; Thu, 20 Feb 2020 08:07:03 -0500 Received: by mail-wm1-f70.google.com with SMTP id t17so798525wmi.7 for ; Thu, 20 Feb 2020 05:07:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=3GOpiWMITxx9TtgKrEdUBt5MYBhcyKxmOeh0GtNqL3Q=; b=FKoE2FsIvp80yLNMmPbmDB0Rk9ruNhTZGR7ztbAaZZIyybTW28z1QgY1qljk1bs+eA CIJ8OMzL99GmpxqZCgXNLlS/STz69FFplLYwb7xp6M5yFKHHfSbq6nkpeiCcIXttdrK3 Er1RxtQ1tWucyEjTXRRKorwwjJyWb7dquseJE+5ST/2zjuVhxRuCElCcRWj8+5bSa5+r zRfANjaYw04ZcU6qx8lNnV5uSo/djiDkT9mg8llphW9VAKsWCo/0JYyZCOASXqSm6rhh +6B1SV8Lj/YWDRZLuB0FQwx47oIkwUt1tRRMCDgpCZxenW4xWpTHAm/PWa704jmReuzI bBkA== X-Gm-Message-State: APjAAAXwCjF2vHxGxjKYYlrKI4C1m+9Shab9JQUT/jBj/hCpHKu2Tq1M 7J8RbJvoh5yCaNyZIYWf7hOiqXHK5I43RlIqTuk6RTQMdaFVdXVKzl2mGMbqZS4+5f9Q0ttuMjf Nc9RZrJpRxS8zj1lSgb2Fp6jGNEQ= X-Received: by 2002:a1c:a78b:: with SMTP id q133mr4438680wme.28.1582204021859; Thu, 20 Feb 2020 05:07:01 -0800 (PST) X-Google-Smtp-Source: APXvYqy5fs9il9OncKFrjhrarKjFKFUysaRlKljcdDwQycfDDjjbJaA7nUH+Kd8+rszknwLmOaxWsA== X-Received: by 2002:a1c:a78b:: with SMTP id q133mr4438660wme.28.1582204021604; Thu, 20 Feb 2020 05:07:01 -0800 (PST) Received: from localhost.localdomain (78.red-88-21-202.staticip.rima-tde.net. [88.21.202.78]) by smtp.gmail.com with ESMTPSA id b67sm4594690wmc.38.2020.02.20.05.06.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Feb 2020 05:07:01 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Peter Maydell , qemu-devel@nongnu.org Date: Thu, 20 Feb 2020 14:05:46 +0100 Message-Id: <20200220130548.29974-19-philmd@redhat.com> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200220130548.29974-1-philmd@redhat.com> References: <20200220130548.29974-1-philmd@redhat.com> MIME-Version: 1.0 X-MC-Unique: 3gVD0Ri_Pwq1CUcNrF41AQ-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Subject: [Xen-devel] [PATCH v3 18/20] exec: Let cpu_[physical]_memory API use a boolean 'is_write' argument X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Dmitry Fleytman , kvm@vger.kernel.org, "Michael S. Tsirkin" , Jason Wang , Gerd Hoffmann , "Edgar E. Iglesias" , Stefano Stabellini , Matthew Rosato , qemu-block@nongnu.org, David Hildenbrand , Halil Pasic , Christian Borntraeger , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Marcel Apfelbaum , Anthony Perard , xen-devel@lists.xenproject.org, Aleksandar Rikalo , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Laurent Vivier , Thomas Huth , Eduardo Habkost , Stefan Weil , Alistair Francis , Richard Henderson , Paul Durrant , Eric Auger , qemu-s390x@nongnu.org, qemu-arm@nongnu.org, =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , John Snow , David Gibson , Igor Mitsyanko , Cornelia Huck , Michael Walle , qemu-ppc@nongnu.org, Paolo Bonzini Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" VGhlICdpc193cml0ZScgYXJndW1lbnQgaXMgZWl0aGVyIDAgb3IgMS4KQ29udmVydCBpdCB0byBh IGJvb2xlYW4gdHlwZS4KClNpZ25lZC1vZmYtYnk6IFBoaWxpcHBlIE1hdGhpZXUtRGF1ZMOpIDxw aGlsbWRAcmVkaGF0LmNvbT4KLS0tCiBpbmNsdWRlL2V4ZWMvY3B1LWFsbC5oICAgIHwgIDIgKy0K IGluY2x1ZGUvZXhlYy9jcHUtY29tbW9uLmggfCAgNiArKystLS0KIGV4ZWMuYyAgICAgICAgICAg ICAgICAgICAgfCAxMCArKysrKy0tLS0tCiAzIGZpbGVzIGNoYW5nZWQsIDkgaW5zZXJ0aW9ucygr KSwgOSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9pbmNsdWRlL2V4ZWMvY3B1LWFsbC5oIGIv aW5jbHVkZS9leGVjL2NwdS1hbGwuaAppbmRleCA0OWU5NmNhYTNmLi40OTM4NGJiNjZhIDEwMDY0 NAotLS0gYS9pbmNsdWRlL2V4ZWMvY3B1LWFsbC5oCisrKyBiL2luY2x1ZGUvZXhlYy9jcHUtYWxs LmgKQEAgLTM4OCw3ICszODgsNyBAQCB2b2lkIGR1bXBfb3Bjb3VudF9pbmZvKHZvaWQpOwogI2Vu ZGlmIC8qICFDT05GSUdfVVNFUl9PTkxZICovCiAKIGludCBjcHVfbWVtb3J5X3J3X2RlYnVnKENQ VVN0YXRlICpjcHUsIHRhcmdldF91bG9uZyBhZGRyLAotICAgICAgICAgICAgICAgICAgICAgICAg dm9pZCAqcHRyLCB0YXJnZXRfdWxvbmcgbGVuLCBpbnQgaXNfd3JpdGUpOworICAgICAgICAgICAg ICAgICAgICAgICAgdm9pZCAqcHRyLCB0YXJnZXRfdWxvbmcgbGVuLCBib29sIGlzX3dyaXRlKTsK IAogaW50IGNwdV9leGVjKENQVVN0YXRlICpjcHUpOwogCmRpZmYgLS1naXQgYS9pbmNsdWRlL2V4 ZWMvY3B1LWNvbW1vbi5oIGIvaW5jbHVkZS9leGVjL2NwdS1jb21tb24uaAppbmRleCAxNjVmOGZi NjIxLi42YmZlMjAxNzc5IDEwMDY0NAotLS0gYS9pbmNsdWRlL2V4ZWMvY3B1LWNvbW1vbi5oCisr KyBiL2luY2x1ZGUvZXhlYy9jcHUtY29tbW9uLmgKQEAgLTcwLDcgKzcwLDcgQEAgc2l6ZV90IHFl bXVfcmFtX3BhZ2VzaXplKFJBTUJsb2NrICpibG9jayk7CiBzaXplX3QgcWVtdV9yYW1fcGFnZXNp emVfbGFyZ2VzdCh2b2lkKTsKIAogdm9pZCBjcHVfcGh5c2ljYWxfbWVtb3J5X3J3KGh3YWRkciBh ZGRyLCB2b2lkICpidWYsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgaHdhZGRyIGxlbiwg aW50IGlzX3dyaXRlKTsKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICBod2FkZHIgbGVuLCBi b29sIGlzX3dyaXRlKTsKIHN0YXRpYyBpbmxpbmUgdm9pZCBjcHVfcGh5c2ljYWxfbWVtb3J5X3Jl YWQoaHdhZGRyIGFkZHIsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIHZvaWQgKmJ1ZiwgaHdhZGRyIGxlbikKIHsKQEAgLTgzLDkgKzgzLDkgQEAgc3RhdGljIGlu bGluZSB2b2lkIGNwdV9waHlzaWNhbF9tZW1vcnlfd3JpdGUoaHdhZGRyIGFkZHIsCiB9CiB2b2lk ICpjcHVfcGh5c2ljYWxfbWVtb3J5X21hcChod2FkZHIgYWRkciwKICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIGh3YWRkciAqcGxlbiwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IGludCBpc193cml0ZSk7CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBib29sIGlzX3dy aXRlKTsKIHZvaWQgY3B1X3BoeXNpY2FsX21lbW9yeV91bm1hcCh2b2lkICpidWZmZXIsIGh3YWRk ciBsZW4sCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaW50IGlzX3dyaXRlLCBod2Fk ZHIgYWNjZXNzX2xlbik7CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYm9vbCBpc193 cml0ZSwgaHdhZGRyIGFjY2Vzc19sZW4pOwogdm9pZCBjcHVfcmVnaXN0ZXJfbWFwX2NsaWVudChR RU1VQkggKmJoKTsKIHZvaWQgY3B1X3VucmVnaXN0ZXJfbWFwX2NsaWVudChRRU1VQkggKmJoKTsK IApkaWZmIC0tZ2l0IGEvZXhlYy5jIGIvZXhlYy5jCmluZGV4IGI3OTkxOWE0ZjcuLjZjMzliNDMx NTUgMTAwNjQ0Ci0tLSBhL2V4ZWMuYworKysgYi9leGVjLmMKQEAgLTMwMTksNyArMzAxOSw3IEBA IE1lbW9yeVJlZ2lvbiAqZ2V0X3N5c3RlbV9pbyh2b2lkKQogLyogcGh5c2ljYWwgbWVtb3J5IGFj Y2VzcyAoc2xvdyB2ZXJzaW9uLCBtYWlubHkgZm9yIGRlYnVnKSAqLwogI2lmIGRlZmluZWQoQ09O RklHX1VTRVJfT05MWSkKIGludCBjcHVfbWVtb3J5X3J3X2RlYnVnKENQVVN0YXRlICpjcHUsIHRh cmdldF91bG9uZyBhZGRyLAotICAgICAgICAgICAgICAgICAgICAgICAgdm9pZCAqcHRyLCB0YXJn ZXRfdWxvbmcgbGVuLCBpbnQgaXNfd3JpdGUpCisgICAgICAgICAgICAgICAgICAgICAgICB2b2lk ICpwdHIsIHRhcmdldF91bG9uZyBsZW4sIGJvb2wgaXNfd3JpdGUpCiB7CiAgICAgaW50IGZsYWdz OwogICAgIHRhcmdldF91bG9uZyBsLCBwYWdlOwpAQCAtMzMxMyw3ICszMzEzLDcgQEAgTWVtVHhS ZXN1bHQgYWRkcmVzc19zcGFjZV9ydyhBZGRyZXNzU3BhY2UgKmFzLCBod2FkZHIgYWRkciwgTWVt VHhBdHRycyBhdHRycywKIH0KIAogdm9pZCBjcHVfcGh5c2ljYWxfbWVtb3J5X3J3KGh3YWRkciBh ZGRyLCB2b2lkICpidWYsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgaHdhZGRyIGxlbiwg aW50IGlzX3dyaXRlKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgIGh3YWRkciBsZW4sIGJv b2wgaXNfd3JpdGUpCiB7CiAgICAgYWRkcmVzc19zcGFjZV9ydygmYWRkcmVzc19zcGFjZV9tZW1v cnksIGFkZHIsIE1FTVRYQVRUUlNfVU5TUEVDSUZJRUQsCiAgICAgICAgICAgICAgICAgICAgICBi dWYsIGxlbiwgaXNfd3JpdGUpOwpAQCAtMzYzMiwxNCArMzYzMiwxNCBAQCB2b2lkIGFkZHJlc3Nf c3BhY2VfdW5tYXAoQWRkcmVzc1NwYWNlICphcywgdm9pZCAqYnVmZmVyLCBod2FkZHIgbGVuLAog CiB2b2lkICpjcHVfcGh5c2ljYWxfbWVtb3J5X21hcChod2FkZHIgYWRkciwKICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIGh3YWRkciAqcGxlbiwKLSAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIGludCBpc193cml0ZSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGJvb2wg aXNfd3JpdGUpCiB7CiAgICAgcmV0dXJuIGFkZHJlc3Nfc3BhY2VfbWFwKCZhZGRyZXNzX3NwYWNl X21lbW9yeSwgYWRkciwgcGxlbiwgaXNfd3JpdGUsCiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIE1FTVRYQVRUUlNfVU5TUEVDSUZJRUQpOwogfQogCiB2b2lkIGNwdV9waHlzaWNhbF9tZW1v cnlfdW5tYXAodm9pZCAqYnVmZmVyLCBod2FkZHIgbGVuLAotICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIGludCBpc193cml0ZSwgaHdhZGRyIGFjY2Vzc19sZW4pCisgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgYm9vbCBpc193cml0ZSwgaHdhZGRyIGFjY2Vzc19sZW4pCiB7CiAg ICAgcmV0dXJuIGFkZHJlc3Nfc3BhY2VfdW5tYXAoJmFkZHJlc3Nfc3BhY2VfbWVtb3J5LCBidWZm ZXIsIGxlbiwgaXNfd3JpdGUsIGFjY2Vzc19sZW4pOwogfQpAQCAtMzc5MCw3ICszNzkwLDcgQEAg YWRkcmVzc19zcGFjZV93cml0ZV9jYWNoZWRfc2xvdyhNZW1vcnlSZWdpb25DYWNoZSAqY2FjaGUs IGh3YWRkciBhZGRyLAogCiAvKiB2aXJ0dWFsIG1lbW9yeSBhY2Nlc3MgZm9yIGRlYnVnIChpbmNs dWRlcyB3cml0aW5nIHRvIFJPTSkgKi8KIGludCBjcHVfbWVtb3J5X3J3X2RlYnVnKENQVVN0YXRl ICpjcHUsIHRhcmdldF91bG9uZyBhZGRyLAotICAgICAgICAgICAgICAgICAgICAgICAgdm9pZCAq cHRyLCB0YXJnZXRfdWxvbmcgbGVuLCBpbnQgaXNfd3JpdGUpCisgICAgICAgICAgICAgICAgICAg ICAgICB2b2lkICpwdHIsIHRhcmdldF91bG9uZyBsZW4sIGJvb2wgaXNfd3JpdGUpCiB7CiAgICAg aHdhZGRyIHBoeXNfYWRkcjsKICAgICB0YXJnZXRfdWxvbmcgbCwgcGFnZTsKLS0gCjIuMjEuMQoK Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZl bCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnCmh0dHBzOi8vbGlz dHMueGVucHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby94ZW4tZGV2ZWw= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53224C11D04 for ; Thu, 20 Feb 2020 13:18:11 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 20CA2208C4 for ; Thu, 20 Feb 2020 13:18:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="AuITvZ+N" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 20CA2208C4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:41926 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j4liU-0002HX-6V for qemu-devel@archiver.kernel.org; Thu, 20 Feb 2020 08:18:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:56544) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j4lXn-0006Lm-BI for qemu-devel@nongnu.org; Thu, 20 Feb 2020 08:07:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j4lXl-0005t0-FQ for qemu-devel@nongnu.org; Thu, 20 Feb 2020 08:07:07 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:29383 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j4lXl-0005sF-8i for qemu-devel@nongnu.org; Thu, 20 Feb 2020 08:07:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582204024; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MwD83MRmvk9U4szTuvQnf8dMN/lBsu/ps/CgrjG/jog=; b=AuITvZ+Nps5lmurVgIAuEObN9X8ceztUdaRkZpru/lLXOBxm1f9lGBGEHWQVJid4YwYt6f Op+Gw4w8tMqRFEI5kik/IQFOO5NdP0WZ1MvYP5WtTL4M/HreQd3vPkuoZumUZOFXss083r eVxbF5mMKvt4hVaL4ejwM3mG/z+v1V0= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-435-ct5_aLWNMNiOJhXNrAN1Fw-1; Thu, 20 Feb 2020 08:07:02 -0500 Received: by mail-wm1-f69.google.com with SMTP id w12so804738wmc.3 for ; Thu, 20 Feb 2020 05:07:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=3GOpiWMITxx9TtgKrEdUBt5MYBhcyKxmOeh0GtNqL3Q=; b=NQuYsehmzyWIY6+ZQZT/l/nHUOz7xdOSEcy47/I6vmLpyJC+zP0ex0pJnoFKMi94os /HOnb55y3n198CMBaWp4J5Ca0cAHac3hEcu2lfMgPJVLgErtwB64pxfhVtFSdB9UkvOa 2rs0bC8IvTdDsEcWAhEIrOhB+UdTc/pdPx3z3rJiw7OKZzXnKhMPPXMH+4zwdlRz2kQD EGIcQujNKH9iGRcSfNtoKsMNLZOrN1KtiAhUfYY5eCZFZ/gOdlZFTYqlsb4pXZiJRKDw TxXO+B9ijupIHQ1+JDyk2Og+De8fiOc/K8xNpTxL4+RQcU7TDBxviQBg2zSPsiBlMpIZ CSVw== X-Gm-Message-State: APjAAAXa/O3rLjO0gz8xSlun1AJ8QZYX5Ok3VprMSOMINiOL661UfEgy EpZ8dtdodjFQPJq5mx+UmIVAbr7kIib+hbpAunqyQFoQrt5yAj2+C2Z/U01dkjforuv4Z9tMqMg W7P13fCTqvT1UeYM= X-Received: by 2002:a1c:a78b:: with SMTP id q133mr4438678wme.28.1582204021859; Thu, 20 Feb 2020 05:07:01 -0800 (PST) X-Google-Smtp-Source: APXvYqy5fs9il9OncKFrjhrarKjFKFUysaRlKljcdDwQycfDDjjbJaA7nUH+Kd8+rszknwLmOaxWsA== X-Received: by 2002:a1c:a78b:: with SMTP id q133mr4438660wme.28.1582204021604; Thu, 20 Feb 2020 05:07:01 -0800 (PST) Received: from localhost.localdomain (78.red-88-21-202.staticip.rima-tde.net. [88.21.202.78]) by smtp.gmail.com with ESMTPSA id b67sm4594690wmc.38.2020.02.20.05.06.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Feb 2020 05:07:01 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Peter Maydell , qemu-devel@nongnu.org Subject: [PATCH v3 18/20] exec: Let cpu_[physical]_memory API use a boolean 'is_write' argument Date: Thu, 20 Feb 2020 14:05:46 +0100 Message-Id: <20200220130548.29974-19-philmd@redhat.com> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200220130548.29974-1-philmd@redhat.com> References: <20200220130548.29974-1-philmd@redhat.com> MIME-Version: 1.0 X-MC-Unique: ct5_aLWNMNiOJhXNrAN1Fw-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8; text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Dmitry Fleytman , kvm@vger.kernel.org, "Michael S. Tsirkin" , Jason Wang , Gerd Hoffmann , "Edgar E. Iglesias" , Stefano Stabellini , Matthew Rosato , qemu-block@nongnu.org, David Hildenbrand , Halil Pasic , Christian Borntraeger , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Anthony Perard , xen-devel@lists.xenproject.org, Aleksandar Rikalo , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Laurent Vivier , Thomas Huth , Eduardo Habkost , Stefan Weil , Alistair Francis , Richard Henderson , Paul Durrant , Eric Auger , qemu-s390x@nongnu.org, qemu-arm@nongnu.org, =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , John Snow , David Gibson , Igor Mitsyanko , Cornelia Huck , Michael Walle , qemu-ppc@nongnu.org, Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" The 'is_write' argument is either 0 or 1. Convert it to a boolean type. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- include/exec/cpu-all.h | 2 +- include/exec/cpu-common.h | 6 +++--- exec.c | 10 +++++----- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/include/exec/cpu-all.h b/include/exec/cpu-all.h index 49e96caa3f..49384bb66a 100644 --- a/include/exec/cpu-all.h +++ b/include/exec/cpu-all.h @@ -388,7 +388,7 @@ void dump_opcount_info(void); #endif /* !CONFIG_USER_ONLY */ =20 int cpu_memory_rw_debug(CPUState *cpu, target_ulong addr, - void *ptr, target_ulong len, int is_write); + void *ptr, target_ulong len, bool is_write); =20 int cpu_exec(CPUState *cpu); =20 diff --git a/include/exec/cpu-common.h b/include/exec/cpu-common.h index 165f8fb621..6bfe201779 100644 --- a/include/exec/cpu-common.h +++ b/include/exec/cpu-common.h @@ -70,7 +70,7 @@ size_t qemu_ram_pagesize(RAMBlock *block); size_t qemu_ram_pagesize_largest(void); =20 void cpu_physical_memory_rw(hwaddr addr, void *buf, - hwaddr len, int is_write); + hwaddr len, bool is_write); static inline void cpu_physical_memory_read(hwaddr addr, void *buf, hwaddr len) { @@ -83,9 +83,9 @@ static inline void cpu_physical_memory_write(hwaddr addr, } void *cpu_physical_memory_map(hwaddr addr, hwaddr *plen, - int is_write); + bool is_write); void cpu_physical_memory_unmap(void *buffer, hwaddr len, - int is_write, hwaddr access_len); + bool is_write, hwaddr access_len); void cpu_register_map_client(QEMUBH *bh); void cpu_unregister_map_client(QEMUBH *bh); =20 diff --git a/exec.c b/exec.c index b79919a4f7..6c39b43155 100644 --- a/exec.c +++ b/exec.c @@ -3019,7 +3019,7 @@ MemoryRegion *get_system_io(void) /* physical memory access (slow version, mainly for debug) */ #if defined(CONFIG_USER_ONLY) int cpu_memory_rw_debug(CPUState *cpu, target_ulong addr, - void *ptr, target_ulong len, int is_write) + void *ptr, target_ulong len, bool is_write) { int flags; target_ulong l, page; @@ -3313,7 +3313,7 @@ MemTxResult address_space_rw(AddressSpace *as, hwaddr= addr, MemTxAttrs attrs, } =20 void cpu_physical_memory_rw(hwaddr addr, void *buf, - hwaddr len, int is_write) + hwaddr len, bool is_write) { address_space_rw(&address_space_memory, addr, MEMTXATTRS_UNSPECIFIED, buf, len, is_write); @@ -3632,14 +3632,14 @@ void address_space_unmap(AddressSpace *as, void *bu= ffer, hwaddr len, =20 void *cpu_physical_memory_map(hwaddr addr, hwaddr *plen, - int is_write) + bool is_write) { return address_space_map(&address_space_memory, addr, plen, is_write, MEMTXATTRS_UNSPECIFIED); } =20 void cpu_physical_memory_unmap(void *buffer, hwaddr len, - int is_write, hwaddr access_len) + bool is_write, hwaddr access_len) { return address_space_unmap(&address_space_memory, buffer, len, is_writ= e, access_len); } @@ -3790,7 +3790,7 @@ address_space_write_cached_slow(MemoryRegionCache *ca= che, hwaddr addr, =20 /* virtual memory access for debug (includes writing to ROM) */ int cpu_memory_rw_debug(CPUState *cpu, target_ulong addr, - void *ptr, target_ulong len, int is_write) + void *ptr, target_ulong len, bool is_write) { hwaddr phys_addr; target_ulong l, page; --=20 2.21.1