Re: [PATCH rdma-next 2/2] RDMA/opa_vnic: Delete driver version

[Leon Romanovsky <leon@kernel.org>]

On Thu, Feb 20, 2020 at 08:32:35AM -0500, Dennis Dalessandro wrote:
> On 2/20/2020 2:12 AM, Leon Romanovsky wrote:
> > From: Leon Romanovsky <leonro@mellanox.com>
> >
> > The default version provided by "ethtool -i" it the correct way
> > to identify Driver version. There is no need to overwrite it.
> >
> > Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
> > ---
> >   drivers/infiniband/ulp/opa_vnic/opa_vnic_ethtool.c  | 2 --
> >   drivers/infiniband/ulp/opa_vnic/opa_vnic_internal.h | 1 -
> >   drivers/infiniband/ulp/opa_vnic/opa_vnic_vema.c     | 5 -----
> >   3 files changed, 8 deletions(-)
> >
> > diff --git a/drivers/infiniband/ulp/opa_vnic/opa_vnic_ethtool.c b/drivers/infiniband/ulp/opa_vnic/opa_vnic_ethtool.c
> > index 8ad7da989a0e..42d557dff19d 100644
> > --- a/drivers/infiniband/ulp/opa_vnic/opa_vnic_ethtool.c
> > +++ b/drivers/infiniband/ulp/opa_vnic/opa_vnic_ethtool.c
> > @@ -125,8 +125,6 @@ static void vnic_get_drvinfo(struct net_device *netdev,
> >   			     struct ethtool_drvinfo *drvinfo)
> >   {
> >   	strlcpy(drvinfo->driver, opa_vnic_driver_name, sizeof(drvinfo->driver));
> > -	strlcpy(drvinfo->version, opa_vnic_driver_version,
> > -		sizeof(drvinfo->version));
> >   	strlcpy(drvinfo->bus_info, dev_name(netdev->dev.parent),
> >   		sizeof(drvinfo->bus_info));
> >   }
>
> Is there a patch series to get rid of drvinfo->version? Seems to me if we
> don't want drivers to set it then we don't need it to begin with do we?

Unfortunately struct ethtool_drvinfo is defined in include/uapi/linux/ethtool.h
and we can't change it without breaking ethtool.

My WIP in progress branch (based on net-next) is located here:
https://git.kernel.org/pub/scm/linux/kernel/git/leon/linux-rdma.git/log/?h=ethtool

At the end of my journey, we will have checkpatch.pl patch and update of
coding style.

>
> Regardless I don't have any objections to the patch. We've been down this
> road with version numbers and I believe this was added to vnic specifically
> to fill in something for ethtool.

And now, you will be able to see real version :)

>
> Reviewed-by: Dennis Dalessandro <dennis.dalessandro@intel.com>

Thanks

>
> -Denny