From: "Dr. David Alan Gilbert" <linux@treblig.org>
To: Meelis Roos <mroos@linux.ee>, linux@roeck-us.net
Cc: linux-hwmon@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Chen Zhou <chenzhou10@huawei.com>
Subject: Re: w83627ehf crash in 5.6.0-rc2-00055-gca7e1fd1026c
Date: Thu, 20 Feb 2020 13:57:09 +0000 [thread overview]
Message-ID: <20200220135709.GB18071@gallifrey> (raw)
In-Reply-To: <6050ed14-f7a6-cb99-7268-072129226d48@linux.ee>
* Meelis Roos (mroos@linux.ee) wrote:
> > It looks like not all chips have temp_label, so I think we need to change w83627ehf_is_visible
> > which has:
> >
> > if (attr == hwmon_temp_input || attr == hwmon_temp_label)
> > return 0444;
> >
> > to
> > if (attr == hwmon_temp_input)
> > return 0444;
> > if (attr == hwmon_temp_label) {
> > if (data->temp_label)
> > return 0444;
> > else
> > return 0;
> > }
> >
> > Does that work for you?
> Yes, it works - sensors are displayed as they should be, with nothing in dmesg.
>
> Thank you for so quick response!
Great, I need to turn that into a proper patch; (I might need to wait till
Saturday for that, although if someone needs it before then please shout).
Dave
>
> --
> Meelis Roos <mroos@linux.ee>
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/
next prev parent reply other threads:[~2020-02-20 13:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 11:18 w83627ehf crash in 5.6.0-rc2-00055-gca7e1fd1026c Meelis Roos
2020-02-20 12:14 ` Dr. David Alan Gilbert
2020-02-20 12:43 ` Meelis Roos
2020-02-20 13:57 ` Dr. David Alan Gilbert [this message]
2020-02-20 14:40 ` Guenter Roeck
2020-02-20 15:52 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200220135709.GB18071@gallifrey \
--to=linux@treblig.org \
--cc=chenzhou10@huawei.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mroos@linux.ee \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.