Re: [PATCH] KVM: x86: enable dirty log gradually in small chunks

[kbuild test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2400 bytes --]

Hi Jay,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on kvm/linux-next]
[also build test WARNING on vhost/linux-next v5.6-rc2 next-20200219]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Jay-Zhou/KVM-x86-enable-dirty-log-gradually-in-small-chunks/20200220-052018
base:   https://git.kernel.org/pub/scm/virt/kvm/kvm.git linux-next
config: s390-debug_defconfig (attached as .config)
compiler: s390-linux-gcc (GCC) 7.5.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.5.0 make.cross ARCH=s390 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   arch/s390/kvm/../../../virt/kvm/kvm_main.c: In function 'kvm_create_dirty_bitmap':
>> arch/s390/kvm/../../../virt/kvm/kvm_main.c:874:5: warning: "CONFIG_KVM_GENERIC_DIRTYLOG_READ_PROTECT" is not defined, evaluates to 0 [-Wundef]
    #if CONFIG_KVM_GENERIC_DIRTYLOG_READ_PROTECT
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

vim +/CONFIG_KVM_GENERIC_DIRTYLOG_READ_PROTECT +874 arch/s390/kvm/../../../virt/kvm/kvm_main.c

   860	
   861	/*
   862	 * Allocation size is twice as large as the actual dirty bitmap size.
   863	 * See x86's kvm_vm_ioctl_get_dirty_log() why this is needed.
   864	 */
   865	static int kvm_create_dirty_bitmap(struct kvm *kvm,
   866					struct kvm_memory_slot *memslot)
   867	{
   868		unsigned long dirty_bytes = 2 * kvm_dirty_bitmap_bytes(memslot);
   869	
   870		memslot->dirty_bitmap = kvzalloc(dirty_bytes, GFP_KERNEL_ACCOUNT);
   871		if (!memslot->dirty_bitmap)
   872			return -ENOMEM;
   873	
 > 874	#if CONFIG_KVM_GENERIC_DIRTYLOG_READ_PROTECT
   875		if (kvm->manual_dirty_log_protect)
   876			kvm_set_first_dirty_bitmap(memslot);
   877	#endif
   878	
   879		return 0;
   880	}
   881	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 19344 bytes --]