From: Martin Doucha <mdoucha@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] Add test for CVE 2017-10661
Date: Thu, 20 Feb 2020 15:45:59 +0100 [thread overview]
Message-ID: <20200220144559.22440-1-mdoucha@suse.cz> (raw)
Signed-off-by: Martin Doucha <mdoucha@suse.cz>
---
testcases/cve/Makefile | 3 +
testcases/cve/cve-2017-10661.c | 112 +++++++++++++++++++++++++++++++++
2 files changed, 115 insertions(+)
create mode 100644 testcases/cve/cve-2017-10661.c
diff --git a/testcases/cve/Makefile b/testcases/cve/Makefile
index da44fff60..1faee9fc5 100644
--- a/testcases/cve/Makefile
+++ b/testcases/cve/Makefile
@@ -36,6 +36,9 @@ endif
cve-2017-2671: CFLAGS += -pthread
cve-2017-2671: LDLIBS += -lrt
+cve-2017-10661: CFLAGS += -pthread
+cve-2017-10661: LDLIBS += -lrt
+
meltdown: CFLAGS += -I$(abs_srcdir)/../realtime/include
ifneq (,$(filter $(HOST_CPU),x86 x86_64))
diff --git a/testcases/cve/cve-2017-10661.c b/testcases/cve/cve-2017-10661.c
new file mode 100644
index 000000000..6fe6b63c7
--- /dev/null
+++ b/testcases/cve/cve-2017-10661.c
@@ -0,0 +1,112 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+/*
+ * Copyright (C) 2020 SUSE LLC <mdoucha@suse.cz>
+ *
+ * CVE-2017-10661
+ *
+ * Test for race condition vulnerability in timerfd_settime(). Multiple
+ * concurrent calls of timerfd_settime() clearing the CANCEL_ON_SET flag may
+ * cause memory corruption. Fixed in:
+ *
+ * commit 1e38da300e1e395a15048b0af1e5305bd91402f6
+ * Author: Thomas Gleixner <tglx@linutronix.de>
+ * Date: Tue Jan 31 15:24:03 2017 +0100
+ *
+ * timerfd: Protect the might cancel mechanism proper
+ */
+#include <unistd.h>
+#include <lapi/timerfd.h>
+#include "tst_test.h"
+#include "tst_fuzzy_sync.h"
+#include "tst_taint.h"
+
+#define TIMERFD_FLAGS "timerfd_settime(TFD_TIMER_ABSTIME | TFD_TIMER_CANCEL_ON_SET)"
+
+#ifndef TFD_TIMER_CANCEL_ON_SET
+#define TFD_TIMER_CANCEL_ON_SET (1<<1)
+#endif
+
+static int fd = -1;
+static struct itimerspec its;
+static struct tst_fzsync_pair fzsync_pair;
+
+static void setup(void)
+{
+ int tmp;
+
+ tst_taint_init(TST_TAINT_W | TST_TAINT_D);
+ fd = timerfd_create(CLOCK_REALTIME, 0);
+
+ if (fd < 0) {
+ tmp = (errno == ENOTSUP ? TCONF : TBROK) | TERRNO,
+ tst_brk(tmp, "Cannot create timer");
+ }
+
+ fzsync_pair.exec_loops = 1000000;
+ tst_fzsync_pair_init(&fzsync_pair);
+}
+
+static void cleanup(void)
+{
+ if (fd >= 0)
+ SAFE_CLOSE(fd);
+ tst_fzsync_pair_cleanup(&fzsync_pair);
+}
+
+static int punch_clock(int flags)
+{
+ return timerfd_settime(fd, flags, &its, NULL);
+}
+
+static void *thread_run(void *arg)
+{
+ while (tst_fzsync_run_b(&fzsync_pair)) {
+ tst_fzsync_start_race_b(&fzsync_pair);
+ // race to clear the CANCEL_ON_SET flag
+ punch_clock(0);
+ tst_fzsync_end_race_b(&fzsync_pair);
+ }
+
+ return arg;
+}
+
+static void run(void)
+{
+ tst_fzsync_pair_reset(&fzsync_pair, thread_run);
+
+ while (tst_fzsync_run_a(&fzsync_pair)) {
+ // set the CANCEL_ON_SET flag
+ TEST(punch_clock(TFD_TIMER_ABSTIME | TFD_TIMER_CANCEL_ON_SET));
+
+ if (TST_RET == -1)
+ tst_res(TBROK | TTERRNO, TIMERFD_FLAGS " failed");
+
+ if (TST_RET != 0)
+ tst_res(TBROK | TTERRNO, "Invalid " TIMERFD_FLAGS
+ " return value");
+
+ tst_fzsync_start_race_a(&fzsync_pair);
+ // race to clear the CANCEL_ON_SET flag
+ punch_clock(0);
+ tst_fzsync_end_race_a(&fzsync_pair);
+
+ if (tst_taint_check()) {
+ tst_res(TFAIL, "Kernel is vulnerable");
+ return;
+ }
+ }
+
+ tst_res(TPASS, "Nothing bad happened, probably");
+}
+
+static struct tst_test test = {
+ .test_all = run,
+ .setup = setup,
+ .cleanup = cleanup,
+ .min_kver = "2.6.25",
+ .tags = (const struct tst_tag[]) {
+ {"linux-git", "1e38da300e1e"},
+ {"CVE", "2017-10661"},
+ {}
+ }
+};
--
2.25.0
next reply other threads:[~2020-02-20 14:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 14:45 Martin Doucha [this message]
2020-02-21 8:06 ` [LTP] [PATCH] Add test for CVE 2017-10661 Richard Palethorpe
2020-02-21 10:19 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200220144559.22440-1-mdoucha@suse.cz \
--to=mdoucha@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.