From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1j4n9i-0002QN-NQ for mharc-grub-devel@gnu.org; Thu, 20 Feb 2020 09:50:22 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:43963) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j4n9e-0002NC-Vx for grub-devel@gnu.org; Thu, 20 Feb 2020 09:50:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j4n9c-0000vv-Sr for grub-devel@gnu.org; Thu, 20 Feb 2020 09:50:18 -0500 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:59669) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j4n9b-0000sd-R0 for grub-devel@gnu.org; Thu, 20 Feb 2020 09:50:16 -0500 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 2CD4A5A5; Thu, 20 Feb 2020 09:50:11 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 20 Feb 2020 09:50:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pks.im; h=date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=G3AMdFOvR6F2uMKlGlnRgDBrb1m xMUmmqj+n2jSejXY=; b=q6xmFysyJQHPRsw2cOAphNS1ZeqknuFRG08kwx5J4hk ziwFQbcHUOqGo7LjdaC9oGc2HL6RnAk8x5ei51ctE+EH37biWxCvgaC111qSXWMk mhXcksoLy1/B0UXGYXyM4HZXunUH7EZAHYbQze4jZLg6YkOoAziYsEEnEylUsj1g 8K16jsefPee+DQFidkhGVl7ui8rd9S0iuVf9F7JNheD7k+f8K64/Yhl01uVPNcnt ors1X9QIwXFqQHAh1PEAP8QwmUBSlOWTQohE+IHW4cdPIlxdj2msHyaWCTCtN7pk Age0eRvGDvluCLkp7pwNiTxNsdHlDkio+ZGYmLQ+gUQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=G3AMdF OvR6F2uMKlGlnRgDBrb1mxMUmmqj+n2jSejXY=; b=sXF6B8dPPFx0HvOSLm7WWH YdutjXldwd+WArbHtk2j+fVsMy7fCN0pqR/JEdA+kO40VBY4eAfmAVI3/XYqyzfg PBFvn+bNHJ/yGIXi1ye5wHoB6r/BjoO8lRt8DxDPK5YpeEY5ZZTG54NW1KZbscq+ U6peaILTRAIFhNHO19FFO8G0jrGQSCh11NC1dGnr2v9KD4U7bf5vAiYIoUVLKZye QKEmhD03iNn1Ki5Q8GOH23+oWAtmbTHbXIfy4NMEPdXsyXacL4BlRAl8N45L0lik PMOvS6A/LC48KGWPMQafMx4H+/EbpNyFmhwLyc5z5o68qgbBls4jveC5FHjrGbfA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrkedvgdejtdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomheprfgrthhrihgt khcuufhtvghinhhhrghrughtuceophhssehpkhhsrdhimheqnecukfhppeejkedrheehrd dvvddrudejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhho mhepphhssehpkhhsrdhimh X-ME-Proxy: Received: from vm-mail (x4e371611.dyn.telefonica.de [78.55.22.17]) by mail.messagingengine.com (Postfix) with ESMTPA id CAFFE3280059; Thu, 20 Feb 2020 09:50:08 -0500 (EST) Received: from localhost (ncase [10.192.0.11]) by vm-mail (OpenSMTPD) with ESMTPSA id e95d49b4 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Thu, 20 Feb 2020 14:50:06 +0000 (UTC) Date: Thu, 20 Feb 2020 15:50:35 +0100 From: Patrick Steinhardt To: The development of GNU GRUB Cc: Daniel Kiper , gmazyland@gmail.com, leif@nuviainc.com, agraf@csgraf.de, pjones@redhat.com, mjg59@google.com, phcoder@gmail.com Subject: Re: [PATCH 0/5] Support Argon2 KDF in LUKS2 Message-ID: <20200220145035.GB4641@ncase> References: <20200211215359.m7dpfsq45zssqvtq@tomti.i.net-space.pl> <20200212074749.GA4330@ncase> <20200213114259.j5oalczscie6unyr@tomti.i.net-space.pl> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="DSayHWYpDlRfCAAQ" Content-Disposition: inline In-Reply-To: <20200213114259.j5oalczscie6unyr@tomti.i.net-space.pl> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 64.147.123.25 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Feb 2020 14:50:21 -0000 --DSayHWYpDlRfCAAQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Feb 13, 2020 at 12:42:59PM +0100, Daniel Kiper wrote: > On Wed, Feb 12, 2020 at 08:47:49AM +0100, Patrick Steinhardt wrote: > > On Tue, Feb 11, 2020 at 10:53:59PM +0100, Daniel Kiper wrote: > > > > GRUB's codebase. This included both stripping off unneeded > > > > functionality as well as converting the code to use our own c= oding > > > > > > Stripping unneeded functionality is OK. However, I think that it does > > > not make sense to convert coding style to the GRUB one. Especially if= we > > > do not do that for other modules. So, I would leave coding style in > > > Argon2 module as is and save your precious minutes for something more > > > productive... ;-) > > > > > > Fair enough, I'll send out a v2 with the original coding style. I > > thought as much when I was ready with v1, but was too lazy to do the > > work and change back the coding style. > > > > Anyway, to save myself another roundtrip: would you prefer to merge > > Argon2 functionality into a single file like I've done it right now or > > to retain the original set of files? The reason why I've opted for the > > latter is mainly to be able to annotate more functions as static. >=20 > I think that you should retain original set of files. And please add > a description to the docs/grub-dev.texi how to update Argon2 lib in > the future. >=20 > Daniel In the ideal case, we'd just compile Argon2 with the POSIX compat layer so that we wouldn't need to modify most of the types and functions used by it, like uint32, malloc, etc. As a result, libgrubkern.a would grow a dependency on C{,PP}FLAGS_POSIX, though. I did notice compilation errors in other modules when trying that, so my question is which path to go: fix resulting incompatibilities when adding POSIX includes or just replace types and function calls in Argon2 code? Patrick --DSayHWYpDlRfCAAQ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEtmscHsieVjl9VyNUEXxntp6r8SwFAl5OnLsACgkQEXxntp6r 8SzV4Q/+OvEAUZ1jdALeo1JfZXb2GxKXu7YqivfGkqxNo8cuL5ZrlKdHIyapu9T1 fiv+fNrOcg7K3lklHC2MjPklAyWdoei2JQIryKxCk+2Pk0xeluFbqY4xwfGPtVSQ Uv1qEOiu+ssKmMyDSbzIaZ4dNPa4SGvIIXAxva5PjGORI+luV4fXlrpg2gsb51eL 1s3ePBab5O3H0y6sPGLB4r6y5qiW5+9yaLC/MvUCyELSvIWYrxpoqWgmJ2elnTBj oYgj+2Wuia0YF4qcRUZbACJaOugTOfQWP1CiUazJbZvy/wHd+7+kCxby9RmVoky3 SoAaVPpBCtYbyvqnOkWD/oSUsT9ibYC2cFsc7zh/toMM8Dtwhn1vqQaEYwlVIDTq aZJtwILZU1BjUiJ2XljDXPZh2VXa1KviR7j2r5HBPkvagruz4nuE0RNYwvjPqoLQ UaQhPVnzalC+7MeFR2/ZoL0ay14rh+OfND2oU7F6ysKWxjUgmtaETZ6QGE6wIkj4 NfXbAnS2nnIrShyAAoWan6cOQW/N5/LFw03oDsEelu4PE+2wiGsj+dS9NTAZYDLo V7qG3tdcEXEKA6P7Wy4wqB+xx6pFVA97InW3kNYOhsnLTvyhF6PfrXyIVOKT/n8j FgANCxj3GpLXe8RE8PXspcN8R2z0iGZftCYELuuZrQxmQR2WAvI= =4Rhs -----END PGP SIGNATURE----- --DSayHWYpDlRfCAAQ--