From: Leon Romanovsky <leon@kernel.org>
To: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Cc: Leon Romanovsky <leonro@mellanox.com>,
linux-netdev <netdev@vger.kernel.org>
Subject: [PATCH net-next 03/16] net/3com: Delete driver and module versions from 3com drivers
Date: Thu, 20 Feb 2020 16:58:42 +0200 [thread overview]
Message-ID: <20200220145855.255704-4-leon@kernel.org> (raw)
In-Reply-To: <20200220145855.255704-1-leon@kernel.org>
From: Leon Romanovsky <leonro@mellanox.com>
There is no need to mislead users by providing different versions for
driver, ethtool and modules. Delete driver assignments and let use
the default one.
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
---
drivers/net/ethernet/3com/3c509.c | 7 +------
drivers/net/ethernet/3com/3c515.c | 6 ++----
drivers/net/ethernet/3com/3c589_cs.c | 2 --
drivers/net/ethernet/3com/typhoon.c | 1 -
4 files changed, 3 insertions(+), 13 deletions(-)
diff --git a/drivers/net/ethernet/3com/3c509.c b/drivers/net/ethernet/3com/3c509.c
index 8cafd06ff0c4..f1fc37c1c544 100644
--- a/drivers/net/ethernet/3com/3c509.c
+++ b/drivers/net/ethernet/3com/3c509.c
@@ -60,7 +60,6 @@
*/
#define DRV_NAME "3c509"
-#define DRV_VERSION "1.20"
#define DRV_RELDATE "04Feb2008"
/* A few values that may be tweaked. */
@@ -87,13 +86,12 @@
#include <linux/device.h>
#include <linux/eisa.h>
#include <linux/bitops.h>
+#include <linux/vermagic.h>
#include <linux/uaccess.h>
#include <asm/io.h>
#include <asm/irq.h>
-static char version[] = DRV_NAME ".c:" DRV_VERSION " " DRV_RELDATE " becker@scyld.com\n";
-
#ifdef EL3_DEBUG
static int el3_debug = EL3_DEBUG;
#else
@@ -547,8 +545,6 @@ static int el3_common_init(struct net_device *dev)
dev->name, dev->base_addr, if_names[(dev->if_port & 0x03)],
dev->dev_addr, dev->irq);
- if (el3_debug > 0)
- pr_info("%s", version);
return 0;
}
@@ -1143,7 +1139,6 @@ el3_netdev_set_ecmd(struct net_device *dev,
static void el3_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info)
{
strlcpy(info->driver, DRV_NAME, sizeof(info->driver));
- strlcpy(info->version, DRV_VERSION, sizeof(info->version));
}
static int el3_get_link_ksettings(struct net_device *dev,
diff --git a/drivers/net/ethernet/3com/3c515.c b/drivers/net/ethernet/3com/3c515.c
index 1e233e2f0a5a..b55fa8cb12e3 100644
--- a/drivers/net/ethernet/3com/3c515.c
+++ b/drivers/net/ethernet/3com/3c515.c
@@ -22,12 +22,12 @@
*/
+#include <linux/vermagic.h>
#define DRV_NAME "3c515"
-#define DRV_VERSION "0.99t-ac"
#define DRV_RELDATE "28-Oct-2002"
static char *version =
-DRV_NAME ".c:v" DRV_VERSION " " DRV_RELDATE " becker@scyld.com and others\n";
+DRV_NAME ".c:v" UTS_RELEASE " " DRV_RELDATE " becker@scyld.com and others\n";
#define CORKSCREW 1
@@ -84,7 +84,6 @@ static int max_interrupt_work = 20;
MODULE_AUTHOR("Donald Becker <becker@scyld.com>");
MODULE_DESCRIPTION("3Com 3c515 Corkscrew driver");
MODULE_LICENSE("GPL");
-MODULE_VERSION(DRV_VERSION);
/* "Knobs" for adjusting internal parameters. */
/* Put out somewhat more debugging messages. (0 - no msg, 1 minimal msgs). */
@@ -1540,7 +1539,6 @@ static void netdev_get_drvinfo(struct net_device *dev,
struct ethtool_drvinfo *info)
{
strlcpy(info->driver, DRV_NAME, sizeof(info->driver));
- strlcpy(info->version, DRV_VERSION, sizeof(info->version));
snprintf(info->bus_info, sizeof(info->bus_info), "ISA 0x%lx",
dev->base_addr);
}
diff --git a/drivers/net/ethernet/3com/3c589_cs.c b/drivers/net/ethernet/3com/3c589_cs.c
index d47cde6c5f08..09816e84314d 100644
--- a/drivers/net/ethernet/3com/3c589_cs.c
+++ b/drivers/net/ethernet/3com/3c589_cs.c
@@ -23,7 +23,6 @@
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
#define DRV_NAME "3c589_cs"
-#define DRV_VERSION "1.162-ac"
#include <linux/module.h>
#include <linux/kernel.h>
@@ -482,7 +481,6 @@ static void netdev_get_drvinfo(struct net_device *dev,
struct ethtool_drvinfo *info)
{
strlcpy(info->driver, DRV_NAME, sizeof(info->driver));
- strlcpy(info->version, DRV_VERSION, sizeof(info->version));
snprintf(info->bus_info, sizeof(info->bus_info),
"PCMCIA 0x%lx", dev->base_addr);
}
diff --git a/drivers/net/ethernet/3com/typhoon.c b/drivers/net/ethernet/3com/typhoon.c
index 14fce6658106..4383ee615793 100644
--- a/drivers/net/ethernet/3com/typhoon.c
+++ b/drivers/net/ethernet/3com/typhoon.c
@@ -127,7 +127,6 @@ static const int multicast_filter_limit = 32;
#include "typhoon.h"
MODULE_AUTHOR("David Dillow <dave@thedillows.org>");
-MODULE_VERSION("1.0");
MODULE_LICENSE("GPL");
MODULE_FIRMWARE(FIRMWARE_NAME);
MODULE_DESCRIPTION("3Com Typhoon Family (3C990, 3CR990, and variants)");
--
2.24.1
next prev parent reply other threads:[~2020-02-20 14:59 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 14:58 [PATCH net-next 00/16] Clean driver, module and FW versions Leon Romanovsky
2020-02-20 14:58 ` [PATCH net-next 01/16] net/bond: Delete driver and module versions Leon Romanovsky
2020-02-20 14:58 ` [PATCH net-next 02/16] net/dummy: Ditch " Leon Romanovsky
2020-02-21 9:11 ` Sergei Shtylyov
2020-02-22 7:28 ` Leon Romanovsky
2020-02-20 14:58 ` Leon Romanovsky [this message]
2020-02-20 14:58 ` [PATCH net-next 04/16] net/adaptec: Clean driver versions Leon Romanovsky
2020-02-20 14:58 ` [PATCH net-next 05/16] net/aeroflex: Clean ethtool_info struct assignments Leon Romanovsky
2020-02-20 14:58 ` [PATCH net-next 06/16] net/agere: Delete unneeded driver version Leon Romanovsky
2020-02-20 14:58 ` [PATCH net-next 07/16] net/alacritech: Delete " Leon Romanovsky
2020-02-20 14:58 ` [PATCH net-next 08/16] net/allwinner: Remove " Leon Romanovsky
2020-02-20 14:58 ` [PATCH net-next 09/16] net/alteon: Properly report FW version Leon Romanovsky
2020-02-20 14:58 ` [PATCH net-next 10/16] net/althera: Delete hardcoded driver version Leon Romanovsky
2020-02-20 14:58 ` [PATCH net-next 11/16] net/amazon: Ensure that driver version is aligned to the linux kernel Leon Romanovsky
2020-02-23 8:54 ` Gal Pressman
2020-02-23 9:10 ` Leon Romanovsky
2020-02-20 14:58 ` [PATCH net-next 12/16] net/amd: Remove useless driver version Leon Romanovsky
2020-02-20 14:58 ` [PATCH net-next 13/16] net/apm: Remove useless driver version and properly mark lack of FW Leon Romanovsky
2020-02-20 14:58 ` [PATCH net-next 14/16] net/aquantia: Delete module version Leon Romanovsky
2020-02-20 14:58 ` [PATCH net-next 15/16] net/arc: Delete driver version Leon Romanovsky
2020-02-20 14:58 ` [PATCH net-next 16/16] net/atheros: Clean atheros code from " Leon Romanovsky
2020-02-21 1:17 ` [PATCH net-next 00/16] Clean driver, module and FW versions Jakub Kicinski
2020-02-21 19:35 ` David Miller
2020-02-22 7:27 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200220145855.255704-4-leon@kernel.org \
--to=leon@kernel.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=leonro@mellanox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.