From: Mark Brown <broonie@kernel.org>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzk@kernel.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Sebastian Reichel <sre@kernel.org>
Subject: Re: [PATCH 1/3] regulator: max14577: Add proper dt-compatible strings
Date: Thu, 20 Feb 2020 16:56:14 +0000 [thread overview]
Message-ID: <20200220165614.GD3926@sirena.org.uk> (raw)
In-Reply-To: <20200220145127.21273-1-m.szyprowski@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 921 bytes --]
On Thu, Feb 20, 2020 at 03:51:25PM +0100, Marek Szyprowski wrote:
> Add device tree compatible strings and create proper modalias structures
> to let this driver load automatically if compiled as module, because
> max14577 MFD driver creates MFD cells with such compatible strings.
> +static const struct of_device_id of_max14577_regulator_dt_match[] = {
> + { .compatible = "maxim,max77836-regulator",
> + .data = (void *)MAXIM_DEVICE_TYPE_MAX77836, },
> + { .compatible = "maxim,max14577-regulator",
> + .data = (void *)MAXIM_DEVICE_TYPE_MAX14577, },
Why would we want to encode the particular way Linux happens to
represent regulators on a MFD into the DT binding? It's not clear that
this is a generic thing (another OS might choose to have a separate
object for each regulator with no parent for example) and the compatible
isn't adding any information we didn't have already knowing about the
parent device.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-02-20 16:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200220145134eucas1p288ae1910d3e8d12dc12f010ed0b07b45@eucas1p2.samsung.com>
2020-02-20 14:51 ` [PATCH 1/3] regulator: max14577: Add proper dt-compatible strings Marek Szyprowski
2020-02-20 14:51 ` [PATCH 2/3] extcon: " Marek Szyprowski
2020-03-14 18:45 ` Krzysztof Kozlowski
2020-02-20 14:51 ` [PATCH 3/3] power: charger: " Marek Szyprowski
2020-03-14 18:45 ` Krzysztof Kozlowski
2020-05-10 16:54 ` Sebastian Reichel
2020-02-20 16:56 ` Mark Brown [this message]
2020-02-21 10:44 ` [PATCH 1/3] regulator: " Marek Szyprowski
2020-02-21 12:38 ` Mark Brown
2020-02-21 13:23 ` Marek Szyprowski
2020-02-21 17:13 ` Mark Brown
2020-02-24 14:08 ` Marek Szyprowski
2020-02-24 20:12 ` Krzysztof Kozlowski
2020-03-06 13:51 ` Marek Szyprowski
2020-03-14 18:41 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200220165614.GD3926@sirena.org.uk \
--to=broonie@kernel.org \
--cc=b.zolnierkie@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=myungjoo.ham@samsung.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.