All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cornelia Huck <cohuck@redhat.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Janosch Frank <frankja@linux.vnet.ibm.com>,
	David Hildenbrand <david@redhat.com>,
	qemu-devel <qemu-devel@nongnu.org>,
	qemu-stable@nongnu.org, qemu-s390x <qemu-s390x@nongnu.org>,
	Richard Henderson <rth@twiddle.net>
Subject: Re: [PATCH] s390/sclp: improve special wait psw logic
Date: Thu, 20 Feb 2020 17:27:28 +0100	[thread overview]
Message-ID: <20200220172728.05992077.cohuck@redhat.com> (raw)
In-Reply-To: <a28b2eb0-8436-ff4e-c1f2-943ca6cd7443@de.ibm.com>

On Thu, 20 Feb 2020 14:35:01 +0100
Christian Borntraeger <borntraeger@de.ibm.com> wrote:

> On 20.02.20 14:26, David Hildenbrand wrote:
> > On 20.02.20 14:16, Christian Borntraeger wrote:  
> >> There is a special quiesce PSW that we check for "shutdown". Otherwise disabled
> >> wait is detected as "crashed". Architecturally we must only check PSW bits
> >> 116-127. Fix this.
> >>
> >> Cc: qemu-stable@nongnu.org  
> > 
> > Is this really stable material?  
> 
> Guests that end with lets say 0xaafffUL would be considered "crashed" instead of "shutdown".
> I will let Conny decide. 

It cannot really hurt; but would be interesting if you have seen that
in the wild.

> > 
> > Reviewed-by: David Hildenbrand <david@redhat.com>
> >   
> 



  reply	other threads:[~2020-02-20 16:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-20 13:16 [PATCH] s390/sclp: improve special wait psw logic Christian Borntraeger
2020-02-20 13:26 ` David Hildenbrand
2020-02-20 13:35   ` Christian Borntraeger
2020-02-20 16:27     ` Cornelia Huck [this message]
2020-02-20 13:47 ` Janosch Frank
2020-02-20 17:00 ` Cornelia Huck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200220172728.05992077.cohuck@redhat.com \
    --to=cohuck@redhat.com \
    --cc=borntraeger@de.ibm.com \
    --cc=david@redhat.com \
    --cc=frankja@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.