From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A42CDC11D0C for ; Thu, 20 Feb 2020 18:46:08 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 353ED2467A for ; Thu, 20 Feb 2020 18:46:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="j7ivdvVq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 353ED2467A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 7AEB016D6; Thu, 20 Feb 2020 19:45:16 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 7AEB016D6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1582224366; bh=pha4rbkELR+MlKiZpAxJZCb6i63te+xfEwqIiyC67gE=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=j7ivdvVqydr8Dbc0dt/VmC2cQk8KpCS/oP4U2Z7ycXAad5m7QmkSi7AkrwSVyg41q JzedUZdAf/+epcbT2S4ZWDSPtjjTXZu6Q83t2lNmyNU2wWXQVHEC5lREsb5bitQdKc Lb7rqaO9DXrQ9Gax7/152OES5qOMY3Smo3+rSf+w= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id BC4BCF80145; Thu, 20 Feb 2020 19:45:15 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 289ABF80148; Thu, 20 Feb 2020 19:45:14 +0100 (CET) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by alsa1.perex.cz (Postfix) with ESMTP id 8B2FCF80101 for ; Thu, 20 Feb 2020 19:45:11 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 8B2FCF80101 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AA4B130E; Thu, 20 Feb 2020 10:45:09 -0800 (PST) Received: from localhost (unknown [10.37.6.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1E7B63F6CF; Thu, 20 Feb 2020 10:45:08 -0800 (PST) Date: Thu, 20 Feb 2020 18:45:07 +0000 From: Mark Brown To: Dan Murphy Subject: Re: [PATCH] ASoC: tas2562: Add support for digital volume control Message-ID: <20200220184507.GF3926@sirena.org.uk> References: <20200220172721.10547-1-dmurphy@ti.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="hK8Uo4Yp55NZU70L" Content-Disposition: inline In-Reply-To: <20200220172721.10547-1-dmurphy@ti.com> X-Cookie: You are number 6! Who is number one? User-Agent: Mutt/1.10.1 (2018-07-13) Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, tiwai@suse.com, lgirdwood@gmail.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" --hK8Uo4Yp55NZU70L Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Feb 20, 2020 at 11:27:21AM -0600, Dan Murphy wrote: > + /* Set the Digital volume to -110dB */ > + ret = snd_soc_component_write(component, TAS2562_DVC_CFG4, 0x00); > + if (ret) > + return ret; > + ret = snd_soc_component_write(component, TAS2562_DVC_CFG3, 0x00); > + if (ret) > + return ret; > + ret = snd_soc_component_write(component, TAS2562_DVC_CFG2, 0x0d); > + if (ret) > + return ret; > + ret = snd_soc_component_write(component, TAS2562_DVC_CFG1, 0x43); > + if (ret) > + return ret; Is there a reason not to use the chip default here? Otherwise this looks good. --hK8Uo4Yp55NZU70L Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl5O07IACgkQJNaLcl1U h9DAjQf/cHDeWkaSRl4OHbk2bFU+NNUeICiEs7d2VmUuNe3pOWY4jw6w2tx/LGZ0 s0Ikm3/e6VYxuCqbUND6kIbzypru4df7TSoxV8nR5/5vM1mbVGKh1/zB2pURJ0M3 ZY1fEqA2gZLpdyJD1HwryukT7PnyhzbK1ACp+cnvdI8W6X2sV/7pIe/W33EvuHj7 BrxixQa7E3SGdOa0MM7014WUsOhcuh7KPjKswKH9j/hKNGYlLB0FI02qFFUR0fkT 1aFocXH34YKqP2NDRyDSY/0yijWTlf02Sa0kDgaIgTrOrwjBAtNkj1QwgSVbT477 s9fpTvqt7E5DAudi/+TK2YsORkI5JQ== =Q0Wc -----END PGP SIGNATURE----- --hK8Uo4Yp55NZU70L-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D559BC11D0C for ; Thu, 20 Feb 2020 18:45:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A525424673 for ; Thu, 20 Feb 2020 18:45:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582224311; bh=pha4rbkELR+MlKiZpAxJZCb6i63te+xfEwqIiyC67gE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=h2xxp07dSVST3YZA+dJPb3P53nLXH5ciRvWSm4jeky64INhBOP0ZEuqIIaGDNsG66 CAlBlHGNN2c4kWx/cnozU1vF5SunwffGGmjrdrmCxLkIfFvOrGvYRJEtgV6UCunSO3 rgWOXleSF59zkV/XvQZd6Xiz5+2uk1T0ktJ0lxnA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728770AbgBTSpK (ORCPT ); Thu, 20 Feb 2020 13:45:10 -0500 Received: from foss.arm.com ([217.140.110.172]:49440 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726959AbgBTSpK (ORCPT ); Thu, 20 Feb 2020 13:45:10 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AA4B130E; Thu, 20 Feb 2020 10:45:09 -0800 (PST) Received: from localhost (unknown [10.37.6.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1E7B63F6CF; Thu, 20 Feb 2020 10:45:08 -0800 (PST) Date: Thu, 20 Feb 2020 18:45:07 +0000 From: Mark Brown To: Dan Murphy Cc: lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ASoC: tas2562: Add support for digital volume control Message-ID: <20200220184507.GF3926@sirena.org.uk> References: <20200220172721.10547-1-dmurphy@ti.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="hK8Uo4Yp55NZU70L" Content-Disposition: inline In-Reply-To: <20200220172721.10547-1-dmurphy@ti.com> X-Cookie: You are number 6! Who is number one? User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --hK8Uo4Yp55NZU70L Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Feb 20, 2020 at 11:27:21AM -0600, Dan Murphy wrote: > + /* Set the Digital volume to -110dB */ > + ret = snd_soc_component_write(component, TAS2562_DVC_CFG4, 0x00); > + if (ret) > + return ret; > + ret = snd_soc_component_write(component, TAS2562_DVC_CFG3, 0x00); > + if (ret) > + return ret; > + ret = snd_soc_component_write(component, TAS2562_DVC_CFG2, 0x0d); > + if (ret) > + return ret; > + ret = snd_soc_component_write(component, TAS2562_DVC_CFG1, 0x43); > + if (ret) > + return ret; Is there a reason not to use the chip default here? Otherwise this looks good. --hK8Uo4Yp55NZU70L Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl5O07IACgkQJNaLcl1U h9DAjQf/cHDeWkaSRl4OHbk2bFU+NNUeICiEs7d2VmUuNe3pOWY4jw6w2tx/LGZ0 s0Ikm3/e6VYxuCqbUND6kIbzypru4df7TSoxV8nR5/5vM1mbVGKh1/zB2pURJ0M3 ZY1fEqA2gZLpdyJD1HwryukT7PnyhzbK1ACp+cnvdI8W6X2sV/7pIe/W33EvuHj7 BrxixQa7E3SGdOa0MM7014WUsOhcuh7KPjKswKH9j/hKNGYlLB0FI02qFFUR0fkT 1aFocXH34YKqP2NDRyDSY/0yijWTlf02Sa0kDgaIgTrOrwjBAtNkj1QwgSVbT477 s9fpTvqt7E5DAudi/+TK2YsORkI5JQ== =Q0Wc -----END PGP SIGNATURE----- --hK8Uo4Yp55NZU70L--