From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Subject: Re: [PATCH v2 4/4] drm/qxl: Use simple encoder Date: Thu, 20 Feb 2020 20:10:47 +0100 Message-ID: <20200220191047.GC20011@ravnborg.org> References: <20200218084815.2137-1-tzimmermann@suse.de> <20200218084815.2137-5-tzimmermann@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20200218084815.2137-5-tzimmermann@suse.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" To: Thomas Zimmermann Cc: airlied@linux.ie, dri-devel@lists.freedesktop.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, virtualization@lists.linux-foundation.org, noralf@tronnes.org, daniel@ffwll.ch, alexander.deucher@amd.com, spice-devel@lists.freedesktop.org, emil.velikov@collabora.com List-Id: virtualization@lists.linuxfoundation.org Hi Thomas. On Tue, Feb 18, 2020 at 09:48:15AM +0100, Thomas Zimmermann wrote: > The qxl driver uses an empty implementation for its encoder. Replace > the code with the generic simple encoder. > > v2: > * rebase onto new simple-encoder interface > > Signed-off-by: Thomas Zimmermann I looked at best_encoder - but could not see we could do anything. So from browsing the code: Acked-by: Sam Ravnborg Sam > --- > drivers/gpu/drm/qxl/qxl_display.c | 18 +++--------------- > 1 file changed, 3 insertions(+), 15 deletions(-) > > diff --git a/drivers/gpu/drm/qxl/qxl_display.c b/drivers/gpu/drm/qxl/qxl_display.c > index ab4f8dd00400..9c0e1add59fb 100644 > --- a/drivers/gpu/drm/qxl/qxl_display.c > +++ b/drivers/gpu/drm/qxl/qxl_display.c > @@ -31,6 +31,7 @@ > #include > #include > #include > +#include > > #include "qxl_drv.h" > #include "qxl_object.h" > @@ -1007,9 +1008,6 @@ static struct drm_encoder *qxl_best_encoder(struct drm_connector *connector) > return &qxl_output->enc; > } > > -static const struct drm_encoder_helper_funcs qxl_enc_helper_funcs = { > -}; > - > static const struct drm_connector_helper_funcs qxl_connector_helper_funcs = { > .get_modes = qxl_conn_get_modes, > .mode_valid = qxl_conn_mode_valid, > @@ -1059,15 +1057,6 @@ static const struct drm_connector_funcs qxl_connector_funcs = { > .atomic_destroy_state = drm_atomic_helper_connector_destroy_state, > }; > > -static void qxl_enc_destroy(struct drm_encoder *encoder) > -{ > - drm_encoder_cleanup(encoder); > -} > - > -static const struct drm_encoder_funcs qxl_enc_funcs = { > - .destroy = qxl_enc_destroy, > -}; > - > static int qxl_mode_create_hotplug_mode_update_property(struct qxl_device *qdev) > { > if (qdev->hotplug_mode_update_property) > @@ -1098,15 +1087,14 @@ static int qdev_output_init(struct drm_device *dev, int num_output) > drm_connector_init(dev, &qxl_output->base, > &qxl_connector_funcs, DRM_MODE_CONNECTOR_VIRTUAL); > > - drm_encoder_init(dev, &qxl_output->enc, &qxl_enc_funcs, > - DRM_MODE_ENCODER_VIRTUAL, NULL); > + drm_simple_encoder_init(dev, &qxl_output->enc, > + DRM_MODE_ENCODER_VIRTUAL); > > /* we get HPD via client monitors config */ > connector->polled = DRM_CONNECTOR_POLL_HPD; > encoder->possible_crtcs = 1 << num_output; > drm_connector_attach_encoder(&qxl_output->base, > &qxl_output->enc); > - drm_encoder_helper_add(encoder, &qxl_enc_helper_funcs); > drm_connector_helper_add(connector, &qxl_connector_helper_funcs); > > drm_object_attach_property(&connector->base, > -- > 2.25.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C3F3C11D0C for ; Thu, 20 Feb 2020 19:10:52 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 67C4A206E2 for ; Thu, 20 Feb 2020 19:10:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 67C4A206E2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C6EFB6EE4E; Thu, 20 Feb 2020 19:10:51 +0000 (UTC) Received: from asavdk4.altibox.net (asavdk4.altibox.net [109.247.116.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id A53D16EE4E; Thu, 20 Feb 2020 19:10:50 +0000 (UTC) Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id 585E580A88; Thu, 20 Feb 2020 20:10:48 +0100 (CET) Date: Thu, 20 Feb 2020 20:10:47 +0100 From: Sam Ravnborg To: Thomas Zimmermann Subject: Re: [PATCH v2 4/4] drm/qxl: Use simple encoder Message-ID: <20200220191047.GC20011@ravnborg.org> References: <20200218084815.2137-1-tzimmermann@suse.de> <20200218084815.2137-5-tzimmermann@suse.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200218084815.2137-5-tzimmermann@suse.de> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=XpTUx2N9 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=7gkXJVJtAAAA:8 a=wMNakxb3kf32nlJXWIsA:9 a=dtiwrycrY4r5epML:21 a=rIm5waDK4KQ2vjO9:21 a=CjuIK1q_8ugA:10 a=E9Po1WZjFZOl8hwRPBS3:22 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: airlied@linux.ie, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, kraxel@redhat.com, alexander.deucher@amd.com, spice-devel@lists.freedesktop.org, emil.velikov@collabora.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Thomas. On Tue, Feb 18, 2020 at 09:48:15AM +0100, Thomas Zimmermann wrote: > The qxl driver uses an empty implementation for its encoder. Replace > the code with the generic simple encoder. > > v2: > * rebase onto new simple-encoder interface > > Signed-off-by: Thomas Zimmermann I looked at best_encoder - but could not see we could do anything. So from browsing the code: Acked-by: Sam Ravnborg Sam > --- > drivers/gpu/drm/qxl/qxl_display.c | 18 +++--------------- > 1 file changed, 3 insertions(+), 15 deletions(-) > > diff --git a/drivers/gpu/drm/qxl/qxl_display.c b/drivers/gpu/drm/qxl/qxl_display.c > index ab4f8dd00400..9c0e1add59fb 100644 > --- a/drivers/gpu/drm/qxl/qxl_display.c > +++ b/drivers/gpu/drm/qxl/qxl_display.c > @@ -31,6 +31,7 @@ > #include > #include > #include > +#include > > #include "qxl_drv.h" > #include "qxl_object.h" > @@ -1007,9 +1008,6 @@ static struct drm_encoder *qxl_best_encoder(struct drm_connector *connector) > return &qxl_output->enc; > } > > -static const struct drm_encoder_helper_funcs qxl_enc_helper_funcs = { > -}; > - > static const struct drm_connector_helper_funcs qxl_connector_helper_funcs = { > .get_modes = qxl_conn_get_modes, > .mode_valid = qxl_conn_mode_valid, > @@ -1059,15 +1057,6 @@ static const struct drm_connector_funcs qxl_connector_funcs = { > .atomic_destroy_state = drm_atomic_helper_connector_destroy_state, > }; > > -static void qxl_enc_destroy(struct drm_encoder *encoder) > -{ > - drm_encoder_cleanup(encoder); > -} > - > -static const struct drm_encoder_funcs qxl_enc_funcs = { > - .destroy = qxl_enc_destroy, > -}; > - > static int qxl_mode_create_hotplug_mode_update_property(struct qxl_device *qdev) > { > if (qdev->hotplug_mode_update_property) > @@ -1098,15 +1087,14 @@ static int qdev_output_init(struct drm_device *dev, int num_output) > drm_connector_init(dev, &qxl_output->base, > &qxl_connector_funcs, DRM_MODE_CONNECTOR_VIRTUAL); > > - drm_encoder_init(dev, &qxl_output->enc, &qxl_enc_funcs, > - DRM_MODE_ENCODER_VIRTUAL, NULL); > + drm_simple_encoder_init(dev, &qxl_output->enc, > + DRM_MODE_ENCODER_VIRTUAL); > > /* we get HPD via client monitors config */ > connector->polled = DRM_CONNECTOR_POLL_HPD; > encoder->possible_crtcs = 1 << num_output; > drm_connector_attach_encoder(&qxl_output->base, > &qxl_output->enc); > - drm_encoder_helper_add(encoder, &qxl_enc_helper_funcs); > drm_connector_helper_add(connector, &qxl_connector_helper_funcs); > > drm_object_attach_property(&connector->base, > -- > 2.25.0 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel