From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 781F2C11D0C for ; Thu, 20 Feb 2020 19:19:04 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 01163206E2 for ; Thu, 20 Feb 2020 19:19:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="bTuAnK4R" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 01163206E2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 51BE116A3; Thu, 20 Feb 2020 20:18:12 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 51BE116A3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1582226342; bh=fYWUmFhvIZEW7EE1tT9DCfw4pyvNRhmVwpwmcFItVpM=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=bTuAnK4R1p6KGtZM8w0GwBe0Gq6Ma0SSKoadXmsIsA7RKjZlqii6VTJcd5tSLb9g5 p0wOCZFjYPpRGeb5IrqbJZ68KtAoeZCzyZu9h6NAZkMje5ySMECfCcZJjK+H+2Dcni XST+xabal42U328PC8QmsMNoIWrzvCV9xBA5pz/s= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id BB7F3F80145; Thu, 20 Feb 2020 20:18:11 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 3C229F80148; Thu, 20 Feb 2020 20:18:10 +0100 (CET) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by alsa1.perex.cz (Postfix) with ESMTP id 39DD0F80101 for ; Thu, 20 Feb 2020 20:18:06 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 39DD0F80101 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 474ED30E; Thu, 20 Feb 2020 11:18:05 -0800 (PST) Received: from localhost (unknown [10.37.6.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id ACD463F6CF; Thu, 20 Feb 2020 11:18:04 -0800 (PST) Date: Thu, 20 Feb 2020 19:18:03 +0000 From: Mark Brown To: Dan Murphy Subject: Re: [PATCH] ASoC: tas2562: Add support for digital volume control Message-ID: <20200220191803.GH3926@sirena.org.uk> References: <20200220172721.10547-1-dmurphy@ti.com> <20200220184507.GF3926@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="jRdC2OsRnuV8iIl8" Content-Disposition: inline In-Reply-To: X-Cookie: You are number 6! Who is number one? User-Agent: Mutt/1.10.1 (2018-07-13) Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, tiwai@suse.com, lgirdwood@gmail.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" --jRdC2OsRnuV8iIl8 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Feb 20, 2020 at 12:46:57PM -0600, Dan Murphy wrote: > On 2/20/20 12:45 PM, Mark Brown wrote: > > Is there a reason not to use the chip default here? Otherwise this > > looks good. > Chip default is set to 0dB full blast+ 0x40400000.=A0 This sets the volum= e to > -110dB. OK... that's a policy decision the same as all other volume changes and so shouldn't be done by the driver - as ever we don't know how the system is set up and what values make sense and keeping things out of the driver means we don't end up with competing system integration decisions causing changes in the driver. The system may have an external amplifier they prefer to use for hardware volume control, may prefer to do entirely soft volume control in their sound server or something like that. --jRdC2OsRnuV8iIl8 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl5O22oACgkQJNaLcl1U h9BNnAf/STD8X1meBVMym8n0PChi4jx1nA4QyPkwc1x8USlqaoWsz3QHBi7Q6H37 OG5YcO02ATyyjTe0rCZVKgyQUQ7Bmtw2bWRhNS3KH3HL90f0/kgu4K84i0UJ6psr wfnDq2dItRwnq/EEwburkJom8ZJac9dii3HfF7jsafA1PoWgEdCy2pCY6liTfUNS GzbqXIuXTIG25A6oHG7HE8489gPuC57XRapoGUyQ3gIj+ems8EwEAUkqVIA3symp +6ZO2qTqhA+ArEuOptlxpjVLoNcQfddeJ/jwBZZQtCa2h/cwSVmzcfOorbznBmp9 KshHMzn9Z/sa+dmi0twVgXHv9mtEJQ== =YOPj -----END PGP SIGNATURE----- --jRdC2OsRnuV8iIl8-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51AEDC11D0C for ; Thu, 20 Feb 2020 19:18:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2A557206E2 for ; Thu, 20 Feb 2020 19:18:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582226288; bh=fYWUmFhvIZEW7EE1tT9DCfw4pyvNRhmVwpwmcFItVpM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=L0nnulsxA7DybAgEtgacfKBb0jZ5hV5iXFlJbOPQ+SQNLIkJpTuEPfNyK9HIhz7Jh 851HdnRJhfbb6duf5zHzshT2/otdrvG2V1PHdFdk9oWUbpBWPMUQz8kvpp6O2IhJ3y 4mg0JRd7SfGyq3tCHo5gUQ79qC1B2L6w/SGi4fN4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728701AbgBTTSG (ORCPT ); Thu, 20 Feb 2020 14:18:06 -0500 Received: from foss.arm.com ([217.140.110.172]:49920 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728111AbgBTTSF (ORCPT ); Thu, 20 Feb 2020 14:18:05 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 474ED30E; Thu, 20 Feb 2020 11:18:05 -0800 (PST) Received: from localhost (unknown [10.37.6.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id ACD463F6CF; Thu, 20 Feb 2020 11:18:04 -0800 (PST) Date: Thu, 20 Feb 2020 19:18:03 +0000 From: Mark Brown To: Dan Murphy Cc: lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ASoC: tas2562: Add support for digital volume control Message-ID: <20200220191803.GH3926@sirena.org.uk> References: <20200220172721.10547-1-dmurphy@ti.com> <20200220184507.GF3926@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="jRdC2OsRnuV8iIl8" Content-Disposition: inline In-Reply-To: X-Cookie: You are number 6! Who is number one? User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --jRdC2OsRnuV8iIl8 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Feb 20, 2020 at 12:46:57PM -0600, Dan Murphy wrote: > On 2/20/20 12:45 PM, Mark Brown wrote: > > Is there a reason not to use the chip default here? Otherwise this > > looks good. > Chip default is set to 0dB full blast+ 0x40400000.=A0 This sets the volum= e to > -110dB. OK... that's a policy decision the same as all other volume changes and so shouldn't be done by the driver - as ever we don't know how the system is set up and what values make sense and keeping things out of the driver means we don't end up with competing system integration decisions causing changes in the driver. The system may have an external amplifier they prefer to use for hardware volume control, may prefer to do entirely soft volume control in their sound server or something like that. --jRdC2OsRnuV8iIl8 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl5O22oACgkQJNaLcl1U h9BNnAf/STD8X1meBVMym8n0PChi4jx1nA4QyPkwc1x8USlqaoWsz3QHBi7Q6H37 OG5YcO02ATyyjTe0rCZVKgyQUQ7Bmtw2bWRhNS3KH3HL90f0/kgu4K84i0UJ6psr wfnDq2dItRwnq/EEwburkJom8ZJac9dii3HfF7jsafA1PoWgEdCy2pCY6liTfUNS GzbqXIuXTIG25A6oHG7HE8489gPuC57XRapoGUyQ3gIj+ems8EwEAUkqVIA3symp +6ZO2qTqhA+ArEuOptlxpjVLoNcQfddeJ/jwBZZQtCa2h/cwSVmzcfOorbznBmp9 KshHMzn9Z/sa+dmi0twVgXHv9mtEJQ== =YOPj -----END PGP SIGNATURE----- --jRdC2OsRnuV8iIl8--