From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EE29C11D0C for ; Thu, 20 Feb 2020 19:51:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9CC18206F4 for ; Thu, 20 Feb 2020 19:51:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="nFJN6yiD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9CC18206F4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=646w552DPwS3DnRM6PqCcah5aPsB+zTQaC1lNrTjZ7g=; b=nFJN6yiDjKS7J6EbuyJ9rJmEB Fs+6Dto7rP0FM1FjKQwARL2EDbFWhfRpbORdhUwfdUHY1Fsk3JVmZa6HarZBJu+q55SGRfUr4bqEn H1PSp1bnn8kmQqGDywvY56FVVID91VmW8/uM4MtjRv976WGZvHMMYiGg1gm13JNyxBZZPickI+haH emjSZZgU0IL9ImEiaOWipjtA2NgVN2UoqtwI5mIxGkCULDKF3jgpcLfkJwO9zLpabObJkLeh+qPAQ 5E2fOA3WSvPkvEzHIU/EJtmKItotBk6uS6rTRjgXyHVO6vlpUJt+TwYdT+R+W3f21BYn3rphOBNsB lBt4Qwykg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j4rrK-00079t-BW; Thu, 20 Feb 2020 19:51:42 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j4rr6-000705-HR; Thu, 20 Feb 2020 19:51:29 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D90DF30E; Thu, 20 Feb 2020 11:51:24 -0800 (PST) Received: from localhost (unknown [10.37.6.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4EF083F68F; Thu, 20 Feb 2020 11:51:24 -0800 (PST) Date: Thu, 20 Feb 2020 19:51:22 +0000 From: Mark Brown To: Chuanhong Guo Subject: Re: [PATCH 0/2] rewrite mtk-quadspi spi-nor driver with spi-mem Message-ID: <20200220195122.GL3926@sirena.org.uk> References: <20200215065826.739102-1-gch981213@gmail.com> <20200218125557.GD4232@sirena.org.uk> MIME-Version: 1.0 In-Reply-To: X-Cookie: You are number 6! Who is number one? User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200220_115128_644900_C06B4E4C X-CRM114-Status: GOOD ( 12.00 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Vignesh Raghavendra , Richard Weinberger , open list , linux-spi@vger.kernel.org, Rob Herring , linux-mtd@lists.infradead.org, Miquel Raynal , Matthias Brugger , linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============8942959205673169643==" Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org --===============8942959205673169643== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="kaF1vgn83Aa7CiXN" Content-Disposition: inline --kaF1vgn83Aa7CiXN Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Feb 20, 2020 at 07:58:06AM +0800, Chuanhong Guo wrote: > On Tue, Feb 18, 2020 at 8:55 PM Mark Brown wrote: > > This is an ABI break so you shouldn't be doing this, if the existing > > binding works it should continue to work. > The missing spi-max-frequency is the only part preventing old > device tree to work with this driver. > If the goal is to make existing dt binding work, I could patch dt using > of_add_property in v2. I saw similar device tree patching for legacy > bindings in pinctrl-single driver. That's fine I think, so long as old DTs continue to work. --kaF1vgn83Aa7CiXN Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl5O4zkACgkQJNaLcl1U h9CnhQf/csTFVBvPtYuq5Xz1OdgQcpPuRzKFr7JAXvgpfAUv5qPV/34M4juJxze6 ei2b2s9UlxK2Naa8GFKqAEKOK79jnk5HrI7QkELb2UpQPSJQKubjc8iHzDsQ8rgC V7Qf/2Lv2J/NW4R2XzC0ZXMeSnEMBQepx/pUCQnwXOqReWiy/l2X7pLEJsI4J4pR ba9BzEWWAXYoP4SYj/cVlqhWrBh807h6owmwTlV86VrwRRh2cxosTUZVMx6nRNq6 MBFLZ/vayfFd9LF7BQ5r2isKv+BUrZZ8bd06Gt8vZrrLBoH4YiGhXDLL3CGWvFhk 6M/bBGLDrkTKwSBb6zMaLOsygszigQ== =rZ8a -----END PGP SIGNATURE----- --kaF1vgn83Aa7CiXN-- --===============8942959205673169643== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek --===============8942959205673169643==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A07A9C11D1B for ; Thu, 20 Feb 2020 19:52:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 75DC4206F4 for ; Thu, 20 Feb 2020 19:52:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="VfM82+oG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 75DC4206F4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=nmgSQBh+jvFi72aRI9NzdhsAVCzMXoE+p7AviY7Q+q4=; b=VfM82+oGCvu+Y1oihI28szx81 3F69g+SqaIkA2r6igImu/Gw5RrFJoyEOSz+/r6aCn7JnwpQo27NkCrsyU+SoCz7GwCxVJMwhN7yrw Ku/FO9QAIbbmhtawtaA+XiYn9LPh4kyNSNvYYWV0HkCZuO2GpeQxmtUCzR482SBEoMX10JtcMoan2 Bjo+5WFXtfKvuGhttGY1shsHMzfOnkQ3tvMtFj6z13Wsh4V1i++Pf7PLdbbjx5YzfeEW+Lc+dagOE vU1xcthEnKfway0/55Si8p8nzCVc/pERa54I4QE9+3CCyH43dTqfbKe78NQ6fbXKM/LGgQ4hdn+I4 hvRCg2yLg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j4rrM-0007CA-Nj; Thu, 20 Feb 2020 19:51:44 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j4rr6-000705-HR; Thu, 20 Feb 2020 19:51:29 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D90DF30E; Thu, 20 Feb 2020 11:51:24 -0800 (PST) Received: from localhost (unknown [10.37.6.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4EF083F68F; Thu, 20 Feb 2020 11:51:24 -0800 (PST) Date: Thu, 20 Feb 2020 19:51:22 +0000 From: Mark Brown To: Chuanhong Guo Subject: Re: [PATCH 0/2] rewrite mtk-quadspi spi-nor driver with spi-mem Message-ID: <20200220195122.GL3926@sirena.org.uk> References: <20200215065826.739102-1-gch981213@gmail.com> <20200218125557.GD4232@sirena.org.uk> MIME-Version: 1.0 In-Reply-To: X-Cookie: You are number 6! Who is number one? User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200220_115128_644900_C06B4E4C X-CRM114-Status: GOOD ( 12.00 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Vignesh Raghavendra , Richard Weinberger , open list , linux-spi@vger.kernel.org, Rob Herring , linux-mtd@lists.infradead.org, Miquel Raynal , Matthias Brugger , linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============2387073767933911277==" Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org --===============2387073767933911277== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="kaF1vgn83Aa7CiXN" Content-Disposition: inline --kaF1vgn83Aa7CiXN Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Feb 20, 2020 at 07:58:06AM +0800, Chuanhong Guo wrote: > On Tue, Feb 18, 2020 at 8:55 PM Mark Brown wrote: > > This is an ABI break so you shouldn't be doing this, if the existing > > binding works it should continue to work. > The missing spi-max-frequency is the only part preventing old > device tree to work with this driver. > If the goal is to make existing dt binding work, I could patch dt using > of_add_property in v2. I saw similar device tree patching for legacy > bindings in pinctrl-single driver. That's fine I think, so long as old DTs continue to work. --kaF1vgn83Aa7CiXN Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl5O4zkACgkQJNaLcl1U h9CnhQf/csTFVBvPtYuq5Xz1OdgQcpPuRzKFr7JAXvgpfAUv5qPV/34M4juJxze6 ei2b2s9UlxK2Naa8GFKqAEKOK79jnk5HrI7QkELb2UpQPSJQKubjc8iHzDsQ8rgC V7Qf/2Lv2J/NW4R2XzC0ZXMeSnEMBQepx/pUCQnwXOqReWiy/l2X7pLEJsI4J4pR ba9BzEWWAXYoP4SYj/cVlqhWrBh807h6owmwTlV86VrwRRh2cxosTUZVMx6nRNq6 MBFLZ/vayfFd9LF7BQ5r2isKv+BUrZZ8bd06Gt8vZrrLBoH4YiGhXDLL3CGWvFhk 6M/bBGLDrkTKwSBb6zMaLOsygszigQ== =rZ8a -----END PGP SIGNATURE----- --kaF1vgn83Aa7CiXN-- --===============2387073767933911277== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ --===============2387073767933911277==-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH 0/2] rewrite mtk-quadspi spi-nor driver with spi-mem Date: Thu, 20 Feb 2020 19:51:22 +0000 Message-ID: <20200220195122.GL3926@sirena.org.uk> References: <20200215065826.739102-1-gch981213@gmail.com> <20200218125557.GD4232@sirena.org.uk> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="kaF1vgn83Aa7CiXN" Cc: linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Rob Herring , Mark Rutland , Matthias Brugger , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, open list To: Chuanhong Guo Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-spi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: --kaF1vgn83Aa7CiXN Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Feb 20, 2020 at 07:58:06AM +0800, Chuanhong Guo wrote: > On Tue, Feb 18, 2020 at 8:55 PM Mark Brown wrote: > > This is an ABI break so you shouldn't be doing this, if the existing > > binding works it should continue to work. > The missing spi-max-frequency is the only part preventing old > device tree to work with this driver. > If the goal is to make existing dt binding work, I could patch dt using > of_add_property in v2. I saw similar device tree patching for legacy > bindings in pinctrl-single driver. That's fine I think, so long as old DTs continue to work. --kaF1vgn83Aa7CiXN Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl5O4zkACgkQJNaLcl1U h9CnhQf/csTFVBvPtYuq5Xz1OdgQcpPuRzKFr7JAXvgpfAUv5qPV/34M4juJxze6 ei2b2s9UlxK2Naa8GFKqAEKOK79jnk5HrI7QkELb2UpQPSJQKubjc8iHzDsQ8rgC V7Qf/2Lv2J/NW4R2XzC0ZXMeSnEMBQepx/pUCQnwXOqReWiy/l2X7pLEJsI4J4pR ba9BzEWWAXYoP4SYj/cVlqhWrBh807h6owmwTlV86VrwRRh2cxosTUZVMx6nRNq6 MBFLZ/vayfFd9LF7BQ5r2isKv+BUrZZ8bd06Gt8vZrrLBoH4YiGhXDLL3CGWvFhk 6M/bBGLDrkTKwSBb6zMaLOsygszigQ== =rZ8a -----END PGP SIGNATURE----- --kaF1vgn83Aa7CiXN-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C9E3C11D0C for ; Thu, 20 Feb 2020 19:51:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 663A1206E2 for ; Thu, 20 Feb 2020 19:51:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="A9ly86uW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 663A1206E2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=vttw01FdM6qJKcN8w5GaqwOAZYGU+ulutt7CuyY2P50=; b=A9ly86uWXbV+ZGrBHluN2xz2E CiNnqP58fDd/LDp2HweOT0fHzokqki3seu0R3csEq+C+KfRq7r/WtetvCHQe4nXmKCl+XLBc4JpjU aox4fKPQb4pkIpj8rRUf0y9hiGZSguigFkxBSQo/jRliF47193C4JHNtiy7jql6YS8mRIAkdpLZ55 G1m3snaW/LDgl88Ozh4rb5HSyXEJnVn/TsRdpuJ7x9nG7EdlGhLHVH0X6Kozclptqb8YWz9ypHxsg 91L8oHxzYvVfKLzjd7PYSriPfZdE5QsLGlrcOddlhx3hrGaYbdsomSz8dNbxwjsqqODpuRt+wz2zs BwWilk/aQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j4rrB-000719-C7; Thu, 20 Feb 2020 19:51:33 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j4rr6-000705-HR; Thu, 20 Feb 2020 19:51:29 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D90DF30E; Thu, 20 Feb 2020 11:51:24 -0800 (PST) Received: from localhost (unknown [10.37.6.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4EF083F68F; Thu, 20 Feb 2020 11:51:24 -0800 (PST) Date: Thu, 20 Feb 2020 19:51:22 +0000 From: Mark Brown To: Chuanhong Guo Subject: Re: [PATCH 0/2] rewrite mtk-quadspi spi-nor driver with spi-mem Message-ID: <20200220195122.GL3926@sirena.org.uk> References: <20200215065826.739102-1-gch981213@gmail.com> <20200218125557.GD4232@sirena.org.uk> MIME-Version: 1.0 In-Reply-To: X-Cookie: You are number 6! Who is number one? User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200220_115128_644900_C06B4E4C X-CRM114-Status: GOOD ( 12.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Vignesh Raghavendra , Richard Weinberger , open list , linux-spi@vger.kernel.org, Rob Herring , linux-mtd@lists.infradead.org, Miquel Raynal , Matthias Brugger , linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============5876605383312021416==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============5876605383312021416== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="kaF1vgn83Aa7CiXN" Content-Disposition: inline --kaF1vgn83Aa7CiXN Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Feb 20, 2020 at 07:58:06AM +0800, Chuanhong Guo wrote: > On Tue, Feb 18, 2020 at 8:55 PM Mark Brown wrote: > > This is an ABI break so you shouldn't be doing this, if the existing > > binding works it should continue to work. > The missing spi-max-frequency is the only part preventing old > device tree to work with this driver. > If the goal is to make existing dt binding work, I could patch dt using > of_add_property in v2. I saw similar device tree patching for legacy > bindings in pinctrl-single driver. That's fine I think, so long as old DTs continue to work. --kaF1vgn83Aa7CiXN Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl5O4zkACgkQJNaLcl1U h9CnhQf/csTFVBvPtYuq5Xz1OdgQcpPuRzKFr7JAXvgpfAUv5qPV/34M4juJxze6 ei2b2s9UlxK2Naa8GFKqAEKOK79jnk5HrI7QkELb2UpQPSJQKubjc8iHzDsQ8rgC V7Qf/2Lv2J/NW4R2XzC0ZXMeSnEMBQepx/pUCQnwXOqReWiy/l2X7pLEJsI4J4pR ba9BzEWWAXYoP4SYj/cVlqhWrBh807h6owmwTlV86VrwRRh2cxosTUZVMx6nRNq6 MBFLZ/vayfFd9LF7BQ5r2isKv+BUrZZ8bd06Gt8vZrrLBoH4YiGhXDLL3CGWvFhk 6M/bBGLDrkTKwSBb6zMaLOsygszigQ== =rZ8a -----END PGP SIGNATURE----- --kaF1vgn83Aa7CiXN-- --===============5876605383312021416== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============5876605383312021416==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34207C11D0C for ; Thu, 20 Feb 2020 19:51:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0EBF3206F4 for ; Thu, 20 Feb 2020 19:51:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582228289; bh=BZllZP0S6mHq3M1d/mWw0S2QK7ydm/Mjik/9RGjRhL8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=uU8ecHpV7DFOhVGi9l9VyJkcDhdCulax/gsVh1BZRHQutVsWX7KW2bqTJm0wov4f9 j8PiREM2/bpDl0VjQkoVwc9dMVEcG431FSQzLS9FJ51znyM1h4mAoq2NEqdBYS8WJQ Gxkr6xLipr5+JUPP+jxE9iTu5aHfhQYMgbS0rWDw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728966AbgBTTvZ (ORCPT ); Thu, 20 Feb 2020 14:51:25 -0500 Received: from foss.arm.com ([217.140.110.172]:50438 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728514AbgBTTvZ (ORCPT ); Thu, 20 Feb 2020 14:51:25 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D90DF30E; Thu, 20 Feb 2020 11:51:24 -0800 (PST) Received: from localhost (unknown [10.37.6.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4EF083F68F; Thu, 20 Feb 2020 11:51:24 -0800 (PST) Date: Thu, 20 Feb 2020 19:51:22 +0000 From: Mark Brown To: Chuanhong Guo Cc: linux-mediatek@lists.infradead.org, linux-spi@vger.kernel.org, linux-mtd@lists.infradead.org, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Rob Herring , Mark Rutland , Matthias Brugger , linux-arm-kernel@lists.infradead.org, open list Subject: Re: [PATCH 0/2] rewrite mtk-quadspi spi-nor driver with spi-mem Message-ID: <20200220195122.GL3926@sirena.org.uk> References: <20200215065826.739102-1-gch981213@gmail.com> <20200218125557.GD4232@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="kaF1vgn83Aa7CiXN" Content-Disposition: inline In-Reply-To: X-Cookie: You are number 6! Who is number one? User-Agent: Mutt/1.10.1 (2018-07-13) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org --kaF1vgn83Aa7CiXN Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Feb 20, 2020 at 07:58:06AM +0800, Chuanhong Guo wrote: > On Tue, Feb 18, 2020 at 8:55 PM Mark Brown wrote: > > This is an ABI break so you shouldn't be doing this, if the existing > > binding works it should continue to work. > The missing spi-max-frequency is the only part preventing old > device tree to work with this driver. > If the goal is to make existing dt binding work, I could patch dt using > of_add_property in v2. I saw similar device tree patching for legacy > bindings in pinctrl-single driver. That's fine I think, so long as old DTs continue to work. --kaF1vgn83Aa7CiXN Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl5O4zkACgkQJNaLcl1U h9CnhQf/csTFVBvPtYuq5Xz1OdgQcpPuRzKFr7JAXvgpfAUv5qPV/34M4juJxze6 ei2b2s9UlxK2Naa8GFKqAEKOK79jnk5HrI7QkELb2UpQPSJQKubjc8iHzDsQ8rgC V7Qf/2Lv2J/NW4R2XzC0ZXMeSnEMBQepx/pUCQnwXOqReWiy/l2X7pLEJsI4J4pR ba9BzEWWAXYoP4SYj/cVlqhWrBh807h6owmwTlV86VrwRRh2cxosTUZVMx6nRNq6 MBFLZ/vayfFd9LF7BQ5r2isKv+BUrZZ8bd06Gt8vZrrLBoH4YiGhXDLL3CGWvFhk 6M/bBGLDrkTKwSBb6zMaLOsygszigQ== =rZ8a -----END PGP SIGNATURE----- --kaF1vgn83Aa7CiXN--