From: Florian Westphal <fw at strlen.de>
To: mptcp at lists.01.org
Subject: [MPTCP] Re: [PATCH v3 0/6] mptcp: update mptcp ack sequence from work queue
Date: Fri, 21 Feb 2020 00:23:32 +0100 [thread overview]
Message-ID: <20200220232332.GN19559@breakpoint.cc> (raw)
In-Reply-To: 20200220143426.28626-1-fw@strlen.de
[-- Attachment #1: Type: text/plain, Size: 1313 bytes --]
Florian Westphal <fw(a)strlen.de> wrote:
> V3. No changes since v2, I only updated commit messages in
> patches 1, 2, 3 and 6.
>
> I think we should try to avoid needless squashing and keep
> these as-is for now. We can always condense some of this later
> on in case we need to reduce number of individual patches for some
> reason.
As per yesterdays meeting, I've rebased this on top of net-next:
https://git.breakpoint.cc/cgit/fw/net-next.git/log/?h=mptcp_ssk_drain_01
Paolo, I extracted the parts that add the work queue from your retrans
patch, I renamed the work queue because 'rtx_work' doesn't makse
sense if its not related to retransmits.
The patch is rather tiny so I wonder if it should be merged with the
main patch (mptcp: update mptcp ack sequence from work queue).
Let me know.
Also, I would propose to drop
"mptcp: protocol: re-check dsn before reading from subflow" before
sending this to netdev since that patch isn't related to the rest
of the patches.
It should probably be part of the batch after this, at the latest
it needs to go in when MP_JOIN support is added.
WDYT?
I can't post it to netdev yet anyway because I need to wait for
net -> net-next merge to avoid a small conflict in protocol.h, so
you can take your time with reviewing this.
next reply other threads:[~2020-02-20 23:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 23:23 Florian Westphal [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-02-19 15:16 [MPTCP] Re: [PATCH v3 0/6] mptcp: update mptcp ack sequence from work queue Paolo Abeni
2020-02-19 12:43 Florian Westphal
2020-02-19 12:36 Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200220232332.GN19559@breakpoint.cc \
--to=unknown@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.