From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a19:cb43:0:0:0:0:0 with SMTP id b64csp1527902lfg; Fri, 21 Feb 2020 00:39:05 -0800 (PST) X-Google-Smtp-Source: APXvYqy288v9oJyCHjKE/iA6Pc+KyRN413Vjcir2ZkYarLbec9Ay9VnQgV83Xebq100KsTNoZ6Bs X-Received: by 2002:a05:6808:45:: with SMTP id v5mr1033179oic.90.1582274345658; Fri, 21 Feb 2020 00:39:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582274345; cv=none; d=google.com; s=arc-20160816; b=Cn/JPFGUg2gfrjfSs7xVoDPrFpzJa9huVJyJOHhqsFnNrnHDi0JsbgDK+XiZcyLlLI ravznnLy3tcYLMroDQcCVxszjczF7RZTjEb4iG4Ab+zJGfasHndjHo5CCZ7k8vTmvEGF CE7vpN9c8SiUtpS0cExNOJ+T752yIvOKzbX9eaoGfB1KgqZ20fAJyYR48ft+lRBGn+RE 6aN+fyTVsNzofiL9tgeK5zY2ivz3EbCNcdgShSrToxidxPh2JdBEkOWptM8vSC+vuHcd sQrgTJS7SHAT1mKgKABFK/L4WOw4MLmElWnKbfJ3GrmBsjh1CcK4JJN2hJpn9aur6zx/ vNjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date:dkim-signature; bh=+jKPj3gf+T3ocOqgvJULo7PhApveqgiAwsnEtaSBAEQ=; b=pBNjPoNEeBetirPg3EI5OgbJ2YZU8dfj+On8T56tUcZMVng+v9aba/T2zmwMpT6jsI gNenFXS8/DFq9vFuraZz6t/0gUHzvIL1/Ig7kx69kA73QaF3B91neChUXlIY1ORCUd8q +nnEE1fIJ/UehY5c1Lxs22HXQvfViR83qFu4MsF0t0v6IGEeU8LiY3FyLO0y5EtAy0Gy MhbFlaV3C7VGcH28ZHCkPnxfTzSsN+tZijtheT+EL0TUHZXW+TCDaMH2Ak5hzhEsT8oi L21j5p71R4+uVDmLmHL83+SucQHxZAye4VDHEiLI/7qlZknVCh8LhXFvLuIUyluvSDBj 8O5Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=e+q+v9FY; spf=pass (google.com: best guess record for domain of kvm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=kvm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m26si1127895otr.159.2020.02.21.00.39.05; Fri, 21 Feb 2020 00:39:05 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of kvm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=e+q+v9FY; spf=pass (google.com: best guess record for domain of kvm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=kvm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731260AbgBUIjE (ORCPT + 5 others); Fri, 21 Feb 2020 03:39:04 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:30059 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1730014AbgBUIjC (ORCPT ); Fri, 21 Feb 2020 03:39:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582274341; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+jKPj3gf+T3ocOqgvJULo7PhApveqgiAwsnEtaSBAEQ=; b=e+q+v9FYiHBMDN9wgzsZpOa3UtSZDBM7LtPy2K5kxuriFeAtmhR+4jVNDL2IiJKwlHHtQ0 juP26Iv2eaV1qRklmE6iso7BC2xBdSH2AF/k+zKM6fu0mHrzx22ATRtpzsZamfHr+7WBx1 IT7YpkSlrN015YEQfOhKWkNmvG4O2zY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-244-icepWPbFPbqSoFkIU1jjaA-1; Fri, 21 Feb 2020 03:38:59 -0500 X-MC-Unique: icepWPbFPbqSoFkIU1jjaA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E7A62800D50; Fri, 21 Feb 2020 08:38:55 +0000 (UTC) Received: from gondolin (ovpn-117-64.ams2.redhat.com [10.36.117.64]) by smtp.corp.redhat.com (Postfix) with ESMTP id DE7D75D9E2; Fri, 21 Feb 2020 08:38:33 +0000 (UTC) Date: Fri, 21 Feb 2020 09:38:30 +0100 From: Cornelia Huck To: Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= Cc: Peter Maydell , qemu-devel@nongnu.org, "Edgar E. Iglesias" , Anthony Perard , Fam Zheng , =?UTF-8?B?SGVy?= =?UTF-8?B?dsOp?= Poussineau , kvm@vger.kernel.org, Laurent Vivier , Thomas Huth , Stefan Weil , Eric Auger , Halil Pasic , Marcel Apfelbaum , qemu-s390x@nongnu.org, Aleksandar Rikalo , David Gibson , Michael Walle , qemu-ppc@nongnu.org, Gerd Hoffmann , qemu-arm@nongnu.org, Alistair Francis , qemu-block@nongnu.org, =?UTF-8?B?Q8OpZHJpYw==?= Le Goater , Jason Wang , xen-devel@lists.xenproject.org, Christian Borntraeger , Dmitry Fleytman , Matthew Rosato , Eduardo Habkost , Richard Henderson , "Michael S. Tsirkin" , David Hildenbrand , Paolo Bonzini , Stefano Stabellini , Igor Mitsyanko , Paul Durrant , Richard Henderson , John Snow Subject: Re: [PATCH v3 08/20] Remove unnecessary cast when using the address_space API Message-ID: <20200221093830.63bc308e.cohuck@redhat.com> In-Reply-To: <20200220130548.29974-9-philmd@redhat.com> References: <20200220130548.29974-1-philmd@redhat.com> <20200220130548.29974-9-philmd@redhat.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org X-TUID: 0Zxn8hYEzNfZ On Thu, 20 Feb 2020 14:05:36 +0100 Philippe Mathieu-Daud=C3=A9 wrote: > This commit was produced with the included Coccinelle script > scripts/coccinelle/exec_rw_const. >=20 > Two lines in hw/net/dp8393x.c that Coccinelle produced that > were over 80 characters were re-wrapped by hand. >=20 > Suggested-by: Stefan Weil > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > --- > scripts/coccinelle/exec_rw_const.cocci | 15 +++++++++++++- > target/i386/hvf/vmx.h | 2 +- > hw/arm/boot.c | 6 ++---- > hw/dma/rc4030.c | 4 ++-- > hw/dma/xlnx-zdma.c | 2 +- > hw/net/cadence_gem.c | 21 +++++++++---------- > hw/net/dp8393x.c | 28 +++++++++++++------------- > hw/s390x/css.c | 4 ++-- > qtest.c | 12 +++++------ > target/i386/hvf/x86_mmu.c | 2 +- > target/i386/whpx-all.c | 2 +- > target/s390x/mmu_helper.c | 2 +- > 12 files changed, 54 insertions(+), 46 deletions(-) >=20 > diff --git a/hw/s390x/css.c b/hw/s390x/css.c > index 844caab408..f27f8c45a5 100644 > --- a/hw/s390x/css.c > +++ b/hw/s390x/css.c > @@ -875,7 +875,7 @@ static inline int ida_read_next_idaw(CcwDataStream *c= ds) > return -EINVAL; /* channel program check */ > } > ret =3D address_space_rw(&address_space_memory, idaw_addr, > - MEMTXATTRS_UNSPECIFIED, (void *) &idaw.fm= t2, > + MEMTXATTRS_UNSPECIFIED, &idaw.fmt2, > sizeof(idaw.fmt2), false); > cds->cda =3D be64_to_cpu(idaw.fmt2); > } else { > @@ -884,7 +884,7 @@ static inline int ida_read_next_idaw(CcwDataStream *c= ds) > return -EINVAL; /* channel program check */ > } > ret =3D address_space_rw(&address_space_memory, idaw_addr, > - MEMTXATTRS_UNSPECIFIED, (void *) &idaw.fm= t1, > + MEMTXATTRS_UNSPECIFIED, &idaw.fmt1, > sizeof(idaw.fmt1), false); > cds->cda =3D be64_to_cpu(idaw.fmt1); > if (cds->cda & 0x80000000) { > diff --git a/target/s390x/mmu_helper.c b/target/s390x/mmu_helper.c > index c9f3f34750..0be2f300bb 100644 > --- a/target/s390x/mmu_helper.c > +++ b/target/s390x/mmu_helper.c > @@ -106,7 +106,7 @@ static inline bool read_table_entry(CPUS390XState *en= v, hwaddr gaddr, > * We treat them as absolute addresses and don't wrap them. > */ > if (unlikely(address_space_read(cs->as, gaddr, MEMTXATTRS_UNSPECIFIE= D, > - (uint8_t *)entry, sizeof(*entry)) != =3D > + entry, sizeof(*entry)) !=3D > MEMTX_OK)) { > return false; > } s390 parts Acked-by: Cornelia Huck From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62EC6C35640 for ; Fri, 21 Feb 2020 08:39:39 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 353072073A for ; Fri, 21 Feb 2020 08:39:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="e+q+v9FY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 353072073A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1j53pv-0004J0-DY; Fri, 21 Feb 2020 08:39:03 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1j53pt-0004Iv-So for xen-devel@lists.xenproject.org; Fri, 21 Feb 2020 08:39:02 +0000 X-Inumbo-ID: 9bf21fc8-5485-11ea-bc8e-bc764e2007e4 Received: from us-smtp-delivery-1.mimecast.com (unknown [205.139.110.120]) by us1-rack-iad1.inumbo.com (Halon) with ESMTP id 9bf21fc8-5485-11ea-bc8e-bc764e2007e4; Fri, 21 Feb 2020 08:39:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582274341; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+jKPj3gf+T3ocOqgvJULo7PhApveqgiAwsnEtaSBAEQ=; b=e+q+v9FYiHBMDN9wgzsZpOa3UtSZDBM7LtPy2K5kxuriFeAtmhR+4jVNDL2IiJKwlHHtQ0 juP26Iv2eaV1qRklmE6iso7BC2xBdSH2AF/k+zKM6fu0mHrzx22ATRtpzsZamfHr+7WBx1 IT7YpkSlrN015YEQfOhKWkNmvG4O2zY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-244-icepWPbFPbqSoFkIU1jjaA-1; Fri, 21 Feb 2020 03:38:59 -0500 X-MC-Unique: icepWPbFPbqSoFkIU1jjaA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E7A62800D50; Fri, 21 Feb 2020 08:38:55 +0000 (UTC) Received: from gondolin (ovpn-117-64.ams2.redhat.com [10.36.117.64]) by smtp.corp.redhat.com (Postfix) with ESMTP id DE7D75D9E2; Fri, 21 Feb 2020 08:38:33 +0000 (UTC) Date: Fri, 21 Feb 2020 09:38:30 +0100 From: Cornelia Huck To: Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= Message-ID: <20200221093830.63bc308e.cohuck@redhat.com> In-Reply-To: <20200220130548.29974-9-philmd@redhat.com> References: <20200220130548.29974-1-philmd@redhat.com> <20200220130548.29974-9-philmd@redhat.com> Organization: Red Hat GmbH MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Subject: Re: [Xen-devel] [PATCH v3 08/20] Remove unnecessary cast when using the address_space API X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Peter Maydell , Dmitry Fleytman , kvm@vger.kernel.org, "Michael S. Tsirkin" , Jason Wang , qemu-devel@nongnu.org, Gerd Hoffmann , "Edgar E. Iglesias" , Stefano Stabellini , Matthew Rosato , qemu-block@nongnu.org, David Hildenbrand , Halil Pasic , Christian Borntraeger , =?UTF-8?B?SGVy?= =?UTF-8?B?dsOp?= Poussineau , Marcel Apfelbaum , Anthony Perard , xen-devel@lists.xenproject.org, Aleksandar Rikalo , Richard Henderson , Laurent Vivier , Thomas Huth , Eduardo Habkost , Stefan Weil , Alistair Francis , Richard Henderson , Paul Durrant , Eric Auger , qemu-s390x@nongnu.org, qemu-arm@nongnu.org, =?UTF-8?B?Q8OpZHJpYw==?= Le Goater , John Snow , David Gibson , Igor Mitsyanko , Michael Walle , qemu-ppc@nongnu.org, Paolo Bonzini Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" T24gVGh1LCAyMCBGZWIgMjAyMCAxNDowNTozNiArMDEwMApQaGlsaXBwZSBNYXRoaWV1LURhdWTD qSA8cGhpbG1kQHJlZGhhdC5jb20+IHdyb3RlOgoKPiBUaGlzIGNvbW1pdCB3YXMgcHJvZHVjZWQg d2l0aCB0aGUgaW5jbHVkZWQgQ29jY2luZWxsZSBzY3JpcHQKPiBzY3JpcHRzL2NvY2NpbmVsbGUv ZXhlY19yd19jb25zdC4KPiAKPiBUd28gbGluZXMgaW4gaHcvbmV0L2RwODM5M3guYyB0aGF0IENv Y2NpbmVsbGUgcHJvZHVjZWQgdGhhdAo+IHdlcmUgb3ZlciA4MCBjaGFyYWN0ZXJzIHdlcmUgcmUt d3JhcHBlZCBieSBoYW5kLgo+IAo+IFN1Z2dlc3RlZC1ieTogU3RlZmFuIFdlaWwgPHN3QHdlaWxu ZXR6LmRlPgo+IFNpZ25lZC1vZmYtYnk6IFBoaWxpcHBlIE1hdGhpZXUtRGF1ZMOpIDxwaGlsbWRA cmVkaGF0LmNvbT4KPiAtLS0KPiAgc2NyaXB0cy9jb2NjaW5lbGxlL2V4ZWNfcndfY29uc3QuY29j Y2kgfCAxNSArKysrKysrKysrKysrLQo+ICB0YXJnZXQvaTM4Ni9odmYvdm14LmggICAgICAgICAg ICAgICAgICB8ICAyICstCj4gIGh3L2FybS9ib290LmMgICAgICAgICAgICAgICAgICAgICAgICAg IHwgIDYgKystLS0tCj4gIGh3L2RtYS9yYzQwMzAuYyAgICAgICAgICAgICAgICAgICAgICAgIHwg IDQgKystLQo+ICBody9kbWEveGxueC16ZG1hLmMgICAgICAgICAgICAgICAgICAgICB8ICAyICst Cj4gIGh3L25ldC9jYWRlbmNlX2dlbS5jICAgICAgICAgICAgICAgICAgIHwgMjEgKysrKysrKysr LS0tLS0tLS0tLQo+ICBody9uZXQvZHA4MzkzeC5jICAgICAgICAgICAgICAgICAgICAgICB8IDI4 ICsrKysrKysrKysrKystLS0tLS0tLS0tLS0tCj4gIGh3L3MzOTB4L2Nzcy5jICAgICAgICAgICAg ICAgICAgICAgICAgIHwgIDQgKystLQo+ICBxdGVzdC5jICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICB8IDEyICsrKysrLS0tLS0tCj4gIHRhcmdldC9pMzg2L2h2Zi94ODZfbW11LmMgICAg ICAgICAgICAgIHwgIDIgKy0KPiAgdGFyZ2V0L2kzODYvd2hweC1hbGwuYyAgICAgICAgICAgICAg ICAgfCAgMiArLQo+ICB0YXJnZXQvczM5MHgvbW11X2hlbHBlci5jICAgICAgICAgICAgICB8ICAy ICstCj4gIDEyIGZpbGVzIGNoYW5nZWQsIDU0IGluc2VydGlvbnMoKyksIDQ2IGRlbGV0aW9ucygt KQo+IAoKPiBkaWZmIC0tZ2l0IGEvaHcvczM5MHgvY3NzLmMgYi9ody9zMzkweC9jc3MuYwo+IGlu ZGV4IDg0NGNhYWI0MDguLmYyN2Y4YzQ1YTUgMTAwNjQ0Cj4gLS0tIGEvaHcvczM5MHgvY3NzLmMK PiArKysgYi9ody9zMzkweC9jc3MuYwo+IEBAIC04NzUsNyArODc1LDcgQEAgc3RhdGljIGlubGlu ZSBpbnQgaWRhX3JlYWRfbmV4dF9pZGF3KENjd0RhdGFTdHJlYW0gKmNkcykKPiAgICAgICAgICAg ICAgcmV0dXJuIC1FSU5WQUw7IC8qIGNoYW5uZWwgcHJvZ3JhbSBjaGVjayAqLwo+ICAgICAgICAg IH0KPiAgICAgICAgICByZXQgPSBhZGRyZXNzX3NwYWNlX3J3KCZhZGRyZXNzX3NwYWNlX21lbW9y eSwgaWRhd19hZGRyLAo+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgTUVNVFhBVFRS U19VTlNQRUNJRklFRCwgKHZvaWQgKikgJmlkYXcuZm10MiwKPiArICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIE1FTVRYQVRUUlNfVU5TUEVDSUZJRUQsICZpZGF3LmZtdDIsCj4gICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBzaXplb2YoaWRhdy5mbXQyKSwgZmFsc2UpOwo+ICAg ICAgICAgIGNkcy0+Y2RhID0gYmU2NF90b19jcHUoaWRhdy5mbXQyKTsKPiAgICAgIH0gZWxzZSB7 Cj4gQEAgLTg4NCw3ICs4ODQsNyBAQCBzdGF0aWMgaW5saW5lIGludCBpZGFfcmVhZF9uZXh0X2lk YXcoQ2N3RGF0YVN0cmVhbSAqY2RzKQo+ICAgICAgICAgICAgICByZXR1cm4gLUVJTlZBTDsgLyog Y2hhbm5lbCBwcm9ncmFtIGNoZWNrICovCj4gICAgICAgICAgfQo+ICAgICAgICAgIHJldCA9IGFk ZHJlc3Nfc3BhY2VfcncoJmFkZHJlc3Nfc3BhY2VfbWVtb3J5LCBpZGF3X2FkZHIsCj4gLSAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBNRU1UWEFUVFJTX1VOU1BFQ0lGSUVELCAodm9pZCAq KSAmaWRhdy5mbXQxLAo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgTUVNVFhBVFRS U19VTlNQRUNJRklFRCwgJmlkYXcuZm10MSwKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIHNpemVvZihpZGF3LmZtdDEpLCBmYWxzZSk7Cj4gICAgICAgICAgY2RzLT5jZGEgPSBiZTY0 X3RvX2NwdShpZGF3LmZtdDEpOwo+ICAgICAgICAgIGlmIChjZHMtPmNkYSAmIDB4ODAwMDAwMDAp IHsKCj4gZGlmZiAtLWdpdCBhL3RhcmdldC9zMzkweC9tbXVfaGVscGVyLmMgYi90YXJnZXQvczM5 MHgvbW11X2hlbHBlci5jCj4gaW5kZXggYzlmM2YzNDc1MC4uMGJlMmYzMDBiYiAxMDA2NDQKPiAt LS0gYS90YXJnZXQvczM5MHgvbW11X2hlbHBlci5jCj4gKysrIGIvdGFyZ2V0L3MzOTB4L21tdV9o ZWxwZXIuYwo+IEBAIC0xMDYsNyArMTA2LDcgQEAgc3RhdGljIGlubGluZSBib29sIHJlYWRfdGFi bGVfZW50cnkoQ1BVUzM5MFhTdGF0ZSAqZW52LCBod2FkZHIgZ2FkZHIsCj4gICAgICAgKiBXZSB0 cmVhdCB0aGVtIGFzIGFic29sdXRlIGFkZHJlc3NlcyBhbmQgZG9uJ3Qgd3JhcCB0aGVtLgo+ICAg ICAgICovCj4gICAgICBpZiAodW5saWtlbHkoYWRkcmVzc19zcGFjZV9yZWFkKGNzLT5hcywgZ2Fk ZHIsIE1FTVRYQVRUUlNfVU5TUEVDSUZJRUQsCj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICh1aW50OF90ICopZW50cnksIHNpemVvZigqZW50cnkpKSAhPQo+ICsgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBlbnRyeSwgc2l6ZW9mKCplbnRyeSkpICE9Cj4g ICAgICAgICAgICAgICAgICAgTUVNVFhfT0spKSB7Cj4gICAgICAgICAgcmV0dXJuIGZhbHNlOwo+ ICAgICAgfQoKczM5MCBwYXJ0cwpBY2tlZC1ieTogQ29ybmVsaWEgSHVjayA8Y29odWNrQHJlZGhh dC5jb20+CgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K WGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0 cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DF6EC35641 for ; Fri, 21 Feb 2020 08:39:54 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4DA4A20722 for ; Fri, 21 Feb 2020 08:39:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="e+q+v9FY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4DA4A20722 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:53752 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j53qj-0007DG-I5 for qemu-devel@archiver.kernel.org; Fri, 21 Feb 2020 03:39:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:51779) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j53pu-00063Y-Rr for qemu-devel@nongnu.org; Fri, 21 Feb 2020 03:39:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j53pt-0006Um-L1 for qemu-devel@nongnu.org; Fri, 21 Feb 2020 03:39:02 -0500 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:42469 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j53pt-0006TG-GS for qemu-devel@nongnu.org; Fri, 21 Feb 2020 03:39:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582274341; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+jKPj3gf+T3ocOqgvJULo7PhApveqgiAwsnEtaSBAEQ=; b=e+q+v9FYiHBMDN9wgzsZpOa3UtSZDBM7LtPy2K5kxuriFeAtmhR+4jVNDL2IiJKwlHHtQ0 juP26Iv2eaV1qRklmE6iso7BC2xBdSH2AF/k+zKM6fu0mHrzx22ATRtpzsZamfHr+7WBx1 IT7YpkSlrN015YEQfOhKWkNmvG4O2zY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-244-icepWPbFPbqSoFkIU1jjaA-1; Fri, 21 Feb 2020 03:38:59 -0500 X-MC-Unique: icepWPbFPbqSoFkIU1jjaA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E7A62800D50; Fri, 21 Feb 2020 08:38:55 +0000 (UTC) Received: from gondolin (ovpn-117-64.ams2.redhat.com [10.36.117.64]) by smtp.corp.redhat.com (Postfix) with ESMTP id DE7D75D9E2; Fri, 21 Feb 2020 08:38:33 +0000 (UTC) Date: Fri, 21 Feb 2020 09:38:30 +0100 From: Cornelia Huck To: Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= Subject: Re: [PATCH v3 08/20] Remove unnecessary cast when using the address_space API Message-ID: <20200221093830.63bc308e.cohuck@redhat.com> In-Reply-To: <20200220130548.29974-9-philmd@redhat.com> References: <20200220130548.29974-1-philmd@redhat.com> <20200220130548.29974-9-philmd@redhat.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Peter Maydell , Dmitry Fleytman , kvm@vger.kernel.org, "Michael S. Tsirkin" , Jason Wang , qemu-devel@nongnu.org, Gerd Hoffmann , "Edgar E. Iglesias" , Stefano Stabellini , Matthew Rosato , qemu-block@nongnu.org, David Hildenbrand , Halil Pasic , Christian Borntraeger , =?UTF-8?B?SGVy?= =?UTF-8?B?dsOp?= Poussineau , Anthony Perard , xen-devel@lists.xenproject.org, Aleksandar Rikalo , Richard Henderson , Laurent Vivier , Thomas Huth , Eduardo Habkost , Stefan Weil , Alistair Francis , Richard Henderson , Paul Durrant , Eric Auger , qemu-s390x@nongnu.org, qemu-arm@nongnu.org, =?UTF-8?B?Q8OpZHJpYw==?= Le Goater , John Snow , David Gibson , Igor Mitsyanko , Michael Walle , qemu-ppc@nongnu.org, Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, 20 Feb 2020 14:05:36 +0100 Philippe Mathieu-Daud=C3=A9 wrote: > This commit was produced with the included Coccinelle script > scripts/coccinelle/exec_rw_const. >=20 > Two lines in hw/net/dp8393x.c that Coccinelle produced that > were over 80 characters were re-wrapped by hand. >=20 > Suggested-by: Stefan Weil > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > --- > scripts/coccinelle/exec_rw_const.cocci | 15 +++++++++++++- > target/i386/hvf/vmx.h | 2 +- > hw/arm/boot.c | 6 ++---- > hw/dma/rc4030.c | 4 ++-- > hw/dma/xlnx-zdma.c | 2 +- > hw/net/cadence_gem.c | 21 +++++++++---------- > hw/net/dp8393x.c | 28 +++++++++++++------------- > hw/s390x/css.c | 4 ++-- > qtest.c | 12 +++++------ > target/i386/hvf/x86_mmu.c | 2 +- > target/i386/whpx-all.c | 2 +- > target/s390x/mmu_helper.c | 2 +- > 12 files changed, 54 insertions(+), 46 deletions(-) >=20 > diff --git a/hw/s390x/css.c b/hw/s390x/css.c > index 844caab408..f27f8c45a5 100644 > --- a/hw/s390x/css.c > +++ b/hw/s390x/css.c > @@ -875,7 +875,7 @@ static inline int ida_read_next_idaw(CcwDataStream *c= ds) > return -EINVAL; /* channel program check */ > } > ret =3D address_space_rw(&address_space_memory, idaw_addr, > - MEMTXATTRS_UNSPECIFIED, (void *) &idaw.fm= t2, > + MEMTXATTRS_UNSPECIFIED, &idaw.fmt2, > sizeof(idaw.fmt2), false); > cds->cda =3D be64_to_cpu(idaw.fmt2); > } else { > @@ -884,7 +884,7 @@ static inline int ida_read_next_idaw(CcwDataStream *c= ds) > return -EINVAL; /* channel program check */ > } > ret =3D address_space_rw(&address_space_memory, idaw_addr, > - MEMTXATTRS_UNSPECIFIED, (void *) &idaw.fm= t1, > + MEMTXATTRS_UNSPECIFIED, &idaw.fmt1, > sizeof(idaw.fmt1), false); > cds->cda =3D be64_to_cpu(idaw.fmt1); > if (cds->cda & 0x80000000) { > diff --git a/target/s390x/mmu_helper.c b/target/s390x/mmu_helper.c > index c9f3f34750..0be2f300bb 100644 > --- a/target/s390x/mmu_helper.c > +++ b/target/s390x/mmu_helper.c > @@ -106,7 +106,7 @@ static inline bool read_table_entry(CPUS390XState *en= v, hwaddr gaddr, > * We treat them as absolute addresses and don't wrap them. > */ > if (unlikely(address_space_read(cs->as, gaddr, MEMTXATTRS_UNSPECIFIE= D, > - (uint8_t *)entry, sizeof(*entry)) != =3D > + entry, sizeof(*entry)) !=3D > MEMTX_OK)) { > return false; > } s390 parts Acked-by: Cornelia Huck