From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v4 1/2] lib: add .request_hugepages to reserve hugepage
Date: Fri, 21 Feb 2020 13:16:18 +0100 [thread overview]
Message-ID: <20200221121618.GA16421@dell5510> (raw)
In-Reply-To: <20200218162739.GA9985@rei.lan>
Hi Li, Cyril,
> > + if (FILE_LINES_SCANF("/proc/meminfo",
> > + "MemAvailable: %ld", &mem_avail)) {
> > + /*
> > + * Using "MemFree:" on kernel that doesn't have
> > + * "MemAvailable:" in Meminfo
> > + */
> > + tst_res(TINFO, "MemAvailable: not found in /proc/meminfo");
> > +
> > + mem_avail = SAFE_READ_MEMINFO("MemFree:");
> > + }
> I guess that we don't have to bother with MemAvailable here, since we do
> drop the system caches the MemFree should be equal to MemAvailable. So I
> would be for reading just MemFree unconditionally here.
> If you agree with this change I can change it before applying.
Merged both patches with this change and my docs change.
Kind regards,
Petr
next prev parent reply other threads:[~2020-02-21 12:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-08 9:20 [LTP] [PATCH v4 1/2] lib: add .request_hugepages to reserve hugepage Li Wang
2020-02-08 9:20 ` [LTP] [PATCH v4 2/2] pkey01: disable hugetlb test if failed " Li Wang
2020-02-17 16:09 ` Petr Vorel
2020-02-17 16:08 ` [LTP] [PATCH v4 1/2] lib: add .request_hugepages " Petr Vorel
2020-02-18 6:06 ` Li Wang
2020-02-18 16:27 ` Cyril Hrubis
2020-02-19 4:02 ` Li Wang
2020-02-21 12:16 ` Petr Vorel [this message]
2020-02-22 3:02 ` Li Wang
2020-02-24 8:40 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200221121618.GA16421@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.