From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 405C3C35655 for ; Fri, 21 Feb 2020 13:12:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0AD5224653 for ; Fri, 21 Feb 2020 13:12:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="eib3Jfwy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728351AbgBUNMd (ORCPT ); Fri, 21 Feb 2020 08:12:33 -0500 Received: from mail-wm1-f66.google.com ([209.85.128.66]:36850 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727137AbgBUNMd (ORCPT ); Fri, 21 Feb 2020 08:12:33 -0500 Received: by mail-wm1-f66.google.com with SMTP id p17so1798202wma.1 for ; Fri, 21 Feb 2020 05:12:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=a/KavHLvvULXfL2VP34j+gxXqKWZ5d3n9oQaqLdPQv4=; b=eib3Jfwyj+tZtw0Vz5eRWnOQiMb9kRoD6q2gN2p55T9aS3rgoCUuv4jkOzgSy6JAgQ LEjM/7bJFu5XAMFaMvFkgF8XI6h8ICSPxck1TJrj6R8L0TLPzxasmiTqaRBEuJSE492o xUPyAD7jB/fuLzt6Z6u8a/djHUo7qip9vuLowvh5OaxbICooz75RPYWXY584WFX80Hsq UecpvDo6HfzMYfFJjPppbxEhywhbLPSsEWUgzWENhmVwerLyCsfebJ75YhAi0BV6oT34 gcEUPT4zy5xBisJiKhATgcWrOM/bv0x40XtU3oXOP8d4vAUNTTge4+2/pCIL965PidD5 SzyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=a/KavHLvvULXfL2VP34j+gxXqKWZ5d3n9oQaqLdPQv4=; b=KnEJ3leq1RdCkOdxmOAo7/uui4tQpVmevxXeJjk68DYFbiiuQ4WgieG8KRYS7DwpM2 nAgUMDG9PSaVu5rKzI7HuKXMeMoyIC5Tv01S+9VCFIDWcS9bZjUT+phwKIpfcaEpZnoJ fzS0pHHNG3BZeMSYUJz5Zltet0KxXORObEursvcPHKgUm9l/ZqrUYIuwSdxEeK+NUKxs TkYGzsMC+vJFWSl2ffQuUPwNUIt9m7CS/do+NI6SzIZbgdGbbbaA/cBQ9hCJ1cknJ3YF CToI9vCIxLlB5U/QV0KrkoBZQYaeYxrn1XnQd0Ge8HE72kSHK38zTzeQT0jNmuT/CnRd KQMQ== X-Gm-Message-State: APjAAAU3b3A7dOt7dIcGAB2IoBBSVG7WeINwl9Lj+d7Q5jkoCTb9rTZk BBKze+JcG6FkxnJWT+7O3EVflQ== X-Google-Smtp-Source: APXvYqx5emu1fdVAd6Tj3p81RSkBc6Mf5Yyr0nrkLGXMlG0khLLYOloIT2vAb1bEk0+GwUGFpzZSvQ== X-Received: by 2002:a1c:4e02:: with SMTP id g2mr3929356wmh.131.1582290750388; Fri, 21 Feb 2020 05:12:30 -0800 (PST) Received: from linaro.org ([2a01:e34:ed2f:f020:2dfb:b5ce:9043:4adb]) by smtp.gmail.com with ESMTPSA id c15sm3881537wrt.1.2020.02.21.05.12.28 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 21 Feb 2020 05:12:29 -0800 (PST) Date: Fri, 21 Feb 2020 14:12:26 +0100 From: Daniel Lezcano To: Anson Huang Cc: "robh+dt@kernel.org" , "mark.rutland@arm.com" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "kernel@pengutronix.de" , "festevam@gmail.com" , "catalin.marinas@arm.com" , "will@kernel.org" , "rui.zhang@intel.com" , "amit.kucheria@verdurent.com" , Aisheng Dong , "linux@roeck-us.net" , "srinivas.kandagatla@linaro.org" , "krzk@kernel.org" , Andy Duan , Peng Fan , Daniel Baluta , "bjorn.andersson@linaro.org" , "olof@lixom.net" , "dinguyen@kernel.org" , Leonard Crestez , "marcin.juszkiewicz@linaro.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-pm@vger.kernel.org" , dl-linux-imx Subject: Re: [PATCH V15 RESEND 2/5] thermal: of-thermal: add API for getting sensor ID from DT Message-ID: <20200221131226.GE10516@linaro.org> References: <1582161028-2844-1-git-send-email-Anson.Huang@nxp.com> <1582161028-2844-2-git-send-email-Anson.Huang@nxp.com> <20200221091112.GA10516@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Fri, Feb 21, 2020 at 09:26:29AM +0000, Anson Huang wrote: > Hi, Daniel > > > > * a valid .of_node, for the sensor node. > > > @@ -499,36 +546,22 @@ thermal_zone_of_sensor_register(struct device > > *dev, int sensor_id, void *data, > > > sensor_np = of_node_get(dev->of_node); > > > > > > for_each_available_child_of_node(np, child) { > > > - struct of_phandle_args sensor_specs; > > > int ret, id; > > > > > > /* For now, thermal framework supports only 1 sensor per > > zone */ > > > - ret = of_parse_phandle_with_args(child, "thermal-sensors", > > > - "#thermal-sensor-cells", > > > - 0, &sensor_specs); > > > + ret = thermal_zone_of_get_sensor_id(child, sensor_np, &id); > > > if (ret) > > > continue; > > > > > > - if (sensor_specs.args_count >= 1) { > > > - id = sensor_specs.args[0]; > > > - WARN(sensor_specs.args_count > 1, > > > - "%pOFn: too many cells in sensor specifier %d\n", > > > - sensor_specs.np, sensor_specs.args_count); > > > - } else { > > > - id = 0; > > > - } > > > > Please take also the opportunity to factor out the function > > thermal_zone_of_sensor_register(). > > Sorry, I do NOT quite understand terms "factor out the function ...", could you please advise more detail? Never mind, I realized I puzzled myself with the changes in the series :) Thanks -- Daniel -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA0FCC35647 for ; Fri, 21 Feb 2020 13:12:46 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7F65C24672 for ; Fri, 21 Feb 2020 13:12:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="MGRaHT3E"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="eib3Jfwy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7F65C24672 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/hKM3wB4czO3/CWHOPAknfe/l3b38UU9AfmH4V9KPT0=; b=MGRaHT3EB+olLs uLAE6n1kdasCAWPZsCrUCfjXqluoIeEVOYoLiAezikZcbpFB08HTWLFSMKxoNmyCV2ogBkvqVZwMG 77tjo1DCls5iGokEKitjgHuYKpz+dt5dH2STG936m+fFNY4VhIQwWPk4JCVLCnSfQvZHG6C36Q25Q 7E2Y9cXh4b+xCkvuXmwgyodJLb5xCFBUuJHYoTbqLuym6ltSOXV9gNQuY1u1RTtQgs4w3n2P0nTre EhMNFSpC7s91yz4/y3+ZojGo5lDmLoygkfIskvkG4ukryYBCx71giSwy5/65JMqCNiP3jAg+8JFjP C9CVvnZ374oqbq4dcRWA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j586d-0001oC-OB; Fri, 21 Feb 2020 13:12:35 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j586a-0001nr-GA for linux-arm-kernel@lists.infradead.org; Fri, 21 Feb 2020 13:12:34 +0000 Received: by mail-wm1-x344.google.com with SMTP id b17so1807164wmb.0 for ; Fri, 21 Feb 2020 05:12:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=a/KavHLvvULXfL2VP34j+gxXqKWZ5d3n9oQaqLdPQv4=; b=eib3Jfwyj+tZtw0Vz5eRWnOQiMb9kRoD6q2gN2p55T9aS3rgoCUuv4jkOzgSy6JAgQ LEjM/7bJFu5XAMFaMvFkgF8XI6h8ICSPxck1TJrj6R8L0TLPzxasmiTqaRBEuJSE492o xUPyAD7jB/fuLzt6Z6u8a/djHUo7qip9vuLowvh5OaxbICooz75RPYWXY584WFX80Hsq UecpvDo6HfzMYfFJjPppbxEhywhbLPSsEWUgzWENhmVwerLyCsfebJ75YhAi0BV6oT34 gcEUPT4zy5xBisJiKhATgcWrOM/bv0x40XtU3oXOP8d4vAUNTTge4+2/pCIL965PidD5 SzyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=a/KavHLvvULXfL2VP34j+gxXqKWZ5d3n9oQaqLdPQv4=; b=TgjHWdQd7fRUh2f49mxDRrmFX3qqwRh2sfhO2cwFdz7AiIiGgtHPUt+ma15rRGqZYZ M+HCnc/Ga+RGUdiP5/63lykTv/8In5JC0uEVv6N4uVyVmByENO5CuHznTj5tfMhWFB6X oRk7gYMlkQ6wo62cSDBnYcpebTkBMMpT2eSLnw6tugRRxnmMLnkVWWM0EVm3xOhbH0zx w9CAfpL5i/lCbk6gBTaUo1qskN6fhTFy5BxY+evpoMb4UmRd802GhPlSWSXpgD6Ww5/L qy5gAGo7npnrlXO3BjPe6c5eapjYcD0V0Ic6XbswAuOHcyqwsaB/GL4Bp/z0nG3H//bf 42DQ== X-Gm-Message-State: APjAAAVNiOpIJvzRstRroUupAGjKQO1dXpninkJS2yNMHQnmA81IeTCy nMM40OldR8/Bn+Ql8OwgYAIFGw== X-Google-Smtp-Source: APXvYqx5emu1fdVAd6Tj3p81RSkBc6Mf5Yyr0nrkLGXMlG0khLLYOloIT2vAb1bEk0+GwUGFpzZSvQ== X-Received: by 2002:a1c:4e02:: with SMTP id g2mr3929356wmh.131.1582290750388; Fri, 21 Feb 2020 05:12:30 -0800 (PST) Received: from linaro.org ([2a01:e34:ed2f:f020:2dfb:b5ce:9043:4adb]) by smtp.gmail.com with ESMTPSA id c15sm3881537wrt.1.2020.02.21.05.12.28 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 21 Feb 2020 05:12:29 -0800 (PST) Date: Fri, 21 Feb 2020 14:12:26 +0100 From: Daniel Lezcano To: Anson Huang Subject: Re: [PATCH V15 RESEND 2/5] thermal: of-thermal: add API for getting sensor ID from DT Message-ID: <20200221131226.GE10516@linaro.org> References: <1582161028-2844-1-git-send-email-Anson.Huang@nxp.com> <1582161028-2844-2-git-send-email-Anson.Huang@nxp.com> <20200221091112.GA10516@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200221_051232_533750_11068C74 X-CRM114-Status: GOOD ( 14.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "mark.rutland@arm.com" , Peng Fan , "catalin.marinas@arm.com" , "bjorn.andersson@linaro.org" , "srinivas.kandagatla@linaro.org" , Leonard Crestez , "will@kernel.org" , "amit.kucheria@verdurent.com" , "festevam@gmail.com" , "krzk@kernel.org" , "marcin.juszkiewicz@linaro.org" , dl-linux-imx , "rui.zhang@intel.com" , "linux@roeck-us.net" , "devicetree@vger.kernel.org" , "linux-pm@vger.kernel.org" , "s.hauer@pengutronix.de" , "robh+dt@kernel.org" , Daniel Baluta , "linux-arm-kernel@lists.infradead.org" , Aisheng Dong , Andy Duan , "linux-kernel@vger.kernel.org" , "dinguyen@kernel.org" , "kernel@pengutronix.de" , "olof@lixom.net" , "shawnguo@kernel.org" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCBGZWIgMjEsIDIwMjAgYXQgMDk6MjY6MjlBTSArMDAwMCwgQW5zb24gSHVhbmcgd3Jv dGU6Cj4gSGksIERhbmllbAo+IAo+ID4gPiAgICogICAgICAgYSB2YWxpZCAub2Zfbm9kZSwgZm9y IHRoZSBzZW5zb3Igbm9kZS4KPiA+ID4gQEAgLTQ5OSwzNiArNTQ2LDIyIEBAIHRoZXJtYWxfem9u ZV9vZl9zZW5zb3JfcmVnaXN0ZXIoc3RydWN0IGRldmljZQo+ID4gKmRldiwgaW50IHNlbnNvcl9p ZCwgdm9pZCAqZGF0YSwKPiA+ID4gIAlzZW5zb3JfbnAgPSBvZl9ub2RlX2dldChkZXYtPm9mX25v ZGUpOwo+ID4gPgo+ID4gPiAgCWZvcl9lYWNoX2F2YWlsYWJsZV9jaGlsZF9vZl9ub2RlKG5wLCBj aGlsZCkgewo+ID4gPiAtCQlzdHJ1Y3Qgb2ZfcGhhbmRsZV9hcmdzIHNlbnNvcl9zcGVjczsKPiA+ ID4gIAkJaW50IHJldCwgaWQ7Cj4gPiA+Cj4gPiA+ICAJCS8qIEZvciBub3csIHRoZXJtYWwgZnJh bWV3b3JrIHN1cHBvcnRzIG9ubHkgMSBzZW5zb3IgcGVyCj4gPiB6b25lICovCj4gPiA+IC0JCXJl dCA9IG9mX3BhcnNlX3BoYW5kbGVfd2l0aF9hcmdzKGNoaWxkLCAidGhlcm1hbC1zZW5zb3JzIiwK PiA+ID4gLQkJCQkJCSAiI3RoZXJtYWwtc2Vuc29yLWNlbGxzIiwKPiA+ID4gLQkJCQkJCSAwLCAm c2Vuc29yX3NwZWNzKTsKPiA+ID4gKwkJcmV0ID0gdGhlcm1hbF96b25lX29mX2dldF9zZW5zb3Jf aWQoY2hpbGQsIHNlbnNvcl9ucCwgJmlkKTsKPiA+ID4gIAkJaWYgKHJldCkKPiA+ID4gIAkJCWNv bnRpbnVlOwo+ID4gPgo+ID4gPiAtCQlpZiAoc2Vuc29yX3NwZWNzLmFyZ3NfY291bnQgPj0gMSkg ewo+ID4gPiAtCQkJaWQgPSBzZW5zb3Jfc3BlY3MuYXJnc1swXTsKPiA+ID4gLQkJCVdBUk4oc2Vu c29yX3NwZWNzLmFyZ3NfY291bnQgPiAxLAo+ID4gPiAtCQkJICAgICAiJXBPRm46IHRvbyBtYW55 IGNlbGxzIGluIHNlbnNvciBzcGVjaWZpZXIgJWRcbiIsCj4gPiA+IC0JCQkgICAgIHNlbnNvcl9z cGVjcy5ucCwgc2Vuc29yX3NwZWNzLmFyZ3NfY291bnQpOwo+ID4gPiAtCQl9IGVsc2Ugewo+ID4g PiAtCQkJaWQgPSAwOwo+ID4gPiAtCQl9Cj4gPiAKPiA+IFBsZWFzZSB0YWtlIGFsc28gdGhlIG9w cG9ydHVuaXR5IHRvIGZhY3RvciBvdXQgdGhlIGZ1bmN0aW9uCj4gPiB0aGVybWFsX3pvbmVfb2Zf c2Vuc29yX3JlZ2lzdGVyKCkuCj4gCj4gU29ycnksIEkgZG8gTk9UIHF1aXRlIHVuZGVyc3RhbmQg dGVybXMgImZhY3RvciBvdXQgdGhlIGZ1bmN0aW9uIC4uLiIsIGNvdWxkIHlvdSBwbGVhc2UgYWR2 aXNlIG1vcmUgZGV0YWlsPwoKTmV2ZXIgbWluZCwgSSByZWFsaXplZCBJIHB1enpsZWQgbXlzZWxm IHdpdGggdGhlIGNoYW5nZXMgaW4gdGhlIHNlcmllcyA6KQoKVGhhbmtzCgogIC0tIERhbmllbAoK LS0gCgogPGh0dHA6Ly93d3cubGluYXJvLm9yZy8+IExpbmFyby5vcmcg4pSCIE9wZW4gc291cmNl IHNvZnR3YXJlIGZvciBBUk0gU29DcwoKRm9sbG93IExpbmFybzogIDxodHRwOi8vd3d3LmZhY2Vi b29rLmNvbS9wYWdlcy9MaW5hcm8+IEZhY2Vib29rIHwKPGh0dHA6Ly90d2l0dGVyLmNvbS8jIS9s aW5hcm9vcmc+IFR3aXR0ZXIgfAo8aHR0cDovL3d3dy5saW5hcm8ub3JnL2xpbmFyby1ibG9nLz4g QmxvZwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGlu dXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRl YWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgt YXJtLWtlcm5lbAo=