From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_cursor_legacy: increase timeout for nonblocking flip wait
Date: Fri, 21 Feb 2020 15:31:53 +0200 [thread overview]
Message-ID: <20200221133153.GN13686@intel.com> (raw)
In-Reply-To: <158229098521.30577.509445839669102035@skylake-alporthouse-com>
On Fri, Feb 21, 2020 at 01:16:25PM +0000, Chris Wilson wrote:
> Quoting Juha-Pekka Heikkila (2020-02-21 13:12:46)
> > On 21.2.2020 14.23, Chris Wilson wrote:
> > > Quoting Juha-Pekka Heikkila (2020-02-21 12:08:07)
> > >> When run on more than one monitor there may be modeset in queue
> > >> which will block flip. Kernel will timeout with modeset at
> > >> ten seconds so lets wait in test also that same ten seconds at
> > >> maximum.
> > >
> > > 10s! You are joking, right? For a modeset that should not be there?
> >
> > 10s sounded quite big number to me too but that is from Ville. This test
> > is now failing because modeset + flip take more than one second, on my
> > ICL box with eDP + HDMI connected it becomes 1.19s. Arek is talking
> > about test box where it is more than two seconds. Anyway if 10s is what
> > kernel is waiting in the worst case I don't think test should be more
> > strict.
>
> I think the kernel is broken. From a UX perspective that needs fixing.
10s is the flip_done timeout. We shouldn't need quite that long.
IIRC the max panel power cycle delay we can program is something
like 5s.
I had a quick look at the test case but couldn't quite figure out
what specifically it was trying to say with the different timeouts.
--
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2020-02-21 13:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-21 12:08 [igt-dev] [PATCH i-g-t] tests/kms_cursor_legacy: increase timeout for nonblocking flip wait Juha-Pekka Heikkila
2020-02-21 12:23 ` Chris Wilson
2020-02-21 13:12 ` Juha-Pekka Heikkila
2020-02-21 13:16 ` Chris Wilson
2020-02-21 13:24 ` Juha-Pekka Heikkila
2020-02-21 13:31 ` Ville Syrjälä [this message]
2020-02-21 14:35 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2020-03-04 14:50 [igt-dev] [PATCH i-g-t] " Juha-Pekka Heikkila
2020-03-09 11:19 ` Kahola, Mika
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200221133153.GN13686@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.