From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E279C35646 for ; Fri, 21 Feb 2020 15:01:23 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0B39724650 for ; Fri, 21 Feb 2020 15:01:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0B39724650 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 711E06F473; Fri, 21 Feb 2020 15:01:22 +0000 (UTC) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3B3F66E35F for ; Fri, 21 Feb 2020 15:01:21 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2005) id 3258468BFE; Fri, 21 Feb 2020 16:01:18 +0100 (CET) Date: Fri, 21 Feb 2020 16:01:17 +0100 From: Torsten Duwe To: Thomas Zimmermann Subject: Re: [RESEND2][PATCH] drm/bridge: analogix-anx6345: Fix drm_dp_link helper removal Message-ID: <20200221150117.GA6928@lst.de> References: <20200221140455.8713068BFE@verein.lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jernej Skrabec , Jonas Karlman , David Airlie , Neil Armstrong , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Vasily Khoruzhick , Andrzej Hajda , Thierry Reding , Sean Paul , Laurent Pinchart , Thierry Reding , Maxime Ripard Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Feb 21, 2020 at 03:39:32PM +0100, Thomas Zimmermann wrote: > Hi Torsten > > Am 21.02.20 um 15:04 schrieb Torsten Duwe: > > drm_dp_link_rate_to_bw_code and ...bw_code_to_link_rate simply divide by > > and multiply with 27000, respectively. Avoid an overflow in the u8 dpcd[0] > > and the multiply+divide alltogether. > > > > fixes: e1cff82c1097bda2478 ("fix anx6345 compilation for v5.5") > > You have to create the fixes tag and related cc tags with 'dim fixes', > available at [1]. For this patch, the output is > > Fixes: e1cff82c1097 ("drm/bridge: fix anx6345 compilation for v5.5") > Cc: Torsten Duwe > Cc: Maxime Ripard > Cc: Torsten Duwe > Cc: Sam Ravnborg > Cc: Linus Walleij > Cc: Thomas Zimmermann > Cc: Icenowy Zheng > Cc: Stephen Rothwell Ah, neat. > > Signed-off-by: Torsten Duwe > > You signed off with your SUSE email address, but sent the mail from > lst.de. I don't know if it's strictly not allowed, but that's at least > confusing to the tools. >From my understanding, it is legally correct. The work is owned by Suse, so I have to sign off as an employee, but I'm subscribed with the LST address, and I'd also like to see all replies there. > [1] https://gitlab.freedesktop.org/drm/maintainer-tools/ I'll send an appropriate v2 once I get a review for it. Thanks! Torsten _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93BA9C35656 for ; Fri, 21 Feb 2020 15:01:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 735A724650 for ; Fri, 21 Feb 2020 15:01:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728910AbgBUPBW (ORCPT ); Fri, 21 Feb 2020 10:01:22 -0500 Received: from verein.lst.de ([213.95.11.211]:55906 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728690AbgBUPBW (ORCPT ); Fri, 21 Feb 2020 10:01:22 -0500 Received: by verein.lst.de (Postfix, from userid 2005) id 3258468BFE; Fri, 21 Feb 2020 16:01:18 +0100 (CET) Date: Fri, 21 Feb 2020 16:01:17 +0100 From: Torsten Duwe To: Thomas Zimmermann Cc: Vasily Khoruzhick , Thierry Reding , Daniel Vetter , Thierry Reding , Jernej Skrabec , Jonas Karlman , David Airlie , Neil Armstrong , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Andrzej Hajda , Sean Paul , Laurent Pinchart , Maxime Ripard Subject: Re: [RESEND2][PATCH] drm/bridge: analogix-anx6345: Fix drm_dp_link helper removal Message-ID: <20200221150117.GA6928@lst.de> References: <20200221140455.8713068BFE@verein.lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 21, 2020 at 03:39:32PM +0100, Thomas Zimmermann wrote: > Hi Torsten > > Am 21.02.20 um 15:04 schrieb Torsten Duwe: > > drm_dp_link_rate_to_bw_code and ...bw_code_to_link_rate simply divide by > > and multiply with 27000, respectively. Avoid an overflow in the u8 dpcd[0] > > and the multiply+divide alltogether. > > > > fixes: e1cff82c1097bda2478 ("fix anx6345 compilation for v5.5") > > You have to create the fixes tag and related cc tags with 'dim fixes', > available at [1]. For this patch, the output is > > Fixes: e1cff82c1097 ("drm/bridge: fix anx6345 compilation for v5.5") > Cc: Torsten Duwe > Cc: Maxime Ripard > Cc: Torsten Duwe > Cc: Sam Ravnborg > Cc: Linus Walleij > Cc: Thomas Zimmermann > Cc: Icenowy Zheng > Cc: Stephen Rothwell Ah, neat. > > Signed-off-by: Torsten Duwe > > You signed off with your SUSE email address, but sent the mail from > lst.de. I don't know if it's strictly not allowed, but that's at least > confusing to the tools. >From my understanding, it is legally correct. The work is owned by Suse, so I have to sign off as an employee, but I'm subscribed with the LST address, and I'd also like to see all replies there. > [1] https://gitlab.freedesktop.org/drm/maintainer-tools/ I'll send an appropriate v2 once I get a review for it. Thanks! Torsten