From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH/next 2/2] replace MESA_EGL_NO_X11_HEADERS hack with upstream EGL_NO_X11
Date: Sun, 23 Feb 2020 11:04:55 +0100 [thread overview]
Message-ID: <20200223100455.GL8743@scaer> (raw)
In-Reply-To: <t2r9igxv9o.ln2@ID-313208.user.individual.net>
Bernd, All,
On 2020-02-23 09:52 +0100, Bernd Kuhls spake thusly:
> Am Sun, 23 Feb 2020 09:41:20 +0100 schrieb Yann E. MORIN:
> > On 2020-02-20 19:59 +0100, Bernd Kuhls spake thusly:
> >> Mesa3d 20.0.0 deprecated MESA_EGL_NO_X11_HEADERS:
> >> https://cgit.freedesktop.org/mesa/mesa/commit/?
> id=6202a13b71e18dc31ba7e2f4ea915b67eacc1ddb
> > I think this change should be folded in the previous commit: indeed,
> > that's the bump of mesa3d that causes the trouble.
> even with mesa being bumped to 20.x old code still builds,
Before, the code built without warnings, now it builds with warnings.
> mesa3d 20.0.0
> just added a warning about the old define being deprecated. Splitting
> both topics, version bump and EGL_NO_X11, still creates a bisectable
> history and makes it easier to pinpoint problems to either one of these
> topics so I would still vote for two patches.
Since that's us, Buildroot, adding the define in the first place, it's
our fault that the warnings appear.
So, the bump introduces a regression, that is a build without warnigns
now has warnings, and so the bump should come with the fix.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
prev parent reply other threads:[~2020-02-23 10:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 18:59 [Buildroot] [PATCH/next 1/2] package/{mesa3d, mesa3d-headers}: bump version to 20.0.0 Bernd Kuhls
2020-02-20 18:59 ` [Buildroot] [PATCH/next 2/2] replace MESA_EGL_NO_X11_HEADERS hack with upstream EGL_NO_X11 Bernd Kuhls
2020-02-23 8:41 ` Yann E. MORIN
2020-02-23 8:52 ` Bernd Kuhls
2020-02-23 10:04 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200223100455.GL8743@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.