From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <ak@linux.intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Michael Petlan <mpetlan@redhat.com>,
Ravi Bangoria <ravi.bangoria@linux.ibm.com>,
Kajol Jain <kjain@linux.ibm.com>,
John Garry <john.garry@huawei.com>
Subject: Re: [PATCH 2/4] perf expr: Move expr lexer to flex
Date: Mon, 24 Feb 2020 09:30:03 +0100 [thread overview]
Message-ID: <20200224083003.GC16664@krava> (raw)
In-Reply-To: <20200222002312.GN160988@tassilo.jf.intel.com>
On Fri, Feb 21, 2020 at 04:23:12PM -0800, Andi Kleen wrote:
> > +max { return MAX; }
> > +min { return MIN; }
> > +if { return IF; }
> > +else { return ELSE; }
> > +#smt_on { return SMT_ON; }
> > +{number} { return value(yyscanner, 10); }
> > +{symbol} { return str(yyscanner, ID); }
> > +"|" { return '|'; }
> > +"^" { return '^'; }
> > +"&" { return '&'; }
> > +"-" { return '-'; }
> > +"+" { return '+'; }
> > +"*" { return '*'; }
> > +"/" { return '/'; }
> > +"%" { return '%'; }
> > +"(" { return '('; }
> > +")" { return ')'; }
> > +"," { return ','; }
>
> Didn't think there was a comma, but ok.
actually it's for the min/max functions arguments separation
I posted v2
jirka
>
> Looks reasonable to me.
>
> -Andi
>
next prev parent reply other threads:[~2020-02-24 8:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-21 23:19 [RFC 0/4] perf expr: Add flex scanner Jiri Olsa
2020-02-21 23:19 ` [PATCH 1/4] perf expr: Add expr.c object Jiri Olsa
2020-02-21 23:19 ` [PATCH 2/4] perf expr: Move expr lexer to flex Jiri Olsa
2020-02-22 0:23 ` Andi Kleen
2020-02-22 22:02 ` Jiri Olsa
2020-02-24 8:30 ` Jiri Olsa [this message]
2020-02-21 23:19 ` [PATCH 3/4] perf expr: Increase EXPR_MAX_OTHER Jiri Olsa
2020-02-21 23:19 ` [PATCH 4/4] perf expr: Straighten expr__parse/expr__find_other interface Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200224083003.GC16664@krava \
--to=jolsa@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=john.garry@huawei.com \
--cc=jolsa@kernel.org \
--cc=kjain@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mpetlan@redhat.com \
--cc=namhyung@kernel.org \
--cc=ravi.bangoria@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.