From: Roger Pau Monne <roger.pau@citrix.com>
To: <xen-devel@lists.xenproject.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Julien Grall <julien@xen.org>, Wei Liu <wl@xen.org>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
George Dunlap <george.dunlap@citrix.com>,
Jan Beulich <jbeulich@suse.com>,
Roger Pau Monne <roger.pau@citrix.com>
Subject: [Xen-devel] [PATCH v3 0/5] x86: fixes/improvements for scratch cpumask
Date: Mon, 24 Feb 2020 11:46:40 +0100 [thread overview]
Message-ID: <20200224104645.96381-1-roger.pau@citrix.com> (raw)
Hello,
Commit:
5500d265a2a8fa63d60c08beb549de8ec82ff7a5
x86/smp: use APIC ALLBUT destination shorthand when possible
Introduced a bogus usage of the scratch cpumask: it was used in a
function that could be called from interrupt context, and hence using
the scratch cpumask there is not safe. Patch #4 is a fix for that usage,
together with also preventing the usage of any per-CPU variables when
send_IPI_mask is called from #MC or #NMI context. Previous patches are
preparatory changes.
Patch #5 adds some debug infrastructure to make sure the scratch cpumask
is used in the right context, and hence should prevent further missuses.
Thanks, Roger.
Roger Pau Monne (5):
x86: introduce a nmi_count tracking variable
x86: track when in #NMI context
x86: track when in #MC context
x86/smp: use a dedicated scratch cpumask in send_IPI_mask
x86: add accessors for scratch cpu mask
xen/arch/x86/cpu/mcheck/mce.c | 2 ++
xen/arch/x86/io_apic.c | 6 ++--
xen/arch/x86/irq.c | 13 +++++++--
xen/arch/x86/mm.c | 30 ++++++++++++++------
xen/arch/x86/msi.c | 4 ++-
xen/arch/x86/nmi.c | 11 ++++----
xen/arch/x86/smp.c | 52 ++++++++++++++++++++++++++++++++++-
xen/arch/x86/smpboot.c | 10 +++++--
xen/arch/x86/traps.c | 10 ++++++-
xen/include/asm-x86/hardirq.h | 13 ++++++++-
xen/include/asm-x86/nmi.h | 2 ++
xen/include/asm-x86/smp.h | 10 +++++++
xen/include/xen/irq_cpustat.h | 1 -
13 files changed, 137 insertions(+), 27 deletions(-)
--
2.25.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next reply other threads:[~2020-02-24 10:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-24 10:46 Roger Pau Monne [this message]
2020-02-24 10:46 ` [Xen-devel] [PATCH v3 1/5] x86: introduce a nmi_count tracking variable Roger Pau Monne
2020-02-25 16:39 ` Jan Beulich
2020-02-24 10:46 ` [Xen-devel] [PATCH v3 2/5] x86: track when in #NMI context Roger Pau Monne
2020-02-25 16:49 ` Jan Beulich
2020-02-25 16:51 ` Jan Beulich
2020-02-24 10:46 ` [Xen-devel] [PATCH v3 3/5] x86: track when in #MC context Roger Pau Monne
2020-02-25 17:06 ` Jan Beulich
2020-02-24 10:46 ` [Xen-devel] [PATCH v3 4/5] x86/smp: use a dedicated scratch cpumask in send_IPI_mask Roger Pau Monne
2020-02-26 10:07 ` Jan Beulich
2020-02-26 10:18 ` Roger Pau Monné
2020-02-26 10:45 ` Jan Beulich
2020-02-26 10:51 ` Roger Pau Monné
2020-02-24 10:46 ` [Xen-devel] [PATCH v3 5/5] x86: add accessors for scratch cpu mask Roger Pau Monne
2020-02-26 10:36 ` Jan Beulich
2020-02-27 17:54 ` Roger Pau Monné
2020-02-28 8:48 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200224104645.96381-1-roger.pau@citrix.com \
--to=roger.pau@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=julien@xen.org \
--cc=konrad.wilk@oracle.com \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.