From: Guenter Roeck <linux@roeck-us.net>
To: Vadim Pasternak <vadimp@mellanox.com>
Cc: "linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>
Subject: Re: [hwmon-next v1] hwmon: (pmbus/tps53679) Add support for historical registers for TPS53688
Date: Mon, 24 Feb 2020 08:27:34 -0800 [thread overview]
Message-ID: <20200224162734.GA25424@roeck-us.net> (raw)
In-Reply-To: <DB6PR0501MB235847DEC43DED481A0553EDA2EC0@DB6PR0501MB2358.eurprd05.prod.outlook.com>
On Mon, Feb 24, 2020 at 03:44:04PM +0000, Vadim Pasternak wrote:
>
[ ... ]
>
> When we discussed this feature I asked:
>
> >> Can I assume that most i2c controllers support "smbus_read_block", or
> >> it's better to read with
> >> i2c_smbus_read_i2c_block_data() with size 5?
> >>
> And you replied:
> > I use i2c_smbus_read_i2c_block_data(); that is what it is for.
>
Outch. I must have had a bad day when I wrote that. I don't think
I ever used it; I always use i2c_smbus_read_block_data().
Sorry for the confusion.
Guenter
next prev parent reply other threads:[~2020-02-24 16:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-24 13:13 [hwmon-next v1] hwmon: (pmbus/tps53679) Add support for historical registers for TPS53688 Vadim Pasternak
2020-02-24 14:50 ` Guenter Roeck
2020-02-24 15:10 ` Guenter Roeck
2020-02-24 15:44 ` Vadim Pasternak
2020-02-24 16:27 ` Guenter Roeck [this message]
2020-02-24 22:13 ` Vadim Pasternak
2020-02-24 22:24 ` Guenter Roeck
2020-02-24 22:29 ` Vadim Pasternak
2020-02-24 22:34 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200224162734.GA25424@roeck-us.net \
--to=linux@roeck-us.net \
--cc=linux-hwmon@vger.kernel.org \
--cc=vadimp@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.