From: Christoph Hellwig <hch@lst.de>
To: Bart Van Assche <bvanassche@acm.org>
Cc: "Asutosh Das (asd)" <asutoshd@codeaurora.org>,
Christoph Hellwig <hch@lst.de>,
linux-scsi@vger.kernel.org, Alim Akhtar <alim.akhtar@samsung.com>,
Avri Altman <avri.altman@wdc.com>
Subject: Re: [PATCH 2/2] ufshcd: use an enum for quirks
Date: Mon, 24 Feb 2020 18:16:11 +0100 [thread overview]
Message-ID: <20200224171611.GA7278@lst.de> (raw)
In-Reply-To: <530c2c48-7bc7-1a8e-07b9-997854188f9c@acm.org>
On Fri, Feb 21, 2020 at 06:45:37PM -0800, Bart Van Assche wrote:
> On 2020-02-21 10:18, Asutosh Das (asd) wrote:
> > On 2/21/2020 6:08 AM, Christoph Hellwig wrote:
> >> + /* Interrupt aggregation support is broken */
> >> + UFSHCD_QUIRK_BROKEN_INTR_AGGR = 1 << 0,
> >> +
> >
> > How about using BIT() here?
>
> Not everyone is convinced that using BIT() improves code readability.
I for one am not. 1 << N shoud be obvious to anyone with a basic
understanding of C code, BIT() needs to be looked up. And it isn't
actually any shorter.
next prev parent reply other threads:[~2020-02-24 17:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-21 14:08 ufshcd quirk cleanup v2 Christoph Hellwig
2020-02-21 14:08 ` [PATCH 1/2] ufshcd: remove unused quirks Christoph Hellwig
2020-02-22 2:46 ` Bart Van Assche
2020-02-22 3:05 ` Alim Akhtar
2020-02-22 12:55 ` Avri Altman
2020-02-21 14:08 ` [PATCH 2/2] ufshcd: use an enum for quirks Christoph Hellwig
2020-02-21 18:18 ` Asutosh Das (asd)
2020-02-22 2:45 ` Bart Van Assche
2020-02-24 17:16 ` Christoph Hellwig [this message]
2020-02-22 2:46 ` Bart Van Assche
2020-02-29 1:37 ` ufshcd quirk cleanup v2 Martin K. Petersen
-- strict thread matches above, loose matches on Subject: below --
2020-02-18 23:44 ufshcd quirk cleanup Christoph Hellwig
2020-02-18 23:44 ` [PATCH 2/2] ufshcd: use an enum for quirks Christoph Hellwig
2020-02-19 0:10 ` Bart Van Assche
2020-02-20 17:25 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200224171611.GA7278@lst.de \
--to=hch@lst.de \
--cc=alim.akhtar@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=bvanassche@acm.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.