From: Rob Herring <robh@kernel.org>
To: Amit Kucheria <amit.kucheria@linaro.org>
Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
swboyd@chromium.org, mka@chromium.org, daniel.lezcano@linaro.org,
Amit Kucheria <amit.kucheria@verdurent.com>,
Zhang Rui <rui.zhang@intel.com>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [RFC PATCH v1 1/3] dt-bindings: thermal: Add yaml bindings for thermal sensors
Date: Mon, 24 Feb 2020 12:39:44 -0600 [thread overview]
Message-ID: <20200224183944.GA2201@bogus> (raw)
In-Reply-To: <11f9128efef92b427d93a563d5b53b62c4c01888.1582528977.git.amit.kucheria@linaro.org>
On Mon, 24 Feb 2020 12:55:35 +0530, Amit Kucheria wrote:
> As part of moving the thermal bindings to YAML, split it up into 3
> bindings: thermal sensors, cooling devices and thermal zones.
>
> The property #thermal-sensor-cells is required in each device that acts
> as a thermal sensor. It is used to uniquely identify the instance of the
> thermal sensor inside the system.
>
> Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
> ---
> .../bindings/thermal/thermal-sensor.yaml | 70 +++++++++++++++++++
> 1 file changed, 70 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/thermal/thermal-sensor.yaml
>
My bot found errors running 'make dt_binding_check' on your patch:
Documentation/devicetree/bindings/display/simple-framebuffer.example.dts:21.16-37.11: Warning (chosen_node_is_root): /example-0/chosen: chosen node must be at root node
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/thermal/thermal-sensor.example.dt.yaml: thermal-sensor@c263000: interrupt-names: ['uplow'] is too short
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/thermal/thermal-sensor.example.dt.yaml: thermal-sensor@c263000: interrupts: [[0, 506, 4]] is too short
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/thermal/thermal-sensor.example.dt.yaml: thermal-sensor@c265000: interrupt-names: ['uplow'] is too short
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/thermal/thermal-sensor.example.dt.yaml: thermal-sensor@c265000: interrupts: [[0, 507, 4]] is too short
See https://patchwork.ozlabs.org/patch/1242845
Please check and re-submit.
next prev parent reply other threads:[~2020-02-24 18:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-24 7:25 [RFC PATCH v1 0/3] Convert thermal bindings to yaml Amit Kucheria
2020-02-24 7:25 ` [RFC PATCH v1 1/3] dt-bindings: thermal: Add yaml bindings for thermal sensors Amit Kucheria
2020-02-24 18:39 ` Rob Herring [this message]
2020-02-24 7:25 ` [RFC PATCH v1 2/3] dt-bindings: thermal: Add yaml bindings for thermal cooling-devices Amit Kucheria
2020-02-24 7:25 ` [RFC PATCH v1 3/3] dt-bindings: thermal: Add yaml bindings for thermal zones Amit Kucheria
2020-02-24 18:40 ` Rob Herring
2020-03-05 12:50 ` Amit Kucheria
2020-03-05 15:37 ` Rob Herring
2020-03-05 15:43 ` Amit Kucheria
2020-02-24 21:54 ` Rob Herring
2020-03-04 21:02 ` Amit Kucheria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200224183944.GA2201@bogus \
--to=robh@kernel.org \
--cc=amit.kucheria@linaro.org \
--cc=amit.kucheria@verdurent.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mka@chromium.org \
--cc=rui.zhang@intel.com \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.