From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A022EC35DEA for ; Tue, 25 Feb 2020 00:56:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5FB4E21D7E for ; Tue, 25 Feb 2020 00:56:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="fAIIDpEF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728529AbgBYA4D (ORCPT ); Mon, 24 Feb 2020 19:56:03 -0500 Received: from aserp2120.oracle.com ([141.146.126.78]:46830 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728515AbgBYA4C (ORCPT ); Mon, 24 Feb 2020 19:56:02 -0500 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 01P0nELF104389; Tue, 25 Feb 2020 00:55:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=31MRzhnfvXmHfHuyInzX+kikBMRvqfs+ou3IuqKMLEg=; b=fAIIDpEFXGP7aUZmMbxuITAAmMV9SF9AJY+U/9yISYzNWrZqiR16phEQQ+PAvb7NvVPQ epEjRTgrLKhP7owrIhI/PBN8pX1Leaq0aH3RCgyJrQLpr/+ndDaKYxuBgbaAEQmu3bPs KWsaHuLfYGjmjjtJ9Vh2BKnXWXwA8VxKJbcwUymrhBqjXhfH0Oz3bmQDeEDGBt94rrYj dCw+vSo2J4IciQ114D0eXK7j8G0xSk7FTz1Dw6/tZAPIkQcgOsaB2AWrlQZBk1yuJ8mh xm8wIbenHF7bPRg4hJfGWlKXk7n/WmuffmQYTqS/rPM3gLgZahqN0DT1RC1Lwrsbrc2k ZQ== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by aserp2120.oracle.com with ESMTP id 2ybvr4q858-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 25 Feb 2020 00:55:56 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 01P0lvEP116871; Tue, 25 Feb 2020 00:55:55 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userp3020.oracle.com with ESMTP id 2ybe12h2ek-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 25 Feb 2020 00:55:55 +0000 Received: from abhmp0010.oracle.com (abhmp0010.oracle.com [141.146.116.16]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 01P0ts12004722; Tue, 25 Feb 2020 00:55:54 GMT Received: from localhost (/10.159.137.222) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 24 Feb 2020 16:55:53 -0800 Date: Mon, 24 Feb 2020 16:55:53 -0800 From: "Darrick J. Wong" To: Eric Sandeen Cc: linux-xfs , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] xfs: mark ARM OABI as incompatible in Kconfig Message-ID: <20200225005553.GD6740@magnolia> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9541 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 mlxscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2002250003 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9541 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 spamscore=0 clxscore=1011 adultscore=0 lowpriorityscore=0 malwarescore=0 priorityscore=1501 mlxscore=0 impostorscore=0 suspectscore=0 phishscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2002250003 Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Mon, Feb 24, 2020 at 04:49:12PM -0800, Eric Sandeen wrote: > The old ARM OABI's structure alignment quirks break xfs disk structures, > let's just move on and disallow it rather than playing whack-a-mole > for the infrequent times someone selects this old config, which is > usually during "make randconfig" tests. > > Signed-off-by: Eric Sandeen > --- > > diff --git a/fs/xfs/Kconfig b/fs/xfs/Kconfig > index e685299eb3d2..043624bd4ab2 100644 > --- a/fs/xfs/Kconfig > +++ b/fs/xfs/Kconfig > @@ -2,6 +2,8 @@ > config XFS_FS > tristate "XFS filesystem support" > depends on BLOCK > + # We don't support OABI structure alignment on ARM Should this limitation be documented in the help screen? > + depends on (!ARM || AEABI) > select EXPORTFS > select LIBCRC32C > select FS_IOMAP > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E8E6C35DEA for ; Tue, 25 Feb 2020 00:56:08 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6F4CF20838 for ; Tue, 25 Feb 2020 00:56:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="gPNzkq70"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="fAIIDpEF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6F4CF20838 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MnxmlmvEscH5sQriR6kNyr9WCe3taAENkPfYsthpLF8=; b=gPNzkq70E0OzgB Ko8G/1lpxZbjIXZmjgTFMg6Vrxga0tWHBHAnQIcsWUoEW2F+FyP4urrJzAk90PuYPFB8ndtG1GOgX isyKxfEzZBaxfp/R4uZkDj1uVH0wcb5FN9t2nZhBZ9qXTkSmepF/ocpSRzewq/kfUnh3+1m/F/RrK 5IqbcUjr1uChP69a8zo3nW10QGFoY8yye98EJp9ajlnaOdq5U+ld6n5fjGIopFoXJVe5oIL+qUuD+ GUg1tfIWQfQbQN6miI1WNTBkXYap8avI1rmxb22OLVaH9xtlvJfuSAS37aATxbDYOvRjdr1gw6YsO 5AKl6Cy8KguBzdskNXQw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j6OW1-0002M5-8m; Tue, 25 Feb 2020 00:56:01 +0000 Received: from aserp2120.oracle.com ([141.146.126.78]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j6OVy-0002Lf-MS for linux-arm-kernel@lists.infradead.org; Tue, 25 Feb 2020 00:56:00 +0000 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 01P0nELF104389; Tue, 25 Feb 2020 00:55:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=31MRzhnfvXmHfHuyInzX+kikBMRvqfs+ou3IuqKMLEg=; b=fAIIDpEFXGP7aUZmMbxuITAAmMV9SF9AJY+U/9yISYzNWrZqiR16phEQQ+PAvb7NvVPQ epEjRTgrLKhP7owrIhI/PBN8pX1Leaq0aH3RCgyJrQLpr/+ndDaKYxuBgbaAEQmu3bPs KWsaHuLfYGjmjjtJ9Vh2BKnXWXwA8VxKJbcwUymrhBqjXhfH0Oz3bmQDeEDGBt94rrYj dCw+vSo2J4IciQ114D0eXK7j8G0xSk7FTz1Dw6/tZAPIkQcgOsaB2AWrlQZBk1yuJ8mh xm8wIbenHF7bPRg4hJfGWlKXk7n/WmuffmQYTqS/rPM3gLgZahqN0DT1RC1Lwrsbrc2k ZQ== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by aserp2120.oracle.com with ESMTP id 2ybvr4q858-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 25 Feb 2020 00:55:56 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 01P0lvEP116871; Tue, 25 Feb 2020 00:55:55 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userp3020.oracle.com with ESMTP id 2ybe12h2ek-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 25 Feb 2020 00:55:55 +0000 Received: from abhmp0010.oracle.com (abhmp0010.oracle.com [141.146.116.16]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 01P0ts12004722; Tue, 25 Feb 2020 00:55:54 GMT Received: from localhost (/10.159.137.222) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 24 Feb 2020 16:55:53 -0800 Date: Mon, 24 Feb 2020 16:55:53 -0800 From: "Darrick J. Wong" To: Eric Sandeen Subject: Re: [PATCH] xfs: mark ARM OABI as incompatible in Kconfig Message-ID: <20200225005553.GD6740@magnolia> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9541 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 mlxscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2002250003 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9541 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 spamscore=0 clxscore=1011 adultscore=0 lowpriorityscore=0 malwarescore=0 priorityscore=1501 mlxscore=0 impostorscore=0 suspectscore=0 phishscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2002250003 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200224_165558_822243_A576B2EB X-CRM114-Status: GOOD ( 15.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-xfs , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Feb 24, 2020 at 04:49:12PM -0800, Eric Sandeen wrote: > The old ARM OABI's structure alignment quirks break xfs disk structures, > let's just move on and disallow it rather than playing whack-a-mole > for the infrequent times someone selects this old config, which is > usually during "make randconfig" tests. > > Signed-off-by: Eric Sandeen > --- > > diff --git a/fs/xfs/Kconfig b/fs/xfs/Kconfig > index e685299eb3d2..043624bd4ab2 100644 > --- a/fs/xfs/Kconfig > +++ b/fs/xfs/Kconfig > @@ -2,6 +2,8 @@ > config XFS_FS > tristate "XFS filesystem support" > depends on BLOCK > + # We don't support OABI structure alignment on ARM Should this limitation be documented in the help screen? > + depends on (!ARM || AEABI) > select EXPORTFS > select LIBCRC32C > select FS_IOMAP > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel