From: Jonathan Corbet <corbet@lwn.net>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] docs: kref: Clarify the use of two kref_put() in example code
Date: Tue, 25 Feb 2020 03:39:33 -0700 [thread overview]
Message-ID: <20200225033933.190a259d@lwn.net> (raw)
In-Reply-To: <20200219111055.GA4552@mani>
On Wed, 19 Feb 2020 16:40:55 +0530
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> wrote:
> Jakub mistakenly spotted one refcounting issue in one of my patchset:
> https://lkml.org/lkml/2020/2/3/926
>
> Then I tried to show him the kernel doc for kref and that's where I got this
> example code slightly confusing. And while looking into the log, I noticed that
> someone deleted the kref_put in error path mistakenly and that commit got
> reverted after that. This issue was even discussed in stack overflow.
>
> http://stackoverflow.com/questions/20093127/why-kref-doc-of-linux-kernel-omits-kref-put-when-kthread-run-fail
>
> So I thought about making it more clear of why the kref_put is needed in error
> path.
OK, I've applied it, thanks.
jon
prev parent reply other threads:[~2020-02-25 10:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-13 12:53 [PATCH] docs: kref: Clarify the use of two kref_put() in example code Manivannan Sadhasivam
2020-02-19 10:58 ` Jonathan Corbet
2020-02-19 11:10 ` Manivannan Sadhasivam
2020-02-25 10:39 ` Jonathan Corbet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200225033933.190a259d@lwn.net \
--to=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.