From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a19:cb43:0:0:0:0:0 with SMTP id b64csp1376313lfg; Tue, 25 Feb 2020 00:34:22 -0800 (PST) X-Google-Smtp-Source: APXvYqyOKllg1PAmntWUKZMkwbpR641OmSTvohOZCPgtSaMnJAtlZpVmY++GUTDOX6sJD7RoFT0v X-Received: by 2002:aca:5f87:: with SMTP id t129mr2683896oib.36.1582619661973; Tue, 25 Feb 2020 00:34:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582619661; cv=none; d=google.com; s=arc-20160816; b=KNVamlIqE9GmKokT+OYk7G228E6eTp7GIWiqOTTGsemqENuGkIggY/zeSBMOYogcgw jJaGU6bFBETFCUh5BlQIyzMVWpeuoYwkEbBPS+czlxvF1d3c9llde1B7RTQk5ikhS7mJ /TSQCDQe+ZiCppyiMZ273tKAomjCG2okCDAotBDJ4njbRAo2DQxTlHLRMiiVO5BAHY+s SgfhKFSm6+Qbx2W/ezZoO3Gwb7nWxd14uIpC8UqvFE6yPNASqJbBT9SO/2MIbfodug/v z2FhlUOHOO8Or/5RELNfktOhd+CQwQ51aRD4YLcxhLE4ALI5KlAHEneDgBgWtti20N2U I9DQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=Zeq8bfWrbjUWuhe9VoT/P8t5pKlOCkcgFST3tqDuVYU=; b=Qos8xMLsPcVN8Rut0MUhgSadQS386uUUmE1SzxtWIj8Yo5kEx3t8ijbbsl17eJJXE/ r3Du10S8/h8Smla6ZG1P7eBzTmmKTB8DgzKC59JSTQz0lvB62nzhrj95wb3SVs1uYp3E WeK0fmrB5D60xZRMGX5bcAtd1VI5T6e9I7ARcIwsl+wrSnLf5E5KqAI7Z1ayBN7sP2rB VU7Uvdvr/g7kD14Z9ClYzL41mpnr73GH60p0TledWYKyvsaNkihX3kq0yO13EovfnJ/R 4c1DkNIGxknMFBRILBbYhO/WhWSF8qpszjKwLluQaxmybeQugu/Bx5lag+nDzXjkRNdm 0RWA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=P1KgZ9l0; spf=pass (google.com: best guess record for domain of kvm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=kvm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h18si7210320otj.114.2020.02.25.00.34.21; Tue, 25 Feb 2020 00:34:21 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of kvm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=P1KgZ9l0; spf=pass (google.com: best guess record for domain of kvm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=kvm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729332AbgBYIeR (ORCPT + 5 others); Tue, 25 Feb 2020 03:34:17 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:36021 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725783AbgBYIeR (ORCPT ); Tue, 25 Feb 2020 03:34:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582619656; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Zeq8bfWrbjUWuhe9VoT/P8t5pKlOCkcgFST3tqDuVYU=; b=P1KgZ9l0Rql8o6OqicmvbC92lYT9MWGzYsQDlJKBSa0b/V9XVMEHDCvbllSHpcePxrjdpG w6xfduxrhAIjrP5JgLbLnxf7p+gr1c0sp39ngcrDJsTKc3RzTPs5e7QKphGQhifizV78y9 elwXA453iL1ASWRreBmKl6I2gzkj0k8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-204-XRADUvImPiC2RjB3yHQlfg-1; Tue, 25 Feb 2020 03:34:14 -0500 X-MC-Unique: XRADUvImPiC2RjB3yHQlfg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3F4A0800D50; Tue, 25 Feb 2020 08:34:12 +0000 (UTC) Received: from localhost (unknown [10.43.2.114]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7EA3090A04; Tue, 25 Feb 2020 08:34:06 +0000 (UTC) Date: Tue, 25 Feb 2020 09:34:04 +0100 From: Igor Mammedov To: Dongjiu Geng Cc: , , , , , , , , , , , , , , , , Subject: Re: [PATCH v24 02/10] hw/arm/virt: Introduce a RAS machine option Message-ID: <20200225093404.0ee40224@redhat.com> In-Reply-To: <20200217131248.28273-3-gengdongjiu@huawei.com> References: <20200217131248.28273-1-gengdongjiu@huawei.com> <20200217131248.28273-3-gengdongjiu@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org X-TUID: dgtl6bhOafft On Mon, 17 Feb 2020 21:12:40 +0800 Dongjiu Geng wrote: > RAS Virtualization feature is not supported now, so add a RAS machine > option and disable it by default. ^^^^ this doesn't match the patch. I'd rephrase it as: ... feature is disabled by default .. add an option so user could enable it with -machine virt,ras=on > Reviewed-by: Peter Maydell > Signed-off-by: Dongjiu Geng > Signed-off-by: Xiang Zheng > Reviewed-by: Jonathan Cameron > --- > hw/arm/virt.c | 23 +++++++++++++++++++++++ > include/hw/arm/virt.h | 1 + > 2 files changed, 24 insertions(+) > > diff --git a/hw/arm/virt.c b/hw/arm/virt.c > index f788fe2..9555b8b 100644 > --- a/hw/arm/virt.c > +++ b/hw/arm/virt.c > @@ -1823,6 +1823,20 @@ static void virt_set_its(Object *obj, bool value, Error **errp) > vms->its = value; > } > > +static bool virt_get_ras(Object *obj, Error **errp) > +{ > + VirtMachineState *vms = VIRT_MACHINE(obj); > + > + return vms->ras; > +} > + > +static void virt_set_ras(Object *obj, bool value, Error **errp) > +{ > + VirtMachineState *vms = VIRT_MACHINE(obj); > + > + vms->ras = value; > +} > + > static char *virt_get_gic_version(Object *obj, Error **errp) > { > VirtMachineState *vms = VIRT_MACHINE(obj); > @@ -2126,6 +2140,15 @@ static void virt_instance_init(Object *obj) > "Valid values are none and smmuv3", > NULL); > > + /* Default disallows RAS instantiation */ > + vms->ras = false; > + object_property_add_bool(obj, "ras", virt_get_ras, > + virt_set_ras, NULL); > + object_property_set_description(obj, "ras", > + "Set on/off to enable/disable reporting host memory errors " > + "to a KVM guest using ACPI and guest external abort exceptions", > + NULL); > + > vms->irqmap = a15irqmap; > > virt_flash_create(vms); > diff --git a/include/hw/arm/virt.h b/include/hw/arm/virt.h > index 71508bf..c32b7c7 100644 > --- a/include/hw/arm/virt.h > +++ b/include/hw/arm/virt.h > @@ -123,6 +123,7 @@ typedef struct { > bool highmem_ecam; > bool its; > bool virt; > + bool ras; > int32_t gic_version; > VirtIOMMUType iommu; > struct arm_boot_info bootinfo; From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EA69C35DF5 for ; Tue, 25 Feb 2020 08:34:58 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4A53B21744 for ; Tue, 25 Feb 2020 08:34:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="P1KgZ9l0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4A53B21744 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:50538 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6Vg9-0003vh-FT for qemu-devel@archiver.kernel.org; Tue, 25 Feb 2020 03:34:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47317) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6VfY-0003OW-Vh for qemu-devel@nongnu.org; Tue, 25 Feb 2020 03:34:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j6VfV-0002ig-5D for qemu-devel@nongnu.org; Tue, 25 Feb 2020 03:34:20 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:39024 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j6VfV-0002hA-0N for qemu-devel@nongnu.org; Tue, 25 Feb 2020 03:34:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582619656; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Zeq8bfWrbjUWuhe9VoT/P8t5pKlOCkcgFST3tqDuVYU=; b=P1KgZ9l0Rql8o6OqicmvbC92lYT9MWGzYsQDlJKBSa0b/V9XVMEHDCvbllSHpcePxrjdpG w6xfduxrhAIjrP5JgLbLnxf7p+gr1c0sp39ngcrDJsTKc3RzTPs5e7QKphGQhifizV78y9 elwXA453iL1ASWRreBmKl6I2gzkj0k8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-204-XRADUvImPiC2RjB3yHQlfg-1; Tue, 25 Feb 2020 03:34:14 -0500 X-MC-Unique: XRADUvImPiC2RjB3yHQlfg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3F4A0800D50; Tue, 25 Feb 2020 08:34:12 +0000 (UTC) Received: from localhost (unknown [10.43.2.114]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7EA3090A04; Tue, 25 Feb 2020 08:34:06 +0000 (UTC) Date: Tue, 25 Feb 2020 09:34:04 +0100 From: Igor Mammedov To: Dongjiu Geng Subject: Re: [PATCH v24 02/10] hw/arm/virt: Introduce a RAS machine option Message-ID: <20200225093404.0ee40224@redhat.com> In-Reply-To: <20200217131248.28273-3-gengdongjiu@huawei.com> References: <20200217131248.28273-1-gengdongjiu@huawei.com> <20200217131248.28273-3-gengdongjiu@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fam@euphon.net, peter.maydell@linaro.org, xiaoguangrong.eric@gmail.com, kvm@vger.kernel.org, mst@redhat.com, mtosatti@redhat.com, qemu-devel@nongnu.org, ehabkost@redhat.com, shannon.zhaosl@gmail.com, zhengxiang9@huawei.com, qemu-arm@nongnu.org, james.morse@arm.com, shameerali.kolothum.thodi@huawei.com, jonathan.cameron@huawei.com, pbonzini@redhat.com, lersek@redhat.com, rth@twiddle.net Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, 17 Feb 2020 21:12:40 +0800 Dongjiu Geng wrote: > RAS Virtualization feature is not supported now, so add a RAS machine > option and disable it by default. ^^^^ this doesn't match the patch. I'd rephrase it as: ... feature is disabled by default .. add an option so user could enable it with -machine virt,ras=on > Reviewed-by: Peter Maydell > Signed-off-by: Dongjiu Geng > Signed-off-by: Xiang Zheng > Reviewed-by: Jonathan Cameron > --- > hw/arm/virt.c | 23 +++++++++++++++++++++++ > include/hw/arm/virt.h | 1 + > 2 files changed, 24 insertions(+) > > diff --git a/hw/arm/virt.c b/hw/arm/virt.c > index f788fe2..9555b8b 100644 > --- a/hw/arm/virt.c > +++ b/hw/arm/virt.c > @@ -1823,6 +1823,20 @@ static void virt_set_its(Object *obj, bool value, Error **errp) > vms->its = value; > } > > +static bool virt_get_ras(Object *obj, Error **errp) > +{ > + VirtMachineState *vms = VIRT_MACHINE(obj); > + > + return vms->ras; > +} > + > +static void virt_set_ras(Object *obj, bool value, Error **errp) > +{ > + VirtMachineState *vms = VIRT_MACHINE(obj); > + > + vms->ras = value; > +} > + > static char *virt_get_gic_version(Object *obj, Error **errp) > { > VirtMachineState *vms = VIRT_MACHINE(obj); > @@ -2126,6 +2140,15 @@ static void virt_instance_init(Object *obj) > "Valid values are none and smmuv3", > NULL); > > + /* Default disallows RAS instantiation */ > + vms->ras = false; > + object_property_add_bool(obj, "ras", virt_get_ras, > + virt_set_ras, NULL); > + object_property_set_description(obj, "ras", > + "Set on/off to enable/disable reporting host memory errors " > + "to a KVM guest using ACPI and guest external abort exceptions", > + NULL); > + > vms->irqmap = a15irqmap; > > virt_flash_create(vms); > diff --git a/include/hw/arm/virt.h b/include/hw/arm/virt.h > index 71508bf..c32b7c7 100644 > --- a/include/hw/arm/virt.h > +++ b/include/hw/arm/virt.h > @@ -123,6 +123,7 @@ typedef struct { > bool highmem_ecam; > bool its; > bool virt; > + bool ras; > int32_t gic_version; > VirtIOMMUType iommu; > struct arm_boot_info bootinfo;