From: Florian Westphal <fw at strlen.de>
To: mptcp at lists.01.org
Subject: [MPTCP] Re: [PATCH net-next 6/8] mptcp: avoid work queue scheduling if possible
Date: Tue, 25 Feb 2020 13:55:45 +0100 [thread overview]
Message-ID: <20200225125545.GL19559@breakpoint.cc> (raw)
In-Reply-To: 20200225120526.2866-7-fw@strlen.de
[-- Attachment #1: Type: text/plain, Size: 522 bytes --]
Florian Westphal <fw(a)strlen.de> wrote:
> +void mptcp_data_ready(struct sock *sk, struct sock *ssk)
> {
> struct mptcp_sock *msk = mptcp_sk(sk);
>
> set_bit(MPTCP_DATA_READY, &msk->flags);
> sk->sk_data_ready(sk);
>
> + if (atomic_read(&sk->sk_rmem_alloc) < READ_ONCE(sk->sk_rcvbuf) &&
> + move_skbs_to_msk(msk, ssk))
> + return;
> +
It just occured to me that it might be better to move the
sk->sk_data_ready(sk); call to the end of mptcp_data_ready(),
I would do this for next iteration.
next reply other threads:[~2020-02-25 12:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-25 12:55 Florian Westphal [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-02-25 12:51 [MPTCP] Re: [PATCH net-next 6/8] mptcp: avoid work queue scheduling if possible Florian Westphal
2020-02-25 12:40 Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200225125545.GL19559@breakpoint.cc \
--to=unknown@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.