From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFCCEC35E04 for ; Tue, 25 Feb 2020 14:53:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 817F02084E for ; Tue, 25 Feb 2020 14:53:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="LTByP+Hl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730361AbgBYOx2 (ORCPT ); Tue, 25 Feb 2020 09:53:28 -0500 Received: from perceval.ideasonboard.com ([213.167.242.64]:60292 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730264AbgBYOx2 (ORCPT ); Tue, 25 Feb 2020 09:53:28 -0500 Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id A499643F; Tue, 25 Feb 2020 15:53:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1582642405; bh=ot5b8vS8Xbyr8RARRNOMj+IeET1tHlJZ1cxHEkFUO+Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LTByP+Hlga3Kkabs4Wr5vp3lzrbU8OjHRNjv065nyihpW9W4VMdsEg5TwBmiVM4tt yGlYod/f9m4jOX7S1Omgr2tmP59MLIhHAnh7mBFUovKWKkz18gVFLaA77PIxhu/MVI TQkPs4qbGHucnJj6/tCBHHQ2E1TzVelsICE0T/rA= Date: Tue, 25 Feb 2020 16:53:05 +0200 From: Laurent Pinchart To: Sebastian Reichel Cc: Sebastian Reichel , Tomi Valkeinen , Tony Lindgren , Merlijn Wajer , "H. Nikolaus Schaller" , Rob Herring , linux-omap@vger.kernel.org, dri-devel@lists.freedesktop.org, kernel@collabora.com Subject: Re: [PATCHv2 09/56] drm/omap: dsi: unexport specific data transfer functions Message-ID: <20200225145305.GH4764@pendragon.ideasonboard.com> References: <20200224232126.3385250-1-sebastian.reichel@collabora.com> <20200224232126.3385250-10-sebastian.reichel@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200224232126.3385250-10-sebastian.reichel@collabora.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org Hi Sebastian, Thank you for the patch. On Tue, Feb 25, 2020 at 12:20:39AM +0100, Sebastian Reichel wrote: > After converting all DSI drivers, unexport the specific transfer > functions. > > Signed-off-by: Sebastian Reichel Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/omapdrm/dss/dsi.c | 12 ------------ > drivers/gpu/drm/omapdrm/dss/omapdss.h | 20 -------------------- > 2 files changed, 32 deletions(-) > > diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/dss/dsi.c > index 84e2eb0b51d7..0990777a42f7 100644 > --- a/drivers/gpu/drm/omapdrm/dss/dsi.c > +++ b/drivers/gpu/drm/omapdrm/dss/dsi.c > @@ -4941,18 +4941,6 @@ static const struct omap_dss_device_ops dsi_ops = { > .release_vc = dsi_release_vc, > > .transfer = omap_dsi_transfer, > - > - .dcs_write = dsi_vc_dcs_write, > - .dcs_write_nosync = dsi_vc_dcs_write_nosync, > - .dcs_read = dsi_vc_dcs_read, > - > - .gen_write = dsi_vc_generic_write, > - .gen_write_nosync = dsi_vc_generic_write_nosync, > - .gen_read = dsi_vc_generic_read, > - > - .bta_sync = dsi_vc_send_bta_sync, > - > - .set_max_rx_packet_size = dsi_vc_set_max_rx_packet_size, > }, > }; > > diff --git a/drivers/gpu/drm/omapdrm/dss/omapdss.h b/drivers/gpu/drm/omapdrm/dss/omapdss.h > index ea7bf0970677..787e102eb068 100644 > --- a/drivers/gpu/drm/omapdrm/dss/omapdss.h > +++ b/drivers/gpu/drm/omapdrm/dss/omapdss.h > @@ -309,26 +309,6 @@ struct omapdss_dsi_ops { > /* data transfer */ > ssize_t (*transfer)(struct omap_dss_device *dssdev, > const struct mipi_dsi_msg *msg); > - > - int (*dcs_write)(struct omap_dss_device *dssdev, int channel, > - const u8 *data, int len); > - int (*dcs_write_nosync)(struct omap_dss_device *dssdev, int channel, > - const u8 *data, int len); > - int (*dcs_read)(struct omap_dss_device *dssdev, int channel, u8 dcs_cmd, > - u8 *data, int len); > - > - int (*gen_write)(struct omap_dss_device *dssdev, int channel, > - const u8 *data, int len); > - int (*gen_write_nosync)(struct omap_dss_device *dssdev, int channel, > - const u8 *data, int len); > - int (*gen_read)(struct omap_dss_device *dssdev, int channel, > - const u8 *reqdata, int reqlen, > - u8 *data, int len); > - > - int (*bta_sync)(struct omap_dss_device *dssdev, int channel); > - > - int (*set_max_rx_packet_size)(struct omap_dss_device *dssdev, > - int channel, u16 plen); > }; > > struct omap_dss_device_ops { -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D146C35E01 for ; Tue, 25 Feb 2020 14:53:29 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 33AFF2084E for ; Tue, 25 Feb 2020 14:53:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="LTByP+Hl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 33AFF2084E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9FC5B6EB0B; Tue, 25 Feb 2020 14:53:28 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8DBC86EB0B for ; Tue, 25 Feb 2020 14:53:27 +0000 (UTC) Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id A499643F; Tue, 25 Feb 2020 15:53:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1582642405; bh=ot5b8vS8Xbyr8RARRNOMj+IeET1tHlJZ1cxHEkFUO+Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LTByP+Hlga3Kkabs4Wr5vp3lzrbU8OjHRNjv065nyihpW9W4VMdsEg5TwBmiVM4tt yGlYod/f9m4jOX7S1Omgr2tmP59MLIhHAnh7mBFUovKWKkz18gVFLaA77PIxhu/MVI TQkPs4qbGHucnJj6/tCBHHQ2E1TzVelsICE0T/rA= Date: Tue, 25 Feb 2020 16:53:05 +0200 From: Laurent Pinchart To: Sebastian Reichel Subject: Re: [PATCHv2 09/56] drm/omap: dsi: unexport specific data transfer functions Message-ID: <20200225145305.GH4764@pendragon.ideasonboard.com> References: <20200224232126.3385250-1-sebastian.reichel@collabora.com> <20200224232126.3385250-10-sebastian.reichel@collabora.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200224232126.3385250-10-sebastian.reichel@collabora.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel@collabora.com, Tony Lindgren , "H. Nikolaus Schaller" , Merlijn Wajer , Sebastian Reichel , dri-devel@lists.freedesktop.org, Tomi Valkeinen , linux-omap@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Sebastian, Thank you for the patch. On Tue, Feb 25, 2020 at 12:20:39AM +0100, Sebastian Reichel wrote: > After converting all DSI drivers, unexport the specific transfer > functions. > > Signed-off-by: Sebastian Reichel Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/omapdrm/dss/dsi.c | 12 ------------ > drivers/gpu/drm/omapdrm/dss/omapdss.h | 20 -------------------- > 2 files changed, 32 deletions(-) > > diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/dss/dsi.c > index 84e2eb0b51d7..0990777a42f7 100644 > --- a/drivers/gpu/drm/omapdrm/dss/dsi.c > +++ b/drivers/gpu/drm/omapdrm/dss/dsi.c > @@ -4941,18 +4941,6 @@ static const struct omap_dss_device_ops dsi_ops = { > .release_vc = dsi_release_vc, > > .transfer = omap_dsi_transfer, > - > - .dcs_write = dsi_vc_dcs_write, > - .dcs_write_nosync = dsi_vc_dcs_write_nosync, > - .dcs_read = dsi_vc_dcs_read, > - > - .gen_write = dsi_vc_generic_write, > - .gen_write_nosync = dsi_vc_generic_write_nosync, > - .gen_read = dsi_vc_generic_read, > - > - .bta_sync = dsi_vc_send_bta_sync, > - > - .set_max_rx_packet_size = dsi_vc_set_max_rx_packet_size, > }, > }; > > diff --git a/drivers/gpu/drm/omapdrm/dss/omapdss.h b/drivers/gpu/drm/omapdrm/dss/omapdss.h > index ea7bf0970677..787e102eb068 100644 > --- a/drivers/gpu/drm/omapdrm/dss/omapdss.h > +++ b/drivers/gpu/drm/omapdrm/dss/omapdss.h > @@ -309,26 +309,6 @@ struct omapdss_dsi_ops { > /* data transfer */ > ssize_t (*transfer)(struct omap_dss_device *dssdev, > const struct mipi_dsi_msg *msg); > - > - int (*dcs_write)(struct omap_dss_device *dssdev, int channel, > - const u8 *data, int len); > - int (*dcs_write_nosync)(struct omap_dss_device *dssdev, int channel, > - const u8 *data, int len); > - int (*dcs_read)(struct omap_dss_device *dssdev, int channel, u8 dcs_cmd, > - u8 *data, int len); > - > - int (*gen_write)(struct omap_dss_device *dssdev, int channel, > - const u8 *data, int len); > - int (*gen_write_nosync)(struct omap_dss_device *dssdev, int channel, > - const u8 *data, int len); > - int (*gen_read)(struct omap_dss_device *dssdev, int channel, > - const u8 *reqdata, int reqlen, > - u8 *data, int len); > - > - int (*bta_sync)(struct omap_dss_device *dssdev, int channel); > - > - int (*set_max_rx_packet_size)(struct omap_dss_device *dssdev, > - int channel, u16 plen); > }; > > struct omap_dss_device_ops { -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel