From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a19:cb43:0:0:0:0:0 with SMTP id b64csp1919262lfg; Tue, 25 Feb 2020 08:59:31 -0800 (PST) X-Google-Smtp-Source: APXvYqyIsz8Qdy1NqP3bYxSueL6ELSBz+e1oVVoX/XbG0B1/zOmDkiiLlcauRVvwo6BdkGKXGp/Y X-Received: by 2002:a9d:5e8b:: with SMTP id f11mr32551710otl.110.1582649971391; Tue, 25 Feb 2020 08:59:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582649971; cv=none; d=google.com; s=arc-20160816; b=AmKMFp64mJNIbrdJ3BOyFJe/TtaPykXimG0rLGAAkToRTPR03uHNEe0kkBzNsP6f8M rXQL2lZcK/r0BTzIQ1tqBMLiZ3aIFs5nLPSZyvdlZ6wiVrz3JrvMWTfAUp1uC8ooMddv mgaLPxwPHApXN1Jhe0dxBRyQKXwlC/zoDZLRJb78eW9XTz0dAvgGLTsIQiYaevFMzFyj hGp6Wf1Weze9FvXM/AeZ0df5Hwoz94BvTA4a6Ze7W0fWBqyAvtteNFAFbEJMpExAWwYD yySG1yCRCK/nkE99YtilMrf6sNAw2mvxircFMXi3vbQWsh1ANoS9ciTyviic8RB/b0Tr mGmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=TjwoM0/StVfrn5wh2Yyffw44qkAt+KuH9t4IFN7loIA=; b=kV/CTJ+OeJvsvIcFeoBSTfhh00l6N4WU8xzwB5i6MP9Y2f7xzEKrjTFo0H6X0REKX5 26YVpKt+mrNP3cdNRpsUlFhaNj7DbxvT7T5eTmFda5Zn6rptmE8xj9NHwPVh5oXO6n8X NVBtuCdForrLBCSYbyLTq9ikROjJJcguczwEH/be+DID50h+3Dd6TpbwNrT21X2+8VJ4 IE27Ko2AF6dmWXdUwgfcALue8jz+mbzWlDyI3nMJZA8JWjB8IaiHvgGwdPFSEhCAZOnR sdHvNQAUXqHg3xkdYOvFdfrQOwR1GA8PMAvTrC1s9D8iEcr7hERPvOPDRPMkkKEGykBF e9yg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=LJLhK4Pc; spf=pass (google.com: best guess record for domain of kvm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=kvm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e9si8479071otk.318.2020.02.25.08.59.31; Tue, 25 Feb 2020 08:59:31 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of kvm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=LJLhK4Pc; spf=pass (google.com: best guess record for domain of kvm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=kvm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729913AbgBYQ7a (ORCPT + 5 others); Tue, 25 Feb 2020 11:59:30 -0500 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:39716 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728051AbgBYQ7a (ORCPT ); Tue, 25 Feb 2020 11:59:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582649969; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TjwoM0/StVfrn5wh2Yyffw44qkAt+KuH9t4IFN7loIA=; b=LJLhK4Pc7nTo4TFcYmZN3bMMOEwHlccghJMOfjxbX8myvrdvBJBuYJ+kNbG2Zd5q38SE9I 0lA0QW63xIl4EU5KjaaZ99LwVQY3BGzUfLFTnIV7ix8ba6qCT0dv0KTkdPZgv920upVC8A +ABq9dpEIx43qzCtui/CjUDXgzWeHSw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-418-gdSoGWxPPvK1FVQkeAeWDQ-1; Tue, 25 Feb 2020 11:59:27 -0500 X-MC-Unique: gdSoGWxPPvK1FVQkeAeWDQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6A9751005F72; Tue, 25 Feb 2020 16:59:25 +0000 (UTC) Received: from localhost (unknown [10.43.2.114]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8651590F5F; Tue, 25 Feb 2020 16:59:19 +0000 (UTC) Date: Tue, 25 Feb 2020 17:59:18 +0100 From: Igor Mammedov To: gengdongjiu Cc: Peter Maydell , Fam Zheng , Xiao Guangrong , kvm-devel , "Michael S. Tsirkin" , Marcelo Tosatti , QEMU Developers , Eduardo Habkost , Shannon Zhao , Zheng Xiang , qemu-arm , James Morse , "Shameerali Kolothum Thodi" , Jonathan Cameron , Paolo Bonzini , Laszlo Ersek , "Richard Henderson" Subject: Re: [PATCH v24 00/10] Add ARMv8 RAS virtualization support in QEMU Message-ID: <20200225175918.5a81506f@redhat.com> In-Reply-To: References: <20200217131248.28273-1-gengdongjiu@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org X-TUID: +V6zE7ektIQY On Mon, 24 Feb 2020 16:37:44 +0800 gengdongjiu wrote: > On 2020/2/21 22:09, Peter Maydell wrote: > > On Mon, 17 Feb 2020 at 13:10, Dongjiu Geng wrote: > >> > >> In the ARMv8 platform, the CPU error types includes synchronous external abort(SEA) and SError Interrupt (SEI). If exception happens in guest, host does not know the detailed information of guest, so it is expected that guest can do the recovery. > >> For example, if an exception happens in a guest user-space application, host does > >> not know which application encounters errors, only guest knows it. > >> > >> For the ARMv8 SEA/SEI, KVM or host kernel delivers SIGBUS to notify userspace. > >> After user space gets the notification, it will record the CPER into guest GHES > >> buffer and inject an exception or IRQ to guest. > >> > >> In the current implementation, if the type of SIGBUS is BUS_MCEERR_AR, we will > >> treat it as a synchronous exception, and notify guest with ARMv8 SEA > >> notification type after recording CPER into guest. > > > > Hi; I have reviewed the remaining arm bit of this series (patch 9), > > and made some comments on patch 1. Still to be reviewed are > > patches 4, 5, 6, 8: I'm going to assume that Michael or Igor > > will look at those. > > Thanks very much for Peter's review. > Michael/Igor, hope you can review patches 4, 5, 6, 8, thank you very much in advance. done > > > > thanks > > -- PMM > > > > . > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC6A2C35E01 for ; Tue, 25 Feb 2020 17:03:08 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9A8512082F for ; Tue, 25 Feb 2020 17:03:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="LJLhK4Pc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9A8512082F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:60556 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6dbv-0001sv-MW for qemu-devel@archiver.kernel.org; Tue, 25 Feb 2020 12:03:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44872) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6dYQ-00072R-Ru for qemu-devel@nongnu.org; Tue, 25 Feb 2020 11:59:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j6dYP-0003jx-RS for qemu-devel@nongnu.org; Tue, 25 Feb 2020 11:59:30 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:41972 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j6dYP-0003jd-MJ for qemu-devel@nongnu.org; Tue, 25 Feb 2020 11:59:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582649969; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TjwoM0/StVfrn5wh2Yyffw44qkAt+KuH9t4IFN7loIA=; b=LJLhK4Pc7nTo4TFcYmZN3bMMOEwHlccghJMOfjxbX8myvrdvBJBuYJ+kNbG2Zd5q38SE9I 0lA0QW63xIl4EU5KjaaZ99LwVQY3BGzUfLFTnIV7ix8ba6qCT0dv0KTkdPZgv920upVC8A +ABq9dpEIx43qzCtui/CjUDXgzWeHSw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-418-gdSoGWxPPvK1FVQkeAeWDQ-1; Tue, 25 Feb 2020 11:59:27 -0500 X-MC-Unique: gdSoGWxPPvK1FVQkeAeWDQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6A9751005F72; Tue, 25 Feb 2020 16:59:25 +0000 (UTC) Received: from localhost (unknown [10.43.2.114]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8651590F5F; Tue, 25 Feb 2020 16:59:19 +0000 (UTC) Date: Tue, 25 Feb 2020 17:59:18 +0100 From: Igor Mammedov To: gengdongjiu Subject: Re: [PATCH v24 00/10] Add ARMv8 RAS virtualization support in QEMU Message-ID: <20200225175918.5a81506f@redhat.com> In-Reply-To: References: <20200217131248.28273-1-gengdongjiu@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Peter Maydell , Xiao Guangrong , kvm-devel , "Michael S. Tsirkin" , Marcelo Tosatti , QEMU Developers , Shameerali Kolothum Thodi , Shannon Zhao , Zheng Xiang , qemu-arm , James Morse , Jonathan Cameron , Paolo Bonzini , Richard Henderson , Laszlo Ersek , Eduardo Habkost Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, 24 Feb 2020 16:37:44 +0800 gengdongjiu wrote: > On 2020/2/21 22:09, Peter Maydell wrote: > > On Mon, 17 Feb 2020 at 13:10, Dongjiu Geng wrote: > >> > >> In the ARMv8 platform, the CPU error types includes synchronous external abort(SEA) and SError Interrupt (SEI). If exception happens in guest, host does not know the detailed information of guest, so it is expected that guest can do the recovery. > >> For example, if an exception happens in a guest user-space application, host does > >> not know which application encounters errors, only guest knows it. > >> > >> For the ARMv8 SEA/SEI, KVM or host kernel delivers SIGBUS to notify userspace. > >> After user space gets the notification, it will record the CPER into guest GHES > >> buffer and inject an exception or IRQ to guest. > >> > >> In the current implementation, if the type of SIGBUS is BUS_MCEERR_AR, we will > >> treat it as a synchronous exception, and notify guest with ARMv8 SEA > >> notification type after recording CPER into guest. > > > > Hi; I have reviewed the remaining arm bit of this series (patch 9), > > and made some comments on patch 1. Still to be reviewed are > > patches 4, 5, 6, 8: I'm going to assume that Michael or Igor > > will look at those. > > Thanks very much for Peter's review. > Michael/Igor, hope you can review patches 4, 5, 6, 8, thank you very much in advance. done > > > > thanks > > -- PMM > > > > . > > >