From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3F9CC4BA06 for ; Tue, 25 Feb 2020 23:23:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 82F0020732 for ; Tue, 25 Feb 2020 23:23:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="QamDRN5G" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729042AbgBYXXx (ORCPT ); Tue, 25 Feb 2020 18:23:53 -0500 Received: from pandora.armlinux.org.uk ([78.32.30.218]:37556 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728806AbgBYXXx (ORCPT ); Tue, 25 Feb 2020 18:23:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=1NdWXTtNvNHAGbogy1ZnStwT/++LxICWN164u7rzZr0=; b=QamDRN5GaQqQYbFgMUSdUvUca r3BzD0vUxPtIciEzVXv78nEdi9xBi0AsyCqmDkIcvJ3VLdQeP+OYByQEOa5O2ATfacbKFCcxH7WHP ovBCb0GPhZmW0vzRGgT3XNKehBDXuxYq80Y59w4aGhrLgHjR3Uxi/M8coJZX1E25yPxPIyV3ml1Pp tAZo8Coyep9kRHGO39lxQL8WuOYVz6Ovqtwf8OGZev5JspePoiWie/XOovtBX4wDAj68eyTRRhQty eAjUHMEYKPHQKeWL36pLZe0p75WLRZVRV1iyv9dIBICj49Jp8dNSKhS5I0966IDmyv4hhe61oNASt FP58W0TVQ==; Received: from shell.armlinux.org.uk ([2002:4e20:1eda:1:5054:ff:fe00:4ec]:52756) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1j6jXq-0003pP-Oq; Tue, 25 Feb 2020 23:23:18 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1j6jXf-0007oA-TF; Tue, 25 Feb 2020 23:23:07 +0000 Date: Tue, 25 Feb 2020 23:23:07 +0000 From: Russell King - ARM Linux admin To: Vladimir Oltean Cc: Andrew Lunn , Florian Fainelli , Heiner Kallweit , Alexandre Torgue , "David S. Miller" , Felix Fietkau , Giuseppe Cavallaro , Hauke Mehrtens , Ioana Ciornei , Jakub Kicinski , John Crispin , Jonathan Corbet , Jose Abreu , "moderated list:ARM/Mediatek SoC support" , Linux Doc Mailing List , "moderated list:ARM/Mediatek SoC support" , linux-stm32@st-md-mailman.stormreply.com, Mark Lee , Matthias Brugger , Maxime Coquelin , Michal Simek , netdev , Nicolas Ferre , Radhey Shyam Pandey , Sean Wang , Thomas Petazzoni , Vivien Didelot Subject: Re: [PATCH net-next 2/8] net: dsa: propagate resolved link config via mac_link_up() Message-ID: <20200225232307.GU25745@shell.armlinux.org.uk> References: <20200225093703.GS25745@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Tue, Feb 25, 2020 at 11:09:35PM +0200, Vladimir Oltean wrote: > Hi Russell, > > On Tue, 25 Feb 2020 at 11:39, Russell King wrote: > > > > Propagate the resolved link configuration down via DSA's > > phylink_mac_link_up() operation to allow split PCS/MAC to work. > > > > Signed-off-by: Russell King > > --- > > drivers/net/dsa/b53/b53_common.c | 4 +++- > > drivers/net/dsa/b53/b53_priv.h | 4 +++- > > drivers/net/dsa/bcm_sf2.c | 4 +++- > > drivers/net/dsa/lantiq_gswip.c | 4 +++- > > drivers/net/dsa/mt7530.c | 4 +++- > > drivers/net/dsa/mv88e6xxx/chip.c | 4 +++- > > drivers/net/dsa/sja1105/sja1105_main.c | 4 +++- > > include/net/dsa.h | 4 +++- > > net/dsa/port.c | 3 ++- > > 9 files changed, 26 insertions(+), 9 deletions(-) > > > > It looks like you missed the felix_phylink_mac_link_up() conversion in > this patch? (which also makes it fail to build, by the way, I'm > supposed the Kbuild robot didn't already jump) > Nonetheless, I've manually added the missing speed, duplex, tx_pause > and rx_pause parameters, and it appears to work as before. > Same for sja1105. Quite possibly; the patch was developed against 5.5 plus the phylink changes, but applied to net-next. Hmm, it seems my coccinelle script that detects .mac_link_up initialiser prototypes, but not the DSA equivalent using the old prototype. Thanks for pointing it out. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B35B1C4BA04 for ; Tue, 25 Feb 2020 23:24:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8706720732 for ; Tue, 25 Feb 2020 23:24:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="QpR1M87o"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="QamDRN5G" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8706720732 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1xjNwoAFxiHKfOO6qgl7A3fQDrEgDQ+DX8XHQObFQP8=; b=QpR1M87o9nvYeF GTYbCg2iTegbw178ZN6pH0ujm6SmHW8H8dSWn7DPnfO2PXGIM/Dqd3t5pH9jExQgwxvEMkF0DPpXs b+XyjnJNkYY64soKFz2DQa11C13LxCHR8LSFHcZrl1lTjLqVNLFzis8v33Dvwlykoy4PrfcN8Dq4o aamCRv4jEvh0Jcfra8x8Q2p+cgSM/of10mIGC1BPzP6GH2NPxoeukIv2/KgQR9QOkxyEbN2QTiqZQ xbNNrnlhpMmmObXcqmTW99hyOzuzEP6xPpgMCCKihSVlgc76kUFcxAmqel6RnR/Et5DH8IpQRen20 Pn98RHVbeU9M3qIwbuDA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j6jYh-0007TE-5z; Tue, 25 Feb 2020 23:24:11 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:3201:214:fdff:fe10:1be6]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j6jYX-0007J5-JE; Tue, 25 Feb 2020 23:24:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=1NdWXTtNvNHAGbogy1ZnStwT/++LxICWN164u7rzZr0=; b=QamDRN5GaQqQYbFgMUSdUvUca r3BzD0vUxPtIciEzVXv78nEdi9xBi0AsyCqmDkIcvJ3VLdQeP+OYByQEOa5O2ATfacbKFCcxH7WHP ovBCb0GPhZmW0vzRGgT3XNKehBDXuxYq80Y59w4aGhrLgHjR3Uxi/M8coJZX1E25yPxPIyV3ml1Pp tAZo8Coyep9kRHGO39lxQL8WuOYVz6Ovqtwf8OGZev5JspePoiWie/XOovtBX4wDAj68eyTRRhQty eAjUHMEYKPHQKeWL36pLZe0p75WLRZVRV1iyv9dIBICj49Jp8dNSKhS5I0966IDmyv4hhe61oNASt FP58W0TVQ==; Received: from shell.armlinux.org.uk ([2002:4e20:1eda:1:5054:ff:fe00:4ec]:52756) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1j6jXq-0003pP-Oq; Tue, 25 Feb 2020 23:23:18 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1j6jXf-0007oA-TF; Tue, 25 Feb 2020 23:23:07 +0000 Date: Tue, 25 Feb 2020 23:23:07 +0000 From: Russell King - ARM Linux admin To: Vladimir Oltean Subject: Re: [PATCH net-next 2/8] net: dsa: propagate resolved link config via mac_link_up() Message-ID: <20200225232307.GU25745@shell.armlinux.org.uk> References: <20200225093703.GS25745@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200225_152401_633818_2584FA56 X-CRM114-Status: GOOD ( 16.75 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Linux Doc Mailing List , Thomas Petazzoni , Ioana Ciornei , linux-stm32@st-md-mailman.stormreply.com, Florian Fainelli , Jonathan Corbet , Michal Simek , Jose Abreu , Jakub Kicinski , Mark Lee , Sean Wang , Alexandre Torgue , Hauke Mehrtens , Radhey Shyam Pandey , "moderated list:ARM/Mediatek SoC support" , John Crispin , Matthias Brugger , Giuseppe Cavallaro , "moderated list:ARM/Mediatek SoC support" , netdev , Nicolas Ferre , Vivien Didelot , Maxime Coquelin , Felix Fietkau , "David S. Miller" , Heiner Kallweit Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Tue, Feb 25, 2020 at 11:09:35PM +0200, Vladimir Oltean wrote: > Hi Russell, > > On Tue, 25 Feb 2020 at 11:39, Russell King wrote: > > > > Propagate the resolved link configuration down via DSA's > > phylink_mac_link_up() operation to allow split PCS/MAC to work. > > > > Signed-off-by: Russell King > > --- > > drivers/net/dsa/b53/b53_common.c | 4 +++- > > drivers/net/dsa/b53/b53_priv.h | 4 +++- > > drivers/net/dsa/bcm_sf2.c | 4 +++- > > drivers/net/dsa/lantiq_gswip.c | 4 +++- > > drivers/net/dsa/mt7530.c | 4 +++- > > drivers/net/dsa/mv88e6xxx/chip.c | 4 +++- > > drivers/net/dsa/sja1105/sja1105_main.c | 4 +++- > > include/net/dsa.h | 4 +++- > > net/dsa/port.c | 3 ++- > > 9 files changed, 26 insertions(+), 9 deletions(-) > > > > It looks like you missed the felix_phylink_mac_link_up() conversion in > this patch? (which also makes it fail to build, by the way, I'm > supposed the Kbuild robot didn't already jump) > Nonetheless, I've manually added the missing speed, duplex, tx_pause > and rx_pause parameters, and it appears to work as before. > Same for sja1105. Quite possibly; the patch was developed against 5.5 plus the phylink changes, but applied to net-next. Hmm, it seems my coccinelle script that detects .mac_link_up initialiser prototypes, but not the DSA equivalent using the old prototype. Thanks for pointing it out. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AF7BC4BA06 for ; Tue, 25 Feb 2020 23:24:13 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6B4EC20732 for ; Tue, 25 Feb 2020 23:24:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="mfyNg5Zs"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="QamDRN5G" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6B4EC20732 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FnGkLuur3K/zhgjPNwLn28c+kdRMzaYZkbAVfSIIKrk=; b=mfyNg5ZsQIVX71 o8RoZpb7dK/8OLTpsm0bc50tWZLGJvbFpbqmsmLrWEXch/xJnXmRWnIJa3SuD+osWiWn5imQytkX6 y43FDC/Gx2Aeduh3XFnElj7Sy4YvTBywBrZGMvMMcXPCYb0pd7N7TLuO8oPNqxjBhLJuDOTVW+wbU LzpcMsMILU+rnQj4FA0amKRkQ3IygLiegZ/en1rbnC/TaQ5p/ZWuATNNU4VXkLbR0/du5RyVHXvjB pE5dNdKkaUxTzn4c15J380RoZ9Fwo/ilzrFqcNEle5nL3G9Kh9ydEqx/OQK0d4W8FAeKFfK5P48ZB 0sqytjrL2AkiELIvL2EQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j6jYa-0007Ki-Sa; Tue, 25 Feb 2020 23:24:04 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:3201:214:fdff:fe10:1be6]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j6jYX-0007J5-JE; Tue, 25 Feb 2020 23:24:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=1NdWXTtNvNHAGbogy1ZnStwT/++LxICWN164u7rzZr0=; b=QamDRN5GaQqQYbFgMUSdUvUca r3BzD0vUxPtIciEzVXv78nEdi9xBi0AsyCqmDkIcvJ3VLdQeP+OYByQEOa5O2ATfacbKFCcxH7WHP ovBCb0GPhZmW0vzRGgT3XNKehBDXuxYq80Y59w4aGhrLgHjR3Uxi/M8coJZX1E25yPxPIyV3ml1Pp tAZo8Coyep9kRHGO39lxQL8WuOYVz6Ovqtwf8OGZev5JspePoiWie/XOovtBX4wDAj68eyTRRhQty eAjUHMEYKPHQKeWL36pLZe0p75WLRZVRV1iyv9dIBICj49Jp8dNSKhS5I0966IDmyv4hhe61oNASt FP58W0TVQ==; Received: from shell.armlinux.org.uk ([2002:4e20:1eda:1:5054:ff:fe00:4ec]:52756) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1j6jXq-0003pP-Oq; Tue, 25 Feb 2020 23:23:18 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1j6jXf-0007oA-TF; Tue, 25 Feb 2020 23:23:07 +0000 Date: Tue, 25 Feb 2020 23:23:07 +0000 From: Russell King - ARM Linux admin To: Vladimir Oltean Subject: Re: [PATCH net-next 2/8] net: dsa: propagate resolved link config via mac_link_up() Message-ID: <20200225232307.GU25745@shell.armlinux.org.uk> References: <20200225093703.GS25745@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200225_152401_633818_2584FA56 X-CRM114-Status: GOOD ( 16.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Linux Doc Mailing List , Thomas Petazzoni , Ioana Ciornei , linux-stm32@st-md-mailman.stormreply.com, Florian Fainelli , Jonathan Corbet , Michal Simek , Jose Abreu , Jakub Kicinski , Mark Lee , Sean Wang , Alexandre Torgue , Hauke Mehrtens , Radhey Shyam Pandey , "moderated list:ARM/Mediatek SoC support" , John Crispin , Matthias Brugger , Giuseppe Cavallaro , "moderated list:ARM/Mediatek SoC support" , netdev , Vivien Didelot , Maxime Coquelin , Felix Fietkau , "David S. Miller" , Heiner Kallweit Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Feb 25, 2020 at 11:09:35PM +0200, Vladimir Oltean wrote: > Hi Russell, > > On Tue, 25 Feb 2020 at 11:39, Russell King wrote: > > > > Propagate the resolved link configuration down via DSA's > > phylink_mac_link_up() operation to allow split PCS/MAC to work. > > > > Signed-off-by: Russell King > > --- > > drivers/net/dsa/b53/b53_common.c | 4 +++- > > drivers/net/dsa/b53/b53_priv.h | 4 +++- > > drivers/net/dsa/bcm_sf2.c | 4 +++- > > drivers/net/dsa/lantiq_gswip.c | 4 +++- > > drivers/net/dsa/mt7530.c | 4 +++- > > drivers/net/dsa/mv88e6xxx/chip.c | 4 +++- > > drivers/net/dsa/sja1105/sja1105_main.c | 4 +++- > > include/net/dsa.h | 4 +++- > > net/dsa/port.c | 3 ++- > > 9 files changed, 26 insertions(+), 9 deletions(-) > > > > It looks like you missed the felix_phylink_mac_link_up() conversion in > this patch? (which also makes it fail to build, by the way, I'm > supposed the Kbuild robot didn't already jump) > Nonetheless, I've manually added the missing speed, duplex, tx_pause > and rx_pause parameters, and it appears to work as before. > Same for sja1105. Quite possibly; the patch was developed against 5.5 plus the phylink changes, but applied to net-next. Hmm, it seems my coccinelle script that detects .mac_link_up initialiser prototypes, but not the DSA equivalent using the old prototype. Thanks for pointing it out. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel