From: Prashant Malani <pmalani@chromium.org>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc: linux-kernel@vger.kernel.org,
Collabora Kernel ML <kernel@collabora.com>,
groeck@chromium.org, bleung@chromium.org, dtor@chromium.org,
gwendal@chromium.org, Enrico Granata <egranata@chromium.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Ting Shen <phoenixshen@chromium.org>,
Lee Jones <lee.jones@linaro.org>,
Neil Armstrong <narmstrong@baylibre.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Fei Shao <fshao@chromium.org>, Pi-Hsun Shih <pihsun@chromium.org>,
Evan Green <evgreen@chromium.org>,
linux-input@vger.kernel.org
Subject: Re: [PATCH 0/8] Migrate all cros_ec_cmd_xfer() calls to cros_ec_cmd_xfer_status()
Date: Tue, 25 Feb 2020 17:12:08 -0800 [thread overview]
Message-ID: <20200226011208.GD197302@google.com> (raw)
In-Reply-To: <20200220155859.906647-1-enric.balletbo@collabora.com>
On Thu, Feb 20, 2020 at 04:58:51PM +0100, Enric Balletbo i Serra wrote:
> Dear all,
>
> The purpose of this series is get rid of the remaining places where the
> cros_ec_cmd_xfer() function is used in favour of the
> cros_ec_cmd_xfer_status() helper. This allows us to make the
> cros_ec_cmd_xfer() function private and only expose to the users a
> single way to send commands to the Embedded Controller.
>
> With these changes we also want to help future improvements in the
> interface, like the Prashant's series (i.e [1]) to introduce a
> cros_ec_cmd() that will allow us to remove more duplicated code in
> different places.
>
> Best regards,
> Enric
>
> Note: Prashant, looks like you should fix your sendmail as the patches
> are not threaded.
>
> [1] https://lkml.org/lkml/2020/2/5/614
>
> Enric Balletbo i Serra (8):
> platform/chrome: cros_ec_proto: Report command not supported
> Input: cros_ec_keyb: Use cros_ec_cmd_xfer_status helper
> platform/chrome: cros_ec_vbc: Use cros_ec_cmd_xfer_status helper
> platform/chrome: cros_ec_chardev: Use cros_ec_cmd_xfer_status helper
> platform/chrome: cros_ec_sysfs: Use cros_ec_cmd_xfer_status helper
> platform/chrome: cros_ec_lightbar: Use cros_ec_cmd_xfer_status helper
> platform/chrome: cros_ec: Use cros_ec_cmd_xfer_status helper
> platform/chrome: cros_ec_proto: Do not export cros_ec_cmd_xfer()
I picked this series on a device running 4.19 and didn't see any
unusual behaviour or dmesg logs, so for the entire series:
Tested-by: Prashant Malani <pmalani@chromium.org>
>
> drivers/input/keyboard/cros_ec_keyb.c | 14 +++---
> drivers/platform/chrome/cros_ec.c | 2 +-
> drivers/platform/chrome/cros_ec_chardev.c | 2 +-
> drivers/platform/chrome/cros_ec_lightbar.c | 50 ++++++---------------
> drivers/platform/chrome/cros_ec_proto.c | 14 ++++--
> drivers/platform/chrome/cros_ec_sysfs.c | 36 +++++++--------
> drivers/platform/chrome/cros_ec_vbc.c | 4 +-
> include/linux/platform_data/cros_ec_proto.h | 3 --
> 8 files changed, 50 insertions(+), 75 deletions(-)
>
> --
> 2.25.0
>
prev parent reply other threads:[~2020-02-26 1:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 15:58 [PATCH 0/8] Migrate all cros_ec_cmd_xfer() calls to cros_ec_cmd_xfer_status() Enric Balletbo i Serra
2020-02-20 15:58 ` [PATCH 1/8] platform/chrome: cros_ec_proto: Report command not supported Enric Balletbo i Serra
2020-02-20 15:58 ` [PATCH 2/8] Input: cros_ec_keyb: Use cros_ec_cmd_xfer_status helper Enric Balletbo i Serra
2020-03-02 10:08 ` Enric Balletbo i Serra
2020-02-20 15:58 ` [PATCH 3/8] platform/chrome: cros_ec_vbc: " Enric Balletbo i Serra
2020-02-20 15:58 ` [PATCH 4/8] platform/chrome: cros_ec_chardev: " Enric Balletbo i Serra
2020-02-25 19:55 ` Prashant Malani
2020-02-26 14:59 ` Enric Balletbo i Serra
2020-02-26 17:32 ` Prashant Malani
2020-02-20 15:58 ` [PATCH 5/8] platform/chrome: cros_ec_sysfs: " Enric Balletbo i Serra
2020-02-20 15:58 ` [PATCH 6/8] platform/chrome: cros_ec_lightbar: " Enric Balletbo i Serra
2020-02-20 15:58 ` [PATCH 7/8] platform/chrome: cros_ec: " Enric Balletbo i Serra
2020-02-20 15:58 ` [PATCH 8/8] platform/chrome: cros_ec_proto: Do not export cros_ec_cmd_xfer() Enric Balletbo i Serra
2020-02-26 1:12 ` Prashant Malani [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200226011208.GD197302@google.com \
--to=pmalani@chromium.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bleung@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=dtor@chromium.org \
--cc=egranata@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=evgreen@chromium.org \
--cc=fshao@chromium.org \
--cc=groeck@chromium.org \
--cc=gwendal@chromium.org \
--cc=kernel@collabora.com \
--cc=lee.jones@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=phoenixshen@chromium.org \
--cc=pihsun@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.