diff for duplicates of <20200226100112.GD3286@kadam> diff --git a/a/1.txt b/N1/1.txt index 79cf178..d21c307 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -28,7 +28,7 @@ always complicated to undo things which we didn't do. > free_percpu(chan->local); > + chan->local = NULL; > kfree(chan->dev); -> if (atomic_dec_return(idr_ref) == 0) +> if (atomic_dec_return(idr_ref) = 0) > kfree(idr_ref); The ref counting on "idr_ref" is also wrong. @@ -88,7 +88,7 @@ should instead be handled by device_put(). 1009 err_out: 1010 free_percpu(chan->local); 1011 kfree(chan->dev); - 1012 if (atomic_dec_return(idr_ref) == 0) + 1012 if (atomic_dec_return(idr_ref) = 0) 1013 kfree(idr_ref); If alloc_percpu() fails this is decrementing something which was never diff --git a/a/content_digest b/N1/content_digest index f66624b..55fd2d1 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,7 +1,7 @@ "ref\020200226090707.12285-1-christophe.jaillet@wanadoo.fr\0" "From\0Dan Carpenter <dan.carpenter@oracle.com>\0" "Subject\0Re: [PATCH] dmaengine: Simplify error handling path in '__dma_async_device_channel_register()'\0" - "Date\0Wed, 26 Feb 2020 13:01:12 +0300\0" + "Date\0Wed, 26 Feb 2020 10:01:12 +0000\0" "To\0Christophe JAILLET <christophe.jaillet@wanadoo.fr>\0" "Cc\0dan.j.williams@intel.com" vkoul@kernel.org @@ -41,7 +41,7 @@ "> \tfree_percpu(chan->local);\n" "> +\tchan->local = NULL;\n" "> \tkfree(chan->dev);\n" - "> \tif (atomic_dec_return(idr_ref) == 0)\n" + "> \tif (atomic_dec_return(idr_ref) = 0)\n" "> \t\tkfree(idr_ref);\n" "\n" "The ref counting on \"idr_ref\" is also wrong.\n" @@ -101,7 +101,7 @@ " 1009 err_out:\n" " 1010 free_percpu(chan->local);\n" " 1011 kfree(chan->dev);\n" - " 1012 if (atomic_dec_return(idr_ref) == 0)\n" + " 1012 if (atomic_dec_return(idr_ref) = 0)\n" " 1013 kfree(idr_ref);\n" "\n" "If alloc_percpu() fails this is decrementing something which was never\n" @@ -124,4 +124,4 @@ "regards,\n" dan carpenter -c83334347549a3c53e48c11b96f805fe33c59fe4bb2e398bbd2000197273b60e +88838ceee2550efcee173732203e7a48fc468714ee8cfef109fff42632dcc196
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.