From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a19:cb43:0:0:0:0:0 with SMTP id b64csp2812203lfg; Wed, 26 Feb 2020 01:21:00 -0800 (PST) X-Google-Smtp-Source: APXvYqwM4iahYWSEiInxJaR+5d82jgk6pBvvgCzmeuiA2VJ2nRV5cAHka+ow4TCpVg4CFafyPHdy X-Received: by 2002:a37:2c85:: with SMTP id s127mr4279253qkh.136.1582708860761; Wed, 26 Feb 2020 01:21:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582708860; cv=none; d=google.com; s=arc-20160816; b=s2z5Bh4lGb9qjsTa30UxEp3PpVey5TnOcZXYQD2LD+0Zv3A6Cs9XHau85BBB2rDpbF 7J7oDglIqP7MfFSC3tH1FWd2QlY1Na/ZvMFeUGQI8UdAqU7865u5Aa/3fIyXmBMmktXo oRnFsNBZ21LiQcNmon9qI7FnyMN6KPJ0ig5rxjiJFrFowwgJAg2RwDu6GGYcPgS86PQL caP457M4TJsnvo4Ke8tJnJnjMNoDqOIkIwww5l1JDt4HOeRNEHssGQ5JQROR54laSUSL bMYTuvlFz4eKij9tCN1isV/0kZbdB+ANZlvSC5AXADWfM2KSdj/PpKl4xeRgCEfCYn36 eqtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:subject:to:from:date :dkim-signature; bh=nD+UerlV4t23nbd3bpwtLCTBIkmnhsu9yCbAAYrkYfs=; b=kLXGWXyDNVKupv+X8y4IMXndxzdgD3PTQoZlNdgLsm35XU28Pm4G7bTa8nV2u8JR06 9pEl8Tr4VhlkJSC91BBrkz6ftspkGbbpAYS0Piy8yHu/8JMYfv187+6RcUAsMd2u0Ala zWc4pO4xHHkPu5Ht50dPTruwVPWeKaZq5BfQc6x5ZmX+0n3QqOq+Wj/lazvG4xt1YmxL hEUI/M7SBBOY8/E9Nn0wM5MudwQsvBotx/3Sgvvx9VgbtQjKRW5HLHgC+13KL7CiOYI9 vg2LAqqrp5vU4NRXC1n332Cad/C3++L2x9kQtpkpHQL8nH1k++v0vkEJZkpADhhYuOah NklA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b=B1VqTFJK; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d21si824852qtq.40.2020.02.26.01.21.00 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 26 Feb 2020 01:21:00 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b=B1VqTFJK; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:40834 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6ssG-00063F-4Y for alex.bennee@linaro.org; Wed, 26 Feb 2020 04:21:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:40030) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6srE-0004aE-LJ for qemu-arm@nongnu.org; Wed, 26 Feb 2020 04:19:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j6srD-0003BL-7G for qemu-arm@nongnu.org; Wed, 26 Feb 2020 04:19:56 -0500 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:38799 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j6srD-0003AX-0x for qemu-arm@nongnu.org; Wed, 26 Feb 2020 04:19:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582708794; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nD+UerlV4t23nbd3bpwtLCTBIkmnhsu9yCbAAYrkYfs=; b=B1VqTFJKfdd2F5ko/3elEFO+RZ66zhkiD7ull8vNq3KEnM6P4NuROubAgGqtW4fwsRJt9y PxJCaBD5/q0UqUK5fvh5P2UmKieMkNSwqKbbNE5PE9cBo2BgAp3/1rJgFAxe4NMUDJqoMP gtGtrP07/tVgv42xtmuPbGYKGxBqhA8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-78-GJsKWpsaO7CL_heWy6cMqw-1; Wed, 26 Feb 2020 04:19:52 -0500 X-MC-Unique: GJsKWpsaO7CL_heWy6cMqw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 05AD91005512; Wed, 26 Feb 2020 09:19:51 +0000 (UTC) Received: from localhost (unknown [10.43.2.114]) by smtp.corp.redhat.com (Postfix) with ESMTP id 80D84385; Wed, 26 Feb 2020 09:19:49 +0000 (UTC) Date: Wed, 26 Feb 2020 10:19:48 +0100 From: Igor Mammedov To: Niek Linnenbank Subject: Re: Sudden slowdown of ARM emulation in master Message-ID: <20200226101948.786be4b0@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.61 X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , QEMU Developers , qemu-arm , Howard Spoelstra , Paolo Bonzini , Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-arm" X-TUID: FfAU3UxyCq4N On Wed, 26 Feb 2020 00:07:55 +0100 Niek Linnenbank wrote: > Hello Igor and Paolo, does following hack solves issue? diff --git a/accel/tcg/translate-all.c b/accel/tcg/translate-all.c index a08ab11f65..ab2448c5aa 100644 --- a/accel/tcg/translate-all.c +++ b/accel/tcg/translate-all.c @@ -944,7 +944,7 @@ static inline size_t size_code_gen_buffer(size_t tb_size) /* ??? If we relax the requirement that CONFIG_USER_ONLY use the static buffer, we could size this on RESERVED_VA, on the text segment size of the executable, or continue to use the default. */ - tb_size = (unsigned long)(ram_size / 4); + tb_size = MAX_CODE_GEN_BUFFER_SIZE; #endif } if (tb_size < MIN_CODE_GEN_BUFFER_SIZE) { > > Just now I was working on some small fixes for the cubieboard machine and > rebasing my Allwinner H3 branches. > While doing some testing, I noticed that suddenly the machines were much > slower than before. > I only see this happening when I rebase to this commit: > ca6155c0f2bd39b4b4162533be401c98bd960820 ("Merge tag 'patchew/ > 20200219160953.13771-1-imammedo@redhat.com' of > https://github.com/patchew-project/qemu into HEAD") > > Also the avocado tests I'm running started to timeout: > > + AVOCADO_ALLOW_LARGE_STORAGE=yes avocado --show=app,console run -t > machine:cubieboard tests/acceptance/boot_linux_console.py > ... > (1/2) > tests/acceptance/boot_linux_console.py:BootLinuxConsole.test_arm_cubieboard_initrd: > |console: Uncompressing Linux... done, booting the kernel. > |console: Booting Linux on physical CPU 0x0 > console: Linux version 4.20.7-sunxi (root@armbian.com) (gcc version 7.2.1 > 20171011 (Linaro GCC 7.2-2017.11)) #5.75 SMP Fri Feb 8 09:02:10 CET 2019 > console: CPU: ARMv7 Processor [410fc080] revision 0 (ARMv7), cr=50c5387d > console: CPU: PIPT / VIPT nonaliasing data cache, VIPT nonaliasing > instruction cache > console: OF: fdt: Machine model: Cubietech Cubieboard > ... > INTERRUPTED: Test interrupted by SIGTERM\nRunner error occurred: Timeout > reached\n > Original status: ERROR\n{'name': > '1-tests/acceptance/boot_linux_console.py:BootLinuxConsole.test_arm_cubieboard_initrd', > 'logdir': '/home/me/avocado/job-results/job-2020-02-25T23.58-d43884... > (90.41 s) > ... > console: random: crng init done > /console: mount: mounting devtmpfs on /dev failed: Device or resource busy > -console: EXT4-fs (sda): re-mounted. Opts: > block_validity,barrier,user_xattr,acl > /console: Starting logging: OK > INTERRUPTED: Test interrupted by SIGTERM\nRunner error occurred: Timeout > reached\nOriginal status: ERROR\n{'name': > '2-tests/acceptance/boot_linux_console.py:BootLinuxConsole.test_arm_cubieboard_sata', > 'logdir': '/home/fox/avocado/job-results/job-2020-02-25T23.58-d438849/... > (90.53 s) > RESULTS : PASS 0 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 2 | > CANCEL 0 > JOB TIME : 181.22 s > .... > > Have you noticed a similar performance change? > Do you have any clue if there may be something changed here that could > cause a slowdown? > > Regards, > Niek > >