From: Leon Romanovsky <leon@kernel.org>
To: "Marciniszyn, Mike" <mike.marciniszyn@intel.com>
Cc: "Dalessandro, Dennis" <dennis.dalessandro@intel.com>,
"jgg@ziepe.ca" <jgg@ziepe.ca>,
"dledford@redhat.com" <dledford@redhat.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>
Subject: Re: [PATCH for-rc] RDMA/core: Fix additional panic in get_pkey_idx_qp_list()
Date: Wed, 26 Feb 2020 16:13:40 +0200 [thread overview]
Message-ID: <20200226141340.GF12414@unreal> (raw)
In-Reply-To: <MWHPR1101MB22717251968B09F6D695214486EA0@MWHPR1101MB2271.namprd11.prod.outlook.com>
On Wed, Feb 26, 2020 at 02:08:52PM +0000, Marciniszyn, Mike wrote:
> > > You mean this one? https://marc.info/?l=linux-
> > rdma&m=158263596831342&w=2
> >
>
> Ok. I will test the patch.
>
> > Yes, this is what I wanted to achieve by "if (!(qp_attr_mask &
> > (IB_QP_PKEY_INDEX || IB_QP_PORT)) && qp_pps) {" line.
>
> Was a non-bitwise || what was intended in this statememt?
No, another mistake, see commit
commit 4ca501d6aaf21de31541deac35128bbea8427aa6
Author: Nathan Chancellor <natechancellor@gmail.com>
Date: Mon Feb 17 13:43:18 2020 -0700
RDMA/core: Fix use of logical OR in get_new_pps
It is still mystery but we didn't see failures with "broken" code.
Thanks
> >
>
> Mike
next prev parent reply other threads:[~2020-02-26 14:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-25 13:31 [PATCH for-rc] RDMA/core: Fix additional panic in get_pkey_idx_qp_list() Mike Marciniszyn
2020-02-26 13:04 ` Leon Romanovsky
2020-02-26 13:25 ` Dennis Dalessandro
2020-02-26 13:48 ` Leon Romanovsky
2020-02-26 14:08 ` Marciniszyn, Mike
2020-02-26 14:13 ` Leon Romanovsky [this message]
2020-02-26 17:58 ` Marciniszyn, Mike
2020-02-27 7:13 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200226141340.GF12414@unreal \
--to=leon@kernel.org \
--cc=dennis.dalessandro@intel.com \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=linux-rdma@vger.kernel.org \
--cc=mike.marciniszyn@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.