From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linutronix.de (193.142.43.55:993) by crypto-ml.lab.linutronix.de with IMAP4-SSL for ; 26 Feb 2020 18:00:04 -0000 Received: from mx2.suse.de ([195.135.220.15]) by Galois.linutronix.de with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1j70yZ-0003a4-3N for speck@linutronix.de; Wed, 26 Feb 2020 19:00:03 +0100 Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 3E166AF0D for ; Wed, 26 Feb 2020 17:59:56 +0000 (UTC) Date: Wed, 26 Feb 2020 18:59:50 +0100 From: Borislav Petkov Subject: [MODERATED] Re: [PATCH v2 1/2] v2: more sampling fun 1 Message-ID: <20200226175950.GD17448@zn.tnic> References: <20200226110737.GB17448@zn.tnic> <20200226171103.GA114268@mtg-dev.jf.intel.com> MIME-Version: 1.0 In-Reply-To: <20200226171103.GA114268@mtg-dev.jf.intel.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable To: speck@linutronix.de List-ID: On Wed, Feb 26, 2020 at 09:11:03AM -0800, speck for mark gross wrote: > Yeah, Andi pointed it out to me on an internal review. I don't know what t= ool > is using it. Then how do you write a patch and state in the commit message that something is an ABI without knowing what the situation actually is?! > FWIW doing it this way made a cleaner patch without touching a dozen other > files using that structure. I'd rather stay with the way it is but, if you > feel strongly I can do a version of what I had before only adding the new > members to the end. Please let me know. Looking at that table again - cpu_vuln_whitelist - that is a *whitelist*. See how all the bits start with "NO_"? Except maybe MSBDS_ONLY. What you're doing is, you're misusing it to match models and steppings to set SRBDS* bug flags. What you should actually be doing is setting those bug flags in early_init_intel() where you can go wild with the steppings checking and then you won't need to touch x86_cpu_id at all. IMO. --=20 Regards/Gruss, Boris. SUSE Software Solutions Germany GmbH, GF: Felix Imend=C3=B6rffer, HRB 36809, = AG N=C3=BCrnberg --=20